Hi all,
Bug #3062455 (Functions/Procedures should come first in export), suggest to export functions and procedures before views, because on import, on error might occur when a view uses a function/procedure that is not existent.
Now, the export of Functions/Procedures/Events is done in PMA_exportDBFooter(). Is there any specific reason why they are exported last? Otherwise, I'll move them to PMA_exportDBCreate(), and test if it works.
Dieter Adriaenssens a écrit :
Hi all,
Bug #3062455 (Functions/Procedures should come first in export), suggest to export functions and procedures before views, because on import, on error might occur when a view uses a function/procedure that is not existent.
Now, the export of Functions/Procedures/Events is done in PMA_exportDBFooter(). Is there any specific reason why they are exported last? Otherwise, I'll move them to PMA_exportDBCreate(), and test if it works.
Dieter, please test if a function can be defined even if the tables it uses are not yet defined.
P.S. I just made a test with current master and with either Quick or Custom methods, functions, procedures and events are missing from the export.
Hi,
2010/9/11 Marc Delisle marc@infomarc.info:
Dieter Adriaenssens a écrit :
Hi all,
Bug #3062455 (Functions/Procedures should come first in export), suggest to export functions and procedures before views, because on import, on error might occur when a view uses a function/procedure that is not existent.
Now, the export of Functions/Procedures/Events is done in PMA_exportDBFooter(). Is there any specific reason why they are exported last? Otherwise, I'll move them to PMA_exportDBCreate(), and test if it works.
Dieter, please test if a function can be defined even if the tables it uses are not yet defined.
It is possible to define a routine (function/procedure) with a non-existing table. An error message appears when executing the routine, but not when creating it.
P.S. I just made a test with current master and with either Quick or Custom methods, functions, procedures and events are missing from the export.
I guess they should be exported. ;)
-- Marc Delisle http://infomarc.info
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Dieter Adriaenssens a écrit :
Hi,
2010/9/11 Marc Delisle marc@infomarc.info:
P.S. I just made a test with current master and with either Quick or Custom methods, functions, procedures and events are missing from the export.
I guess they should be exported. ;)
Fixed in commit 598d3b898d.
2010/9/19 Marc Delisle marc@infomarc.info:
Dieter Adriaenssens a écrit :
Hi,
2010/9/11 Marc Delisle marc@infomarc.info:
P.S. I just made a test with current master and with either Quick or Custom methods, functions, procedures and events are missing from the export.
I guess they should be exported. ;)
Fixed in commit 598d3b898d.
I just prepared an identical fix, but couldn't push it because there were changes in master. ;)
-- Marc Delisle http://infomarc.info
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Dieter Adriaenssens a écrit :
2010/9/19 Marc Delisle marc@infomarc.info:
Dieter Adriaenssens a écrit :
Hi,
2010/9/11 Marc Delisle marc@infomarc.info:
P.S. I just made a test with current master and with either Quick or Custom methods, functions, procedures and events are missing from the export.
I guess they should be exported. ;)
Fixed in commit 598d3b898d.
I just prepared an identical fix, but couldn't push it because there were changes in master. ;)
Hi Dieter, do you have merge conflicts? Normally you just have to pull from master then push to it.
2010/9/19 Marc Delisle marc@infomarc.info:
Dieter Adriaenssens a écrit :
2010/9/19 Marc Delisle marc@infomarc.info:
Dieter Adriaenssens a écrit :
Hi,
2010/9/11 Marc Delisle marc@infomarc.info:
P.S. I just made a test with current master and with either Quick or Custom methods, functions, procedures and events are missing from the export.
I guess they should be exported. ;)
Fixed in commit 598d3b898d.
I just prepared an identical fix, but couldn't push it because there were changes in master. ;)
Hi Dieter, do you have merge conflicts? Normally you just have to pull from master then push to it.
Hi Marc,
No conflicts. I did a pull, looked into functions/procedures/events not exporting in master, fixed it, committed (locally) and pushed it. But it gave an error, because in the mean time, you had pushed two commits, one of them fixing the same problem. So we just fixed the same bug more or less on the same moment, but you were quicker in submitting it to the repository. ;) Maybe I should have done a pull before doing the push. Is it good practice?
BTW : I removed my local commit.
Greets,
Dieter
-- Marc Delisle http://infomarc.info
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Dieter Adriaenssens a écrit :
2010/9/19 Marc Delisle marc@infomarc.info:
Dieter Adriaenssens a écrit :
2010/9/19 Marc Delisle marc@infomarc.info:
Dieter Adriaenssens a écrit :
Hi,
2010/9/11 Marc Delisle marc@infomarc.info:
P.S. I just made a test with current master and with either Quick or Custom methods, functions, procedures and events are missing from the export.
I guess they should be exported. ;)
Fixed in commit 598d3b898d.
I just prepared an identical fix, but couldn't push it because there were changes in master. ;)
Hi Dieter, do you have merge conflicts? Normally you just have to pull from master then push to it.
Hi Marc,
No conflicts. I did a pull, looked into functions/procedures/events not exporting in master, fixed it, committed (locally) and pushed it. But it gave an error, because in the mean time, you had pushed two commits, one of them fixing the same problem. So we just fixed the same bug more or less on the same moment, but you were quicker in submitting it to the repository. ;) Maybe I should have done a pull before doing the push. Is it good practice?
I think that it's a good practice to frequently pull.
-
Dieter Adriaenssens -
Marc Delisle