[Phpmyadmin-devel] "Monitor" broken in master
Tyron, The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure. Rouslan
On Sat, Aug 20, 2011 at 6:34 PM, Rouslan Placella <rouslan@placella.com> wrote:
Tyron,
The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure.
Rouslan
This is really odd because the error doesn't seem to be caused by any change in the related files functions.js, server_status.php, server_status.js or server_status_monitor.js On my fork (http://demo.phpmyadmin.net/gsoc-tyron) the charts still work. And replacing any of above files on the master version did not have any effect.
------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Sat, Aug 20, 2011 at 8:45 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 6:34 PM, Rouslan Placella <rouslan@placella.com> wrote:
Tyron,
The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure.
Rouslan
This is really odd because the error doesn't seem to be caused by any change in the related files functions.js, server_status.php, server_status.js or server_status_monitor.js
On my fork (http://demo.phpmyadmin.net/gsoc-tyron) the charts still work. And replacing any of above files on the master version did not have any effect.
The json data still is transferred and added to each chart correctly. But the highchart charts doesn't recognize the millisecond-timestamp as a correct time anymore.
------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Sat, Aug 20, 2011 at 8:47 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 8:45 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 6:34 PM, Rouslan Placella <rouslan@placella.com> wrote:
Tyron,
The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure.
Rouslan
This is really odd because the error doesn't seem to be caused by any change in the related files functions.js, server_status.php, server_status.js or server_status_monitor.js
On my fork (http://demo.phpmyadmin.net/gsoc-tyron) the charts still work. And replacing any of above files on the master version did not have any effect.
The json data still is transferred and added to each chart correctly. But the highchart charts doesn't recognize the millisecond-timestamp as a correct time anymore.
Oh ok found the error. Michal encapsed all the js variables in strings, thus breaking the server time calculation.
------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Sat, Aug 20, 2011 at 8:53 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 8:47 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 8:45 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 6:34 PM, Rouslan Placella <rouslan@placella.com> wrote:
Tyron,
The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure.
Rouslan
This is really odd because the error doesn't seem to be caused by any change in the related files functions.js, server_status.php, server_status.js or server_status_monitor.js
On my fork (http://demo.phpmyadmin.net/gsoc-tyron) the charts still work. And replacing any of above files on the master version did not have any effect.
The json data still is transferred and added to each chart correctly. But the highchart charts doesn't recognize the millisecond-timestamp as a correct time anymore.
Oh ok found the error. Michal encapsed all the js variables in strings, thus breaking the server time calculation.
Michal, I wouldn't know how to fix this nicely, other than reverting your changes in replacing PMA_AddJSCode() with PMA_AddJSVar(). (Also I find this newline formatting there a bit extreme) The calculation of server_time_diff should not be moved into the javascript files as this will result in greater inaccuracy of the variable value.
------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On Sat, Aug 20, 2011 at 9:02 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 8:53 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 8:47 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 8:45 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 6:34 PM, Rouslan Placella <rouslan@placella.com> wrote:
Tyron,
The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure.
Rouslan
This is really odd because the error doesn't seem to be caused by any change in the related files functions.js, server_status.php, server_status.js or server_status_monitor.js
On my fork (http://demo.phpmyadmin.net/gsoc-tyron) the charts still work. And replacing any of above files on the master version did not have any effect.
The json data still is transferred and added to each chart correctly. But the highchart charts doesn't recognize the millisecond-timestamp as a correct time anymore.
Oh ok found the error. Michal encapsed all the js variables in strings, thus breaking the server time calculation.
Michal,
I wouldn't know how to fix this nicely, other than reverting your changes in replacing PMA_AddJSCode() with PMA_AddJSVar(). (Also I find this newline formatting there a bit extreme) The calculation of server_time_diff should not be moved into the javascript files as this will result in greater inaccuracy of the variable value.
Or PMA_AddJSVar() adds the js without using the escape function PMA_getJsValue()
------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Dne Sat, 20 Aug 2011 20:53:41 +0300 Tyron Madlener <tyronx@gmail.com> napsal(a):
On Sat, Aug 20, 2011 at 8:47 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 8:45 PM, Tyron Madlener <tyronx@gmail.com> wrote:
On Sat, Aug 20, 2011 at 6:34 PM, Rouslan Placella <rouslan@placella.com> wrote:
Tyron,
The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure.
Rouslan
This is really odd because the error doesn't seem to be caused by any change in the related files functions.js, server_status.php, server_status.js or server_status_monitor.js
On my fork (http://demo.phpmyadmin.net/gsoc-tyron) the charts still work. And replacing any of above files on the master version did not have any effect.
The json data still is transferred and added to each chart correctly. But the highchart charts doesn't recognize the millisecond-timestamp as a correct time anymore.
Oh ok found the error. Michal encapsed all the js variables in strings, thus breaking the server time calculation.
The reason for this was proper escaping of the variables (for example original code would break on database name containing ', I somehow missed that one of them is javascript code which should not be escaped. Fixed in master now. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
Since Michal doesn't seem to be around I rewrote his PMA_AddJSVar() a little in a way I would imagine would follow his intentions. Maybe someone could merge my tree to master so the monitor works again there. Thanks! On Sat, Aug 20, 2011 at 6:34 PM, Rouslan Placella <rouslan@placella.com> wrote:
Tyron,
The monitor in current master is now broken. New datapoints are not plotted correctly anymore. Screenshot attached. I think this happened some time yesterday and may have to do with those optimisations that Piotr pushed, though I'm not sure.
Rouslan
------------------------------------------------------------------------------ Get a FREE DOWNLOAD! and learn more about uberSVN rich system, user administration capabilities and model configuration. Take the hassle out of deploying and managing Subversion and the tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
participants (3)
-
Michal Čihař -
Rouslan Placella -
Tyron Madlener