[Phpmyadmin-devel] Custom buttons
Hi all I just noticed that Lori started to use styled buttons in her branch [1]. I personally think that it is better just to keep browser default ones because it then matches style of other controls like combo boxes. What do others think? [1]:http://demo.phpmyadmin.net/gsoc-lorilee/ -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Hi all
I just noticed that Lori started to use styled buttons in her branch [1]. I personally think that it is better just to keep browser default ones because it then matches style of other controls like combo boxes. What do others think?
As she is working on usability, maybe this is a usability issue. Anyway, she is using -moz-border-radius that AFAIK has no effect under IE 8. Michal, what would you say if a custom theme designer wanted to display buttons in a different way? Isn't this issue a theme-specific issue? -- Marc Delisle http://infomarc.info
Hi Dne Mon, 28 Jun 2010 08:10:06 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
As she is working on usability, maybe this is a usability issue. Anyway, she is using -moz-border-radius that AFAIK has no effect under IE 8.
Michal, what would you say if a custom theme designer wanted to display buttons in a different way? Isn't this issue a theme-specific issue?
Yes it is theme specific and it is currently defined in theme. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
I do realize that some of the CSS3 properties don't work under certain browsers but I felt that the original button on its own was quite small, which is why I designed it that way. I was thinking, as an alternative, to create an image of the button and set it as the background image so that it would look consistent under different browsers. On Mon, Jun 28, 2010 at 8:12 AM, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Mon, 28 Jun 2010 08:10:06 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
As she is working on usability, maybe this is a usability issue. Anyway, she is using -moz-border-radius that AFAIK has no effect under IE 8.
Michal, what would you say if a custom theme designer wanted to display buttons in a different way? Isn't this issue a theme-specific issue?
Yes it is theme specific and it is currently defined in theme.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Thanks, Lori
Lori Lee a écrit :
I do realize that some of the CSS3 properties don't work under certain browsers but I felt that the original button on its own was quite small, which is why I designed it that way. I was thinking, as an alternative, to create an image of the button and set it as the background image so that it would look consistent under different browsers.
Lori, do you intend to propose such an enlarged Go button on all panels, for consistency? -- Marc Delisle http://infomarc.info
The thing is that the Go buttons on other panels are enclosed in a fieldset element, which makes the button easier to see. On the import and export forms, I removed the fieldsets. I did not intend to propose enlarged buttons on the other panels though now that I think about it, it does look pretty inconsistent with the other panels. As a solution, I could enclose the entire import and export forms, except the submit button, in a fieldset and use the original Go button. On Mon, Jun 28, 2010 at 10:25 AM, Marc Delisle <marc@infomarc.info> wrote:
Lori Lee a écrit :
I do realize that some of the CSS3 properties don't work under certain browsers but I felt that the original button on its own was quite small, which is why I designed it that way. I was thinking, as an alternative, to create an image of the button and set it as the background image so that it would look consistent under different browsers.
Lori, do you intend to propose such an enlarged Go button on all panels, for consistency?
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Thanks, Lori
Actually, I think it would be odd to enclose the entire form in a fieldset because fieldsets are intended to "group thematically related controls and labels." So yes I *would* like to have the same style of buttons in the rest of the panels but I am not completely sure that I will have time to implement it... On Mon, Jun 28, 2010 at 10:44 AM, Lori Lee <leelorik@gmail.com> wrote:
The thing is that the Go buttons on other panels are enclosed in a fieldset element, which makes the button easier to see. On the import and export forms, I removed the fieldsets. I did not intend to propose enlarged buttons on the other panels though now that I think about it, it does look pretty inconsistent with the other panels.
As a solution, I could enclose the entire import and export forms, except the submit button, in a fieldset and use the original Go button.
On Mon, Jun 28, 2010 at 10:25 AM, Marc Delisle <marc@infomarc.info> wrote:
Lori Lee a écrit :
I do realize that some of the CSS3 properties don't work under certain browsers but I felt that the original button on its own was quite small, which is why I designed it that way. I was thinking, as an alternative, to create an image of the button and set it as the background image so that it would look consistent under different browsers.
Lori, do you intend to propose such an enlarged Go button on all panels, for consistency?
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Thanks, Lori
-- Thanks, Lori
participants (3)
-
Lori Lee -
Marc Delisle -
Michal Čihař