Mike,
Pending is my previous question about custom background color; here is another question.
In themes/pmahomme/layout.inc.php, $GLOBALS['cfg']['MainBackground'] is defined to "#F5F5F5". However in css/theme_right.css.php it's only used for ul#topmenu ul
whereas the body CSS uses a constant "#fff" for background.
Hi Marc,
I see what you mean and have looked into how to fix this.
When I first designed PMAhomme I didn't envision a user wanting to change themes and further change it by setting a background color.
This makes the background setting feature a bit more difficult to fix now. PMAhomme, in a few key places, makes use of images for backgrounds vs. the Original theme, which relied mainly on a hexadecimal color codes for almost everything (background-wise at least).
Even if I were to restore all references to the global [MainBackground] setting in the CSS, it still wouldn't look right.
At this point, I'm questioning the value of the background feature on the main panel. Does the team feel strongly that it's a feature worth keeping around for 3.4? If so, maybe it should be available only for users that upgrade to 3.4 and continue to use the "Original" theme.
Mike
-----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Wednesday, March 16, 2011 7:49 AM To: phpmyadmin-devel@lists.sf.net Subject: [Phpmyadmin-devel] pmahomme questions
Mike,
Pending is my previous question about custom background color; here is another question.
In themes/pmahomme/layout.inc.php, $GLOBALS['cfg']['MainBackground'] is defined to "#F5F5F5". However in css/theme_right.css.php it's only used for ul#topmenu ul
whereas the body CSS uses a constant "#fff" for background.
-- Marc Delisle http://infomarc.info
---------------------------------------------------------------------------- -- Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-03-16 22:03, Mike Homme a écrit :
Hi Marc,
(...)
At this point, I'm questioning the value of the background feature on the main panel. Does the team feel strongly that it's a feature worth keeping around for 3.4? If so, maybe it should be available only for users that upgrade to 3.4 and continue to use the "Original" theme.
Mike
(Please do not top-post on this list).
This was a feature requested by some users who are watching many servers at once and want to quickly recognize them. We can discuss whether we want to keep this feature. It could also become a custom color not applied to the background but let's say to another top part of the screen.
Also, it's not only about the "Original" theme, it's about all the other themes.
Hi
Dne Thu, 17 Mar 2011 05:53:31 -0400 Marc Delisle marc@infomarc.info napsal(a):
This was a feature requested by some users who are watching many servers at once and want to quickly recognize them. We can discuss whether we want to keep this feature. It could also become a custom color not applied to the background but let's say to another top part of the screen.
Also, it's not only about the "Original" theme, it's about all the other themes.
Well, I don't see really big difference how other (current) themes handle this situation. Actually only one which displays fine is Emphasis. All others set it just for part of the navigation frame and there are (random) bits of main frame with old color left as well.
However you're right that only Original, Darkblue/Orange and Graphite honor saved color.
Honestly choosing just background color looks wrong to me, it can easily lead to unreadable text as the theme is designed with some background in mind.
Taking all this into account, I'd drop this feature.
Michal Čihař a écrit :
Hi
Dne Thu, 17 Mar 2011 05:53:31 -0400 Marc Delisle marc@infomarc.info napsal(a):
This was a feature requested by some users who are watching many servers at once and want to quickly recognize them. We can discuss whether we want to keep this feature. It could also become a custom color not applied to the background but let's say to another top part of the screen.
Also, it's not only about the "Original" theme, it's about all the other themes.
Well, I don't see really big difference how other (current) themes handle this situation. Actually only one which displays fine is Emphasis. All others set it just for part of the navigation frame and there are (random) bits of main frame with old color left as well.
However you're right that only Original, Darkblue/Orange and Graphite honor saved color.
Honestly choosing just background color looks wrong to me, it can easily lead to unreadable text as the theme is designed with some background in mind.
Taking all this into account, I'd drop this feature.
We could deactivate the feature for -rc1 and see the reactions of the community.
Dne Thu, 17 Mar 2011 09:48:15 -0400 Marc Delisle marc@infomarc.info napsal(a):
We could deactivate the feature for -rc1 and see the reactions of the community.
Fine for me.
-
Marc Delisle -
Michal Čihař -
Mike Homme