[Phpmyadmin-devel] DefaultCharset = 'en-utf-8' ?
select_lang.lib.php#346: $convcharset = isset($GLOBALS['cfg']['DefaultCharset']) ? $GLOBALS['cfg']['DefaultCharset'] : 'en-utf-8'; shouldn't this be 'utf-8' without 'en'? -- Sebastian
On Wed, 24 Oct 2007 09:34:52 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
select_lang.lib.php#346:
$convcharset = isset($GLOBALS['cfg']['DefaultCharset']) ? $GLOBALS['cfg']['DefaultCharset'] : 'en-utf-8';
shouldn't this be 'utf-8' without 'en'?
Shouldn't cfg be always set since we're using default config stuff? -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař schrieb:
On Wed, 24 Oct 2007 09:34:52 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
select_lang.lib.php#346:
$convcharset = isset($GLOBALS['cfg']['DefaultCharset']) ? $GLOBALS['cfg']['DefaultCharset'] : 'en-utf-8';
shouldn't this be 'utf-8' without 'en'?
Shouldn't cfg be always set since we're using default config stuff?
yes, it should, but i just wanted to verify that this is the wrong value, and not the one in default config ... -- Sebastian
On Wed, 24 Oct 2007 10:44:03 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
Michal Čihař schrieb:
On Wed, 24 Oct 2007 09:34:52 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
select_lang.lib.php#346:
$convcharset = isset($GLOBALS['cfg']['DefaultCharset']) ? $GLOBALS['cfg']['DefaultCharset'] : 'en-utf-8';
shouldn't this be 'utf-8' without 'en'?
Shouldn't cfg be always set since we're using default config stuff?
yes, it should, but i just wanted to verify that this is the wrong value, and not the one in default config ...
Yes 'en-utf-8' is IMHO wrong. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
On Wed, 24 Oct 2007 09:34:52 +0200 Sebastian Mendel <lists@sebastianmendel.de> wrote:
select_lang.lib.php#346:
$convcharset = isset($GLOBALS['cfg']['DefaultCharset']) ? $GLOBALS['cfg']['DefaultCharset'] : 'en-utf-8';
shouldn't this be 'utf-8' without 'en'?
Shouldn't cfg be always set since we're using default config stuff?
If everything goes right, yes. If there is a session.save_path problem, no. See http://phpmyadmin.svn.sourceforge.net/viewvc/phpmyadmin/trunk/phpMyAdmin/lib... but I agree that I should have placed 'utf-8' in this patch. So we should put back the line as in revision 10420, except 'utf-8' instead of 'en-utf-8. ok?
------------------------------------------------------------------------
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
------------------------------------------------------------------------
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
participants (3)
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel