Hi all
I've played a little bit with javascript and hacked notifications about newer version available on phpMyAdmin main page. It is asynchronous so it should not block page loading and if the request is blocked for whatever reason, nothing happens. Patch is attached.
Such feature is quite common for web applications, however I'm still not sure if we want to introduce such thing on main page. Opinions?
PS: We already have check in setup, but it requires server side access to download from remote sites what is often prohibited. And nobody visits setup after the application is installed.
Michal Čihař a écrit :
Hi all
I've played a little bit with javascript and hacked notifications about newer version available on phpMyAdmin main page. It is asynchronous so it should not block page loading and if the request is blocked for whatever reason, nothing happens. Patch is attached.
Such feature is quite common for web applications, however I'm still not sure if we want to introduce such thing on main page. Opinions?
PS: We already have check in setup, but it requires server side access to download from remote sites what is often prohibited. And nobody visits setup after the application is installed.
Hi Michal, I welcome this idea, especially if it's asynchronous; but the patch fails to apply on current master.
Hi
Dne Wed, 02 Feb 2011 07:26:14 -0500 Marc Delisle marc@infomarc.info napsal(a):
I welcome this idea, especially if it's asynchronous; but the patch fails to apply on current master.
I probably changed some context meanwhile, but as there does not seem to be anybody against it, I'll merge it.
2011/2/2 Michal Čihař michal@cihar.com:
Hi all
I've played a little bit with javascript and hacked notifications about newer version available on phpMyAdmin main page. It is asynchronous so it should not block page loading and if the request is blocked for whatever reason, nothing happens. Patch is attached.
Such feature is quite common for web applications, however I'm still not sure if we want to introduce such thing on main page. Opinions?
PS: We already have check in setup, but it requires server side access to download from remote sites what is often prohibited. And nobody visits setup after the application is installed.
It would be nice to have such a feature, but there must be a configuration option allowing to disable version check - it's ok for personal use, will become annoying for shared hosting installations, also some people may not like PMA calling home.
Piotr Przybylski a écrit :
2011/2/2 Michal Čihař michal@cihar.com:
Hi all
I've played a little bit with javascript and hacked notifications about newer version available on phpMyAdmin main page. It is asynchronous so it should not block page loading and if the request is blocked for whatever reason, nothing happens. Patch is attached.
Such feature is quite common for web applications, however I'm still not sure if we want to introduce such thing on main page. Opinions?
PS: We already have check in setup, but it requires server side access to download from remote sites what is often prohibited. And nobody visits setup after the application is installed.
It would be nice to have such a feature, but there must be a configuration option allowing to disable version check - it's ok for personal use, will become annoying for shared hosting installations, also some people may not like PMA calling home.
Good point Piotr.
Also if someone is told to upgrade from his 2.11.x to 3.x and his server does not have the appropriate minimum PHP and MySQL versions, the message should be worded accordingly.
Hi
Dne Wed, 02 Feb 2011 07:58:47 -0500 Marc Delisle marc@infomarc.info napsal(a):
It would be nice to have such a feature, but there must be a configuration option allowing to disable version check - it's ok for personal use, will become annoying for shared hosting installations, also some people may not like PMA calling home.
Indeed, I was thinking about it as well.
Also if someone is told to upgrade from his 2.11.x to 3.x and his server does not have the appropriate minimum PHP and MySQL versions, the message should be worded accordingly.
I'm by no means going to put this patch to 2.11 branch, so this would never happen. Should there ever be so drastic change in requirements in future, it might be problem, but I don't expect it right now.
On Wednesday 02 February 2011 14:19:37 Michal Čihař wrote:
Dne Wed, 02 Feb 2011 07:58:47 -0500
Marc Delisle marc@infomarc.info napsal(a):
It would be nice to have such a feature, but there must be a configuration option allowing to disable version check - it's ok for personal use, will become annoying for shared hosting installations, also some people may not like PMA calling home.
Indeed, I was thinking about it as well.
And distributions packaging phpmyadmin would probably want to disable the check in the default configuration.
Thijs
Hi
Dne Sat, 5 Feb 2011 10:29:03 +0100 Thijs Kinkhorst thijs@debian.org napsal(a):
On Wednesday 02 February 2011 14:19:37 Michal Čihař wrote:
Dne Wed, 02 Feb 2011 07:58:47 -0500
Marc Delisle marc@infomarc.info napsal(a):
It would be nice to have such a feature, but there must be a configuration option allowing to disable version check - it's ok for personal use, will become annoying for shared hosting installations, also some people may not like PMA calling home.
Indeed, I was thinking about it as well.
And distributions packaging phpmyadmin would probably want to disable the check in the default configuration.
Yes, it's also part of vendor configuration file.
Hi,
2011/2/2 Michal Čihař michal@cihar.com:
Hi all
I've played a little bit with javascript and hacked notifications about newer version available on phpMyAdmin main page. It is asynchronous so it should not block page loading and if the request is blocked for whatever reason, nothing happens. Patch is attached.
Such feature is quite common for web applications, however I'm still not sure if we want to introduce such thing on main page. Opinions?
I think it's a good idea to have such a feature. If there is a new version, at least you will be notified (if you're not subcribed to phpmyadmin-users mailinglist, or following the news-feed).
It can be useful to only show it to an admin, i.e. the person how is able to upgrade the application, but that would be difficult to find out, as the mysql_users table doesn't give that kind of info.
BTW: Will you distinguish between major/minor versions? I mean, if you are running 2.11.* will you only get notified of the newest 2.11.* release, or will it show 3.3.9?
PS: We already have check in setup, but it requires server side access to download from remote sites what is often prohibited. And nobody visits setup after the application is installed.
True. Most people only visit it one time, not even when doing an upgrade. But when you're already doing an upgrade, you probably know there is a newer version.
Hi
Dne Wed, 2 Feb 2011 13:28:40 +0100 Dieter Adriaenssens dieter.adriaenssens@gmail.com napsal(a):
It can be useful to only show it to an admin, i.e. the person how is able to upgrade the application, but that would be difficult to find out, as the mysql_users table doesn't give that kind of info.
Exactly, I don't see way to figure it out.
BTW: Will you distinguish between major/minor versions? I mean, if you are running 2.11.* will you only get notified of the newest 2.11.* release, or will it show 3.3.9?
It will currently show 3.3.9. Anyway we want people to upgrade if possible, so I don't think it makes sense to filter versions somehow. Nobody knows what will be 4.x if we will ever get to the point calling something 4.x.
-
Dieter Adriaenssens -
Marc Delisle -
Michal Čihař -
Piotr Przybylski -
Thijs Kinkhorst