Hello my name is Mohamed Ashraf I am a prospective GSOC applicant. I have been sending emails to the mailing list for some time now but due to complications in my subscription in the mailing list it was not being received. Sorry if this is a bit late.
I was reading your Ideas list and saw the refactoring of the sql executor. I wanted to ask what is your final vision for it. what do you feel as the best design.
Also if there are any bugs or features related to the executor that I could submit with my proposal. I have already done two pull requests, a feature and a bug, but I believe it would have been better if the patch was more related to my proposal
Le 2013-04-30 11:45, Mohamed Ashraf a écrit :
Hello my name is Mohamed Ashraf I am a prospective GSOC applicant. I have been sending emails to the mailing list for some time now but due to complications in my subscription in the mailing list it was not being received. Sorry if this is a bit late.
I was reading your Ideas list and saw the refactoring of the sql executor. I wanted to ask what is your final vision for it. what do you feel as the best design.
Hi, well, it's up to students to come up with a design.
Also if there are any bugs or features related to the executor that I could submit with my proposal. I have already done two pull requests, a feature and a bug, but I believe it would have been better if the patch was more related to my proposal
Indeed, so have a look at http://en.wikipedia.org/wiki/Code_refactoring#List_of_refactoring_techniques
as I believe that the most used techniques to refactor our codebase are componentization and "extract method".
well, it's up to students to come up with a design.
well ofcourse but you chose it as one of the ideas for gsoc because you feel that there are problems in the code design. other than the fact that it is using echo rather than the new method for outputting html what else do you think should be changed.
Le 2013-04-30 17:07, Mohamed Ashraf a écrit :
well, it's up to students to come up with a design.
well ofcourse but you chose it as one of the ideas for gsoc because you feel that there are problems in the code design. other than the fact that it is using echo rather than the new method for outputting html what else do you think should be changed.
Here are a few ideas about sql.php:
- script is too long, contains long segments of code that need to be moved to functions; compare it with tbl_select.php which has been refactored last year)
- the way other scripts are calling sql.php should be improved, maybe avoiding the use of include statements
I wish you have a look at sql.php by yourself.
-
Marc Delisle -
Mohamed Ashraf