On 07/28/2013 04:12 PM, Dieter Adriaenssens wrote:

2013/7/24 Mohamed Ashraf mohamed.ashraf.213@gmail.com:

...

Currently souceforge does not offer an api to get the list of milestones that are available to a bug ticket. So for the bug report submission I have 3 choices. the first is just to leave the milestone field blank and it appears as "milestone none" in the issue tracker. the second is to allow the submitter to write down (not select) the milestone at the time of submission. this milestone has to match one of the milestones in the project otherwise a validation error is returned. The third would be to submit a bogus report with a wrong milestone. The error returned has within the message the list of milestones available. I may be able to use regular expressions to get the list of milestones.

The problems with the last approach is that one it is a hack, two is that I would have to do a bogus ticket submission every time I need the list of milestones which changes every release and three is that if sourceforge changes the way the error string is returned there is going to be a problem. -- Mohamed Ashraf

I'd go for option one : leave it blank. But if possible mention the version affected in the description.

I agree Dieter, option #1 sounds the best.

Bye, Rouslan

Le 2013-07-28 12:10, Bin Zu a écrit :

Hi guys,

I am refactoring the code about display import : libraries/display_import.lib.php

[Codes] one issue is to render HTML (including Javascript) at once on PHP. the old code: https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/display_impor... refactor code: https://github.com/xmujay/phpmyadmin/blob/2660fb048166b42381d4f0b6ae627f8f1a...

Hi Bin, by the way, in your refactored code, the function PMA_getHtmlForImportNoPlugin() should be renamed. It does not contain code for the situation when there is no plugin, but when there _is_ a plugin.

[Situation] One diffcult issue is : https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/display_impor... this line means, when the import finished, $GLOBALS['reload']= true, and the navigation panel will be refreshed.

This has for effect of reloading both navigation and main panel.

But now I render all JS on PHP. (It will be moved to seperated JS file on the future) the corresponding code : https://github.com/xmujay/phpmyadmin/blob/2660fb048166b42381d4f0b6ae627f8f1a...

[Question] my question is, where should I put the code "$GLOBALS['reload']", so that the navigation panel will be refreshed after import It is not woking after L568, since the HTML is not not rendered yet.

If you can do it at the js level, use this: PMA_reloadNavigation();