Howdy phpMyAdmin devs. Looking at phpMyAdmin 4.5.0rc I notice the new "sql-parser" library. => No bundled library rules I think this is: https://github.com/dmitry-php/sql-parser But this one seems stalled (June) while the version in phpMyAdmin 4.5 have more recent changes (August). Questions: - as dmitry-php/sql-parser is registered on packagist, will it be updated soon ? - a "rc" release could be nice (in sync with phpMyAdmin RC) - a "stable" release could be nice (perhaps in sync with phpMyAdmin 4.5) - why not use a git sub-modules to keep change easy ? Current master version submitted to review for Fedora [1] to be usable from phpMyAdmin, but of course, need to be updated first. And vendor_config.php also need to be updated (patch attached) Regards, Remi. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1262807
Le 2015-09-14 09:12, Remi Collet a écrit :
Howdy phpMyAdmin devs.
Looking at phpMyAdmin 4.5.0rc I notice the new "sql-parser" library.
=> No bundled library rules
I think this is: https://github.com/dmitry-php/sql-parser
Hello Remi, no, this is https://github.com/udan11/sql-parser
But this one seems stalled (June) while the version in phpMyAdmin 4.5 have more recent changes (August).
Questions: - as dmitry-php/sql-parser is registered on packagist, will it be updated soon ? - a "rc" release could be nice (in sync with phpMyAdmin RC) - a "stable" release could be nice (perhaps in sync with phpMyAdmin 4.5) - why not use a git sub-modules to keep change easy ?
Current master version submitted to review for Fedora [1] to be usable from phpMyAdmin, but of course, need to be updated first.
And vendor_config.php also need to be updated (patch attached)
Regards, Remi.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1262807
_______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
-- Marc Delisle | phpMyAdmin
On Mon, Sep 14, 2015 at 4:12 PM, Remi Collet <Fedora@famillecollet.com> wrote:
Howdy phpMyAdmin devs.
Looking at phpMyAdmin 4.5.0rc I notice the new "sql-parser" library.
=> No bundled library rules
I think this is: https://github.com/dmitry-php/sql-parser
But this one seems stalled (June) while the version in phpMyAdmin 4.5 have more recent changes (August).
Questions: - as dmitry-php/sql-parser is registered on packagist, will it be updated soon ? - a "rc" release could be nice (in sync with phpMyAdmin RC) - a "stable" release could be nice (perhaps in sync with phpMyAdmin 4.5) - why not use a git sub-modules to keep change easy ?
Current master version submitted to review for Fedora [1] to be usable from phpMyAdmin, but of course, need to be updated first.
And vendor_config.php also need to be updated (patch attached)
Regards, Remi.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1262807
_______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Hello, I updated the library on packagist.org too, here [1] it is. The other one was a fork. [1] https://packagist.org/packages/udan11/sql-parser Best regards, Dan Ungureanu
Le 14/09/2015 17:07, Dan Ungureanu a écrit :
Hello,
I updated the library on packagist.org <http://packagist.org> too, here [1] it is. The other one was a fork.
Thanks, Review updates for "php-udan11-sql-parser" (rev 1b2988f, the one in 4.5.0RC1) Of course a "tagged" version (for 4.5.0) will be very welcome ;) Remi.
Best regards, Dan Ungureanu
_______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Le 14/09/2015 17:07, Dan Ungureanu a écrit :
Hello,
I updated the library on packagist.org <http://packagist.org> too, here [1] it is. The other one was a fork.
Thanks, Review updates for "php-udan11-sql-parser" (rev 1b2988f, the one in 4.5.0RC1) Of course a "tagged" version (for 4.5.0) will be very welcome ;) Remi.
Best regards, Dan Ungureanu
_______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
participants (4)
-
Dan Ungureanu -
Marc Delisle -
Remi Collet -
Remi Collet