[Phpmyadmin-devel] convcharset cookie - is it needed?
Hi, What is $GLOBALS['convcharset'] needed for? I looked at the code and can't find any place where it can be changed by users (there is a line reading from $_REQUEST['convcharset']), but it is stored in a cookie pma_convcharset. From what I found, it is read from $cfg['DefaultCharset'] and is always 'utf-8' or whatever the $cfg variable tells if to be. -- Piotr Przybylski
Hi Dne Mon, 19 Jul 2010 23:32:40 +0200 Piotr Przybylski <piotr.prz@gmail.com> napsal(a):
What is $GLOBALS['convcharset'] needed for? I looked at the code and can't find any place where it can be changed by users (there is a line reading from $_REQUEST['convcharset']), but it is stored in a cookie pma_convcharset. From what I found, it is read from $cfg['DefaultCharset'] and is always 'utf-8' or whatever the $cfg variable tells if to be.
It was used for charset conversion, which I'm not sure if is still useful and I have no idea whether it actually works. But it's probably safe to drop this code. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi Dne Tue, 20 Jul 2010 11:40:08 +0200 Michal Čihař <michal@cihar.com> napsal(a):
It was used for charset conversion, which I'm not sure if is still useful and I have no idea whether it actually works. But it's probably safe to drop this code.
Dropped in git master. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
2010/7/20 Michal Čihař <michal@cihar.com>:
Hi
Dne Tue, 20 Jul 2010 11:40:08 +0200 Michal Čihař <michal@cihar.com> napsal(a):
It was used for charset conversion, which I'm not sure if is still useful and I have no idea whether it actually works. But it's probably safe to drop this code.
Dropped in git master.
Thanks -- Piotr Przybylski
participants (2)
-
Michal Čihař -
Piotr Przybylski