Hi Ninad,
1. As mentionned earlier and now confirmed by Herman van Rink on his server: with a large number of users (60 in my case), clicking on any letter in the Privileges pages does not display the subset list of users.
2. When creating a db and immediately after, trying to create a table, I don't get the table creation dialog.
3. When dropping a database immediately after its creation, there is no jQuery dialog for confirmation; I only see a weird red confirmation message.
4. (Herman) After changing an account in the JS overlay the original page is not updated when the overlay is closed. I had duplicated an account which was not listed, only after a refresh.
5. (Herman) The yellow 'Loading' indication stays visible after the loading is complete, and in some cases a small line of yellow remains after it had faded-out.
On 21/07/2010, Marc Delisle marc@infomarc.info wrote:
Hi Ninad,
- As mentionned earlier and now confirmed by Herman van Rink on his
server: with a large number of users (60 in my case), clicking on any letter in the Privileges pages does not display the subset list of users.
If I remember correctly, Firebug was showing that the user list had been retrieved, but the list was not being inserted into the table?
- When creating a db and immediately after, trying to create a table, I
don't get the table creation dialog.
- When dropping a database immediately after its creation, there is no
jQuery dialog for confirmation; I only see a weird red confirmation message.
As I said in the other mail, I'll check it soon.
- (Herman) After changing an account in the JS overlay the original
page is not updated when the overlay is closed. I had duplicated an account which was not listed, only after a refresh.
I'll write a code similar to that of a newly created user, so that the original page will be updated.
- (Herman) The yellow 'Loading' indication stays visible after the
loading is complete, and in some cases a small line of yellow remains after it had faded-out.
As I mentioned in my weekly report, I missed out on one condition, where two (or more) 'Loading' messages were being fired off without the first one completing. This was leading to a condition where the HTML was being cleared while the effects queue was still running. I'm trying to understand jQuery's functions that clear the effects (fx) queue, will put them into the code.
Ninad Pundalik a écrit :
On 21/07/2010, Marc Delisle marc@infomarc.info wrote:
Hi Ninad,
- As mentionned earlier and now confirmed by Herman van Rink on his
server: with a large number of users (60 in my case), clicking on any letter in the Privileges pages does not display the subset list of users.
If I remember correctly, Firebug was showing that the user list had been retrieved, but the list was not being inserted into the table?
Yes. In Firebug I see in the network HTML tab that the HTML for these users is there.
On 21/07/2010, Marc Delisle marc@infomarc.info wrote:
Ninad Pundalik a écrit :
On 21/07/2010, Marc Delisle marc@infomarc.info wrote:
Hi Ninad,
- As mentionned earlier and now confirmed by Herman van Rink on his
server: with a large number of users (60 in my case), clicking on any letter in the Privileges pages does not display the subset list of users.
If I remember correctly, Firebug was showing that the user list had been retrieved, but the list was not being inserted into the table?
Yes. In Firebug I see in the network HTML tab that the HTML for these users is there.
Please comment lines no. 321 and 322 in js/server_privileges.php and tell me if there's any difference in the behaviour. I'm unable to replicate the behaviour here. :(
I just pushed some changes to the repository which should solve some of the problems that you and Herman noticed.
Ninad Pundalik a écrit :
On 21/07/2010, Marc Delisle marc@infomarc.info wrote:
Ninad Pundalik a écrit :
On 21/07/2010, Marc Delisle marc@infomarc.info wrote:
Hi Ninad,
- As mentionned earlier and now confirmed by Herman van Rink on his
server: with a large number of users (60 in my case), clicking on any letter in the Privileges pages does not display the subset list of users.
If I remember correctly, Firebug was showing that the user list had been retrieved, but the list was not being inserted into the table?
Yes. In Firebug I see in the network HTML tab that the HTML for these users is there.
Please comment lines no. 321 and 322 in js/server_privileges.php and tell me if there's any difference in the behaviour. I'm unable to replicate the behaviour here. :(
Sorry, not better. This was in js/server_privileges.js, the .end() and .remove() lines.
For me it happens only if the MySQL server is not localhost, can you try this?
I just pushed some changes to the repository which should solve some of the problems that you and Herman noticed.
Problem #2: fixed.
Problem #3: fixed.
On 22/07/2010, Marc Delisle marc@infomarc.info wrote:
Sorry, not better. This was in js/server_privileges.js, the .end() and .remove() lines.
For me it happens only if the MySQL server is not localhost, can you try this?
I should get access to another machine on Saturday/Sunday. I'll set up XAMPP on it and configure the second server in my phpMyAdmin and try to find why this is happening.
I just pushed some changes to the repository which should solve some of the problems that you and Herman noticed.
Problem #2: fixed.
Problem #3: fixed.
I'll work on Problem #4 today.
Didn't the addition of .clearQueue() to PMA_ajaxShowMessage() in js/functions.js fix problem #5? I tried all the actions which caused that problem on my system, and it was working fine.
Ninad Pundalik a écrit :
On 22/07/2010, Marc Delisle marc@infomarc.info wrote:
Sorry, not better. This was in js/server_privileges.js, the .end() and .remove() lines.
For me it happens only if the MySQL server is not localhost, can you try this?
I should get access to another machine on Saturday/Sunday. I'll set up XAMPP on it and configure the second server in my phpMyAdmin and try to find why this is happening.
I just pushed some changes to the repository which should solve some of the problems that you and Herman noticed.
Problem #2: fixed.
Problem #3: fixed.
I'll work on Problem #4 today.
Didn't the addition of .clearQueue() to PMA_ajaxShowMessage() in js/functions.js fix problem #5? I tried all the actions which caused that problem on my system, and it was working fine.
Indeed I can't reproduce problem #5 with current tree. Good job!
About inline editing: - I feel textareas take too much vertical space - How can I save my changes? - I guess you will implement a way to edit not-inline too? - If a column would show a drop-down to pick relational values, it's currently not inline-editable
On 22/07/2010, Marc Delisle marc@infomarc.info wrote:
About inline editing:
- I feel textareas take too much vertical space
I was planning to ask on this list once I had inline editing post the changes.
- How can I save my changes?
That's what I'm trying to do now. I thought I could post to either sql.php or tbl_replace.php with the proper SQL query. But, right now, I'm not getting any success as I'm missing a few parameters that tbl_replace.php needs.
- I guess you will implement a way to edit not-inline too?
I guess we could leave the edit button as it is and use jQuery to append an inline edit button/icon similar to the edit icon, so that the behaviour does not change on non-JS enabled browsers.
- If a column would show a drop-down to pick relational values, it's
currently not inline-editable
I'm still trying to get basic character/numeric fields inline-editable. Once I get these working, I'll work on the transformed, enum and relational field cases.
Problem #4 fixed. However, there are still 2 features that I have to work on in Edit Privileges : - Change Password - I'm doing this next week as per my project's schedule, so I'll do it then. - Database/Table Specific Privileges - I tried working on this about two weeks ago, but was not able to get it working. I'll attempt it again, maybe I'll have a better idea of doing it this time round.
-
Marc Delisle -
Ninad Pundalik