[Phpmyadmin-devel] FW: [phpmyadmin:bugs] #3892 SQL Export files are empty

I have prepared a fix for this issue. Shall I merge it with MAINT_4_0_0 (in order for an rc4), or is QA_4_0 (for 4.0.1) sufficient? TBH I consider this bug to be blocking. J.M. To: 3892@bugs.phpmyadmin.p.re.sf.net From: mynetx@users.sf.net Subject: [phpmyadmin:bugs] #3892 SQL Export files are empty Date: Sat, 27 Apr 2013 19:54:05 +0000 a564d981e9ef5022d69b2720d6a6126c73c74637 is the first bad commit commit a564d981e9ef5022d69b2720d6a6126c73c74637 Author: Marc Delisle marc@infomarc.info Date: Thu Apr 18 13:23:26 2013 -0400 Security: avoid $GLOBALS overwrite :100644 100644 bbc682f2cd5d66c14cfa8701573a28d02129bd74 b7a8829d80cc1cf44c9ddec8c5537508d2c18a50 M export.php [bugs:#3892] SQL Export files are empty Status: open Labels: export Created: Sat Apr 27, 2013 07:36 PM UTC by J.M. Last Updated: Sat Apr 27, 2013 07:36 PM UTC Owner: nobody When exporting a table, the generated SQL file is empty. Only the phpMyAdmin comment headers and database collaction SET commands are written. When exporting a table without writing a file, the following error is displayed: No tables found in database. Reproduced on demo.phpmyadmin.net running running Git revision RELEASE_4_0_0RC3-59-g658c79e from QA_4_0 branch. Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/phpmyadmin/bugs/3892/ To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

I have prepared a fix for this issue. Shall I merge it with MAINT_4_0_0 (in order for an rc4), or is QA_4_0 (for 4.0.1) sufficient? TBH I consider this bug to be blocking.
I have pushed my fix to my fork: https://github.com/mynetx/phpmyadmin/tree/MAINT_4_0_0 Feel free to merge and/or re-apply the patch: https://github.com/mynetx/phpmyadmin/commit/ff2d22f.patch J.M.

Le 2013-04-27 15:57, J. M. a écrit :
I have prepared a fix for this issue. Shall I merge it with MAINT_4_0_0 (in order for an rc4), or is QA_4_0 (for 4.0.1) sufficient? TBH I consider this bug to be blocking.
Yes, this should be merged to MAINT_4_0_0 for 4.0.0-rc4, I'll do it in a few minutes. By the way, the problem is not when exporting a table, it's when exporting a database; but it's a real problem. -- Marc Delisle http://infomarc.info
participants (2)
-
J. M.
-
Marc Delisle