[Phpmyadmin-devel] 3 messages -> one

Hi, I propose to replace these 3 messages: $strCoordsNotSet = 'table_coords table not found or not set in config.inc.php3'; $strInfoNotSet = 'table_info table not found or not set in config.inc.php3'; $strRelationNotSet = 'Relationtable not found or not set in config.inc.php3'; by this: $strNotSet = '%s table not found or not set in config.inc.php(3)'; plus, in pdf_pages.php3: if(!isset($relex)){die(sprintf($strNotSet,'relation'));} if(!isset($info)){die(sprintf($strNotSet,'table_info'));} if(!isset($coords)){die(sprintf($strNotSet,'table_coords'));} -- Marc Delisle

----- Original Message ----- From: "Marc Delisle" <Delislma@CollegeSherbrooke.qc.ca>
I propose to replace these 3 messages:
$strCoordsNotSet = 'table_coords table not found or not set in config.inc.php3';
$strInfoNotSet = 'table_info table not found or not set in config.inc.php3';
$strRelationNotSet = 'Relationtable not found or not set in config.inc.php3';
by this:
$strNotSet = '%s table not found or not set in config.inc.php(3)';
plus, in pdf_pages.php3:
if(!isset($relex)){die(sprintf($strNotSet,'relation'));} if(!isset($info)){die(sprintf($strNotSet,'table_info'));} if(!isset($coords)){die(sprintf($strNotSet,'table_coords'));}
What about this: $strNotSet = '%s table not found or not set in %s'; if(!isset($relex)){die(sprintf($strNotSet,'relation','config.inc.php3'));} if(!isset($info)){die(sprintf($strNotSet,'table_info','config.inc.php3'));} if(!isset($coords)){die(sprintf($strNotSet,'table_coords','config.inc.php3') );} This would keep our language files extension-independant. Alexander

Rabus wrote:
What about this:
$strNotSet = '%s table not found or not set in %s';
if(!isset($relex)){die(sprintf($strNotSet,'relation','config.inc.php3'));} if(!isset($info)){die(sprintf($strNotSet,'table_info','config.inc.php3'));} if(!isset($coords)){die(sprintf($strNotSet,'table_coords','config.inc.php3') );}
This would keep our language files extension-independant.
Ok I will merge this idea with the new code in pdf_pages (now there are 3 links to the documentation) And I will send an updated message to the translators. Marc
participants (3)
-
Marc Delisle
-
Marc Delisle
-
Rabus