[Phpmyadmin-devel] CloverPHP and PHPUnit Tests
Hi, When I run the tests on my local machine, a couple of tests fail and a few are skipped. One of the failing tests related to header location (test/libraries/core/PMA_headerLocation_test.php) does not seem to a part of CI as its not listed here [0] Also, the CloverHTML report generated seems approximately equal to the one here [1] Is that because I am running PHP_CodeCoverage 1.2.7 and the CI server is using 1.1.2? Or could it because of a few tests that are related to the OS and other configurations which differ on my machine and the live CI server? Also, if there are some tests which are not a part of CI server, are they present in an xml configuration or something? I couldn't locate it yet. [0] http://ci.phpmyadmin.net/job/phpMyAdmin/lastCompletedBuild/testReport/(root)... [1] http://ci.phpmyadmin.net/job/phpMyAdmin/cloverphp/ Thanks! -- Ayush Chaudhary
On Mon, Feb 11, 2013 at 4:14 PM, Ayush Chaudhary <ayushchd@gmail.com> wrote:
Hi,
When I run the tests on my local machine, a couple of tests fail and a few are skipped. One of the failing tests related to header location (test/libraries/core/PMA_headerLocation_test.php) does not seem to a part of CI as its not listed here [0]
Also, the CloverHTML report generated seems approximately equal to the one here [1] Is that because I am running PHP_CodeCoverage 1.2.7 and the CI server is using 1.1.2? Or could it because of a few tests that are related to the OS and other configurations which differ on my machine and the live CI server?
Also, if there are some tests which are not a part of CI server, are they present in an xml configuration or something? I couldn't locate it yet.
Hi Ayush, For some test cases they refer to some configurations configured in phpunit.xml.dist file under root directory. You may have to configure it according to your environment. Eg: url, browser, username, password etc.
[0] http://ci.phpmyadmin.net/job/phpMyAdmin/lastCompletedBuild/testReport/(root)... [1] http://ci.phpmyadmin.net/job/phpMyAdmin/cloverphp/
Thanks! -- Ayush Chaudhary
------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka
On Monday, 11 February 2013 at 7:46 PM, yasitha pandithawatta wrote:
On Mon, Feb 11, 2013 at 4:14 PM, Ayush Chaudhary <ayushchd@gmail.com (mailto:ayushchd@gmail.com)> wrote:
Hi,
When I run the tests on my local machine, a couple of tests fail and a few are skipped. One of the failing tests related to header location (test/libraries/core/PMA_headerLocation_test.php) does not seem to a part of CI as its not listed here [0]
Also, the CloverHTML report generated seems approximately equal to the one here [1] Is that because I am running PHP_CodeCoverage 1.2.7 and the CI server is using 1.1.2? Or could it because of a few tests that are related to the OS and other configurations which differ on my machine and the live CI server?
Also, if there are some tests which are not a part of CI server, are they present in an xml configuration or something? I couldn't locate it yet.
Hi Ayush,
For some test cases they refer to some configurations configured in phpunit.xml.dist file under root directory. You may have to configure it according to your environment. Eg: url, browser, username, password etc.
[0] http://ci.phpmyadmin.net/job/phpMyAdmin/lastCompletedBuild/testReport/(root)... (http://ci.phpmyadmin.net/job/phpMyAdmin/lastCompletedBuild/testReport/%28roo...) [1] http://ci.phpmyadmin.net/job/phpMyAdmin/cloverphp/
Thanks! -- Ayush Chaudhary
------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net (mailto:Phpmyadmin-devel@lists.sourceforge.net) https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-- Yasitha Pandithawatta Undergraduate Computer Science and Engineering Department University of Moratuwa Sri Lanka ------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net (mailto:Phpmyadmin-devel@lists.sourceforge.net) https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi, I have setup the configuration according to my environment. The only issue is that only a couple of tests cause failures/errors. Also, the Clover report is not "exactly" the same as I mentioned above. And most of the errors are from PMA_headerLocation_test which I cannot see on the CI server.
Hi Dne Mon, 11 Feb 2013 19:52:17 +0530 Ayush Chaudhary <ayushchd@gmail.com> napsal(a):
I have setup the configuration according to my environment. The only issue is that only a couple of tests cause failures/errors. Also, the Clover report is not "exactly" the same as I mentioned above. And most of the errors are from PMA_headerLocation_test which I cannot see on the CI server.
Can you share these errors? -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Tuesday, 12 February 2013 at 6:39 PM, Michal Čihař wrote:
Hi
Dne Mon, 11 Feb 2013 19:52:17 +0530 Ayush Chaudhary <ayushchd@gmail.com (mailto:ayushchd@gmail.com)> napsal(a):
I have setup the configuration according to my environment. The only issue is that only a couple of tests cause failures/errors. Also, the Clover report is not "exactly" the same as I mentioned above. And most of the errors are from PMA_headerLocation_test which I cannot see on the CI server.
Can you share these errors?
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net (mailto:Phpmyadmin-devel@lists.sourceforge.net) https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Here are the errors: https://gist.github.com/ayushchd/7620a376873237680412 Thanks, Ayush Chaudhary
hi Dne Wed, 13 Feb 2013 01:44:53 +0530 Ayush Chaudhary <ayushchd@gmail.com> napsal(a):
Here are the errors: https://gist.github.com/ayushchd/7620a376873237680412
You have installed runkit, what CI server does not have (I failed to compile it last time I tried). So it looks like running tests with runkit is not really tested, so that's the source of two errors. It would be great if you could look at these and fix them. The PMA_Menu_Test::testTable was broken for Windows, I've fixed this in 5230e6c. The PMA_ConfigTest::testCheckWebServerOs test was quite wrong, fixed in f9abb77. For PMA_langList_test::testLangListWithDir you need generated locales, you can do that using scripts/generate-mo (you need gettext for that). -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Hey, On Wednesday, 13 February 2013 at 1:59 PM, Michal Čihař wrote:
hi
Dne Wed, 13 Feb 2013 01:44:53 +0530 Ayush Chaudhary <ayushchd@gmail.com (mailto:ayushchd@gmail.com)> napsal(a):
Here are the errors: https://gist.github.com/ayushchd/7620a376873237680412
You have installed runkit, what CI server does not have (I failed to compile it last time I tried). So it looks like running tests with runkit is not really tested, so that's the source of two errors. It would be great if you could look at these and fix them.
The PMA_Menu_Test::testTable was broken for Windows, I've fixed this in 5230e6c.
The PMA_ConfigTest::testCheckWebServerOs test was quite wrong, fixed in f9abb77.
For PMA_langList_test::testLangListWithDir you need generated locales, you can do that using scripts/generate-mo (you need gettext for that).
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net (mailto:Phpmyadmin-devel@lists.sourceforge.net) https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
I was under the impression that these tests were failing only on my machine. As far as I remember, Jenkins showed 'tests passed' for these two tests that you fixed. For future reference, is there any other way we can see the test results? Have you merged those two commits with the main branch? I did a pull, but it gave me an Already up-to-date message. Next up, yes I had a lot of trouble compiling runkit and apd. I really thought that these were already working and there was problem with my installation/environment. I will try and look into those errors. Thanks! -- Ayush Chaudhary
Hi Dne Mon, 18 Feb 2013 21:20:09 +0530 Ayush Chaudhary <ayushchd@gmail.com> napsal(a):
I was under the impression that these tests were failing only on my machine. As far as I remember, Jenkins showed 'tests passed' for these two tests that you fixed. For future reference, is there any other way we can see the test results?
Both errors were caused by fact that you run tests on Windows, while test server uses Linux and this was not fully covered by tests.
Have you merged those two commits with the main branch? I did a pull, but it gave me an Already up-to-date message.
Yes, both are in master branch.
Next up, yes I had a lot of trouble compiling runkit and apd. I really thought that these were already working and there was problem with my installation/environment. I will try and look into those errors.
Thanks. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Hello On Tuesday, February 19, 2013, Michal Čihař wrote:
Hi
Dne Mon, 18 Feb 2013 21:20:09 +0530 Ayush Chaudhary <ayushchd@gmail.com <javascript:;>> napsal(a):
I was under the impression that these tests were failing only on my machine. As far as I remember, Jenkins showed 'tests passed' for these two tests that you fixed. For future reference, is there any other way we can see the test results?
Both errors were caused by fact that you run tests on Windows, while test server uses Linux and this was not fully covered by tests.
Have you merged those two commits with the main branch? I did a pull, but it gave me an Already up-to-date message.
Yes, both are in master branch.
Next up, yes I had a lot of trouble compiling runkit and apd. I really thought that these were already working and there was problem with my installation/environment. I will try and look into those errors.
Thanks.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
I am on Mac OS X :)
Hi Dne Tue, 19 Feb 2013 13:19:54 +0530 Ayush Chaudhary <ayushchd@gmail.com> napsal(a):
I am on Mac OS X :)
Okay, than I should have written "something else than Linux" :-). -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi Dne Mon, 18 Feb 2013 21:20:09 +0530 Ayush Chaudhary <ayushchd@gmail.com> napsal(a):
Have you merged those two commits with the main branch? I did a pull, but it gave me an Already up-to-date message. Next up, yes I had a lot of trouble compiling runkit and apd. I really thought that these were already working and there was problem with my installation/environment. I will try and look into those errors.
Thanks for the fixes. I've also managed to add runkit to our CI server, so these tests run there now as well. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (3)
-
Ayush Chaudhary -
Michal Čihař -
yasitha pandithawatta