Hi all
I just looked at bug #1023029 and thought about theme versioning. Current one is not good as it doesn't allow current phpMyAdmin to refuse future incompatible themes. So I suggest one more modification before final 2.6.0:
In addition to $theme_version add $theme_generation. $theme_generation will have to match and $theme_version needs to be higher or equal than required versions.
This will allow to enhance themes step by step while increasing $theme_version and these themes will work inside one generation.
When we will need more changes, we increase generation and this theme won't be compatible with older phpMyAdmin releses.
Comments?
Michal Čihař a écrit:
Hi all
I just looked at bug #1023029 and thought about theme versioning. Current one is not good as it doesn't allow current phpMyAdmin to refuse future incompatible themes. So I suggest one more modification before final 2.6.0:
In addition to $theme_version add $theme_generation. $theme_generation will have to match and $theme_version needs to be higher or equal than required versions.
This will allow to enhance themes step by step while increasing $theme_version and these themes will work inside one generation.
When we will need more changes, we increase generation and this theme won't be compatible with older phpMyAdmin releses.
Comments?
Michal,
maybe just one variable, $theme_version, containing the major and minor version: 1.1 major being your idea of generation.
But are we only talking about users having problems because they designed custom themes or custom versions of our 2 themes?
Or if someday we offer downloadable themes and we want those to work without the user having to upgrade?
Marc
Marc
On Tuesday 07 September 2004 18:40, Marc Delisle wrote:
maybe just one variable, $theme_version, containing the major and minor version: 1.1 major being your idea of generation.
But you will need to parse that string into separate numbers anyway for comparsion :-)
But are we only talking about users having problems because they designed custom themes or custom versions of our 2 themes?
Or if someday we offer downloadable themes and we want those to work without the user having to upgrade?
What I try to achieve is:
in near future themes will probably only expand, so current versions should work with them
some day we decite do completely rewrite themes so current version should refuse these new themes.
This is needed to allow third party themes to work without problems. I hope people will start to use theme features and will create own themes :-)
Michal C(ihar( a écrit:
On Tuesday 07 September 2004 18:40, Marc Delisle wrote:
maybe just one variable, $theme_version, containing the major and minor version: 1.1 major being your idea of generation.
But you will need to parse that string into separate numbers anyway for comparsion :-)
$theme_version = '1.2'; list($theme_major, $theme_minor) = explode('.', $theme_version);
It's just that IMO it's easier to understand this way, but do as you want :)
Marc
But are we only talking about users having problems because they designed custom themes or custom versions of our 2 themes?
Or if someday we offer downloadable themes and we want those to work without the user having to upgrade?
What I try to achieve is:
in near future themes will probably only expand, so current versions should work with them
some day we decite do completely rewrite themes so current version should refuse these new themes.
This is needed to allow third party themes to work without problems. I hope people will start to use theme features and will create own themes :-)
-
Marc Delisle -
Michal Čihař