Re: [Phpmyadmin-devel] Re: [Phpmyadmin-cvs] CVS: phpMyAdmin/libraries/dbi
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Update of /cvsroot/phpmyadmin/phpMyAdmin/libraries/dbi In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31315/libraries/dbi
Modified Files: mysqli.dbi.lib.php Log Message: - make use of MYSQLI_* constants
Sebastian, I knew about the constants but there was a problem with them, can't remember exactly for the moment. Maybe some missing values or wrong values. Did you test the use of constants here?
tested, found no problems
In HEAD: Notice: Use of undefined constant MYSQLI_BINARY_FLAG - assumed 'MYSQLI_BINARY_FLAG' in /phpMyAdmin-HEAD/libraries/dbi/mysqli.dbi.lib.php on line 465
PHP 5.1.2 MySQL 5.0.18
To reproduce: On main page, click "Show processes", then click our Refresh link.
cannot reproduce
with same as above and Windows, mysql client 5.0.18
whats your mysql client libary version? os?
MySQL client library is 4.1.12. Server OS is Linux.
Note that I still have the bug when connecting with mysqli to a MySQL 4.1.13 server.
The bug also happens when browsing any table. Does your setup display notice errors?
no errors at all MYSQLI_BINARY_FLAG is defined! seems to be a bug with older client libs -- Sebastian
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
> Update of /cvsroot/phpmyadmin/phpMyAdmin/libraries/dbi > In directory > sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31315/libraries/dbi > > Modified Files: > mysqli.dbi.lib.php Log Message: > - make use of MYSQLI_* constants
Sebastian, I knew about the constants but there was a problem with them, can't remember exactly for the moment. Maybe some missing values or wrong values. Did you test the use of constants here?
tested, found no problems
In HEAD: Notice: Use of undefined constant MYSQLI_BINARY_FLAG - assumed 'MYSQLI_BINARY_FLAG' in /phpMyAdmin-HEAD/libraries/dbi/mysqli.dbi.lib.php on line 465
PHP 5.1.2 MySQL 5.0.18
To reproduce: On main page, click "Show processes", then click our Refresh link.
cannot reproduce
with same as above and Windows, mysql client 5.0.18
whats your mysql client libary version? os?
MySQL client library is 4.1.12. Server OS is Linux.
Note that I still have the bug when connecting with mysqli to a MySQL 4.1.13 server.
The bug also happens when browsing any table. Does your setup display notice errors?
no errors at all
MYSQLI_BINARY_FLAG is defined!
seems to be a bug with older client libs
So you are saying that having a 4.1.12 client lib is too old for connecting to a MySQL 4.1.13 server? Well I don't get your point, and besides, we are going to have a lot of complaints about this. Marc
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
> Sebastian Mendel a écrit : > >> Update of /cvsroot/phpmyadmin/phpMyAdmin/libraries/dbi >> In directory >> sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31315/libraries/dbi >> >> Modified Files: >> mysqli.dbi.lib.php Log Message: >> - make use of MYSQLI_* constants > > Sebastian, > I knew about the constants but there was a problem with them, > can't remember exactly for the moment. Maybe some missing values > or wrong values. Did you test the use of constants here?
tested, found no problems
In HEAD: Notice: Use of undefined constant MYSQLI_BINARY_FLAG - assumed 'MYSQLI_BINARY_FLAG' in /phpMyAdmin-HEAD/libraries/dbi/mysqli.dbi.lib.php on line 465
PHP 5.1.2 MySQL 5.0.18
To reproduce: On main page, click "Show processes", then click our Refresh link.
cannot reproduce
with same as above and Windows, mysql client 5.0.18
whats your mysql client libary version? os?
MySQL client library is 4.1.12. Server OS is Linux.
Note that I still have the bug when connecting with mysqli to a MySQL 4.1.13 server.
The bug also happens when browsing any table. Does your setup display notice errors?
no errors at all
MYSQLI_BINARY_FLAG is defined!
seems to be a bug with older client libs
So you are saying that having a 4.1.12 client lib is too old for connecting to a MySQL 4.1.13 server? Well I don't get your point, and besides, we are going to have a lot of complaints about this.
of course we/i should address this but its a bug in the client lib, independent from server version the client lib does not export BINARY_FLAG to MYSQLI_BINARY_FLAG -- Sebastian
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
Marc Delisle schrieb:
Sebastian Mendel a écrit :
> Marc Delisle schrieb: > >> Sebastian Mendel a écrit : >> >>> Update of /cvsroot/phpmyadmin/phpMyAdmin/libraries/dbi >>> In directory >>> sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv31315/libraries/dbi >>> >>> Modified Files: >>> mysqli.dbi.lib.php Log Message: >>> - make use of MYSQLI_* constants >> >> >> Sebastian, >> I knew about the constants but there was a problem with them, >> can't remember exactly for the moment. Maybe some missing values >> or wrong values. Did you test the use of constants here? > > > tested, found no problems
In HEAD: Notice: Use of undefined constant MYSQLI_BINARY_FLAG - assumed 'MYSQLI_BINARY_FLAG' in /phpMyAdmin-HEAD/libraries/dbi/mysqli.dbi.lib.php on line 465
PHP 5.1.2 MySQL 5.0.18
To reproduce: On main page, click "Show processes", then click our Refresh link.
cannot reproduce
with same as above and Windows, mysql client 5.0.18
whats your mysql client libary version? os?
MySQL client library is 4.1.12. Server OS is Linux.
Note that I still have the bug when connecting with mysqli to a MySQL 4.1.13 server.
The bug also happens when browsing any table. Does your setup display notice errors?
no errors at all
MYSQLI_BINARY_FLAG is defined!
seems to be a bug with older client libs
So you are saying that having a 4.1.12 client lib is too old for connecting to a MySQL 4.1.13 server? Well I don't get your point, and besides, we are going to have a lot of complaints about this.
of course we/i should address this but its a bug in the client lib, independent from server version the client lib does not export BINARY_FLAG to MYSQLI_BINARY_FLAG
This flag is not even listed on http://ca3.php.net/mysqli Anyway I suggest to do this: if (!defined('MYSQLI_BINARY_FLAG')) { define('MYSQLI_BINARY_FLAG', 128); }
Marc Delisle wrote:
> In HEAD: > Notice: Use of undefined constant MYSQLI_BINARY_FLAG - assumed > 'MYSQLI_BINARY_FLAG' in > /phpMyAdmin-HEAD/libraries/dbi/mysqli.dbi.lib.php on line 465 > > PHP 5.1.2 > MySQL 5.0.18 > > To reproduce: > On main page, click "Show processes", then click our Refresh link.
cannot reproduce
with same as above and Windows, mysql client 5.0.18
whats your mysql client libary version? os?
MySQL client library is 4.1.12. Server OS is Linux.
Note that I still have the bug when connecting with mysqli to a MySQL 4.1.13 server.
The bug also happens when browsing any table. Does your setup display notice errors?
no errors at all
MYSQLI_BINARY_FLAG is defined!
seems to be a bug with older client libs
So you are saying that having a 4.1.12 client lib is too old for connecting to a MySQL 4.1.13 server? Well I don't get your point, and besides, we are going to have a lot of complaints about this.
of course we/i should address this but its a bug in the client lib, independent from server version the client lib does not export BINARY_FLAG to MYSQLI_BINARY_FLAG
This flag is not even listed on http://ca3.php.net/mysqli
Anyway I suggest to do this:
if (!defined('MYSQLI_BINARY_FLAG')) { define('MYSQLI_BINARY_FLAG', 128); }
yes, i thought about the same ;-) btw. possible we should/could add a message on main.php if mysql client lib and MySQL server version differs (knowing that this is not the source of this problem as even with server version same as client lib version the error would occur if the client is below <5.0 or something) "Your mysql client lib version (x.xx.xx) differs from your server version (x.xx.xx), MySQL AB advises to use same versions, as there are several errors that can happen." or something similar ... read on: http://dev.mysql.com/downloads/connector/php/ As the the above link holds only connectors for Windows the statements are true for all os. -- Sebastian Mendel www.sebastianmendel.de www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet
Hi On Mon, 20 Feb 2006 08:18:48 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:
btw. possible we should/could add a message on main.php if mysql client lib and MySQL server version differs (knowing that this is not the source of this problem as even with server version same as client lib version the error would occur if the client is below <5.0 or something)
"Your mysql client lib version (x.xx.xx) differs from your server version (x.xx.xx), MySQL AB advises to use same versions, as there are several errors that can happen."
or something similar ...
Yes it can be added, but with possibility to disable such warning as in some cases there is no other option than having different versions. -- Michal Čihař | http://cihar.com
Michal Čihař a écrit :
Hi
On Mon, 20 Feb 2006 08:18:48 +0100 Sebastian Mendel <lists@sebastianmendel.de> wrote:
btw. possible we should/could add a message on main.php if mysql client lib and MySQL server version differs (knowing that this is not the source of this problem as even with server version same as client lib version the error would occur if the client is below <5.0 or something)
"Your mysql client lib version (x.xx.xx) differs from your server version (x.xx.xx), MySQL AB advises to use same versions, as there are several errors that can happen."
or something similar ...
Yes it can be added, but with possibility to disable such warning as in some cases there is no other option than having different versions.
I just got an idea. We display several warnings about environment issues that can affect PMA. We could centralise those on a page, callable from main page, for example "Advise about environment" or something similar. This way we would avoid new config variables to disable those. If we go this way, we would have to decide about which warnings are very important, for example the one about root and no password. Those should be issued on the main page. Marc
Hi Marc On Mon, 20 Feb 2006 07:41:31 -0500 Marc Delisle <Marc.Delisle@cegepsherbrooke.qc.ca> wrote:
I just got an idea. We display several warnings about environment issues that can affect PMA. We could centralise those on a page, callable from main page, for example "Advise about environment" or something similar. This way we would avoid new config variables to disable those.
Good idea.
If we go this way, we would have to decide about which warnings are very important, for example the one about root and no password. Those should be issued on the main page.
I'd do it another way: If there is something wrong, show warning box with link to details page. Showing of this warning could be disabled, but page could be still accessed manually (users are usually only scared about those messages). -- Michal Čihař | http://cihar.com
Michal Čihař a écrit :
Hi Marc
On Mon, 20 Feb 2006 07:41:31 -0500 Marc Delisle <Marc.Delisle@cegepsherbrooke.qc.ca> wrote:
I just got an idea. We display several warnings about environment issues that can affect PMA. We could centralise those on a page, callable from main page, for example "Advise about environment" or something similar. This way we would avoid new config variables to disable those.
Good idea.
If we go this way, we would have to decide about which warnings are very important, for example the one about root and no password. Those should be issued on the main page.
I'd do it another way: If there is something wrong, show warning box with link to details page. Showing of this warning could be disabled, but page could be still accessed manually (users are usually only scared about those messages).
Ok for me. Marc
participants (3)
-
Marc Delisle -
Michal Čihař -
Sebastian Mendel