Hi all
I've just merged Developer Certificate of Origin written for us by Conservancy:
https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO
Please read these and confirm your certification to the above by adding the Signed-off-by line to your commits (git commit -s does that).
I've also written a small script, which will check every pull request to contain Signed-off-by lines, so that pull requests without these will get build failure from Travis.
The reason for this is that we need to transition towards GPLv2-or-later to be license compatible with some libraries we include and this way we can identify code which is already agreed to be GPLv2-or-later.
Hi
Dne Wed, 4 Dec 2013 09:11:34 +0100 Michal Čihař michal@cihar.com napsal(a):
I've also written a small script, which will check every pull request to contain Signed-off-by lines, so that pull requests without these will get build failure from Travis.
...but that does not work now due to https://github.com/travis-ci/travis-ci/issues/1719
Hi
Dne Wed, 4 Dec 2013 11:03:25 +0100 Michal Čihař michal@cihar.com napsal(a):
Dne Wed, 4 Dec 2013 09:11:34 +0100 Michal Čihař michal@cihar.com napsal(a):
I've also written a small script, which will check every pull request to contain Signed-off-by lines, so that pull requests without these will get build failure from Travis.
...but that does not work now due to https://github.com/travis-ci/travis-ci/issues/1719
I've found other way around to do this, so if Travis says the build is okay, it means that there are SOB lines as well. You can find which commits are missing it in the build log. You can see example here:
https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/14914736#L1041
Le 2013-12-04 03:11, Michal Čihař a écrit :
Hi all
I've just merged Developer Certificate of Origin written for us by Conservancy:
https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO
Please read these and confirm your certification to the above by adding the Signed-off-by line to your commits (git commit -s does that).
Michal, this does not apply to commits for translations done via Weblate, right?
Hi Marc
Dne Wed, 04 Dec 2013 06:02:19 -0500 Marc Delisle marc@infomarc.info napsal(a):
this does not apply to commits for translations done via Weblate, right?
I'm not really sure how to best handle it, so for now it does not add Signed-off-by right now.
-
Marc Delisle -
Michal Čihař