[Phpmyadmin-devel] pmahomme and column width in browse mode

Hi, as tested with sakila.actor, the actor_id (SMALLINT) column is very wide. -- Marc Delisle http://infomarc.info

On Wed, Mar 2, 2011 at 4:20 PM, Marc Delisle <marc@infomarc.info> wrote:
Hi, as tested with sakila.actor, the actor_id (SMALLINT) column is very wide.
-- Marc Delisle http://infomarc.info
.data{width:100%} in theme_right.css.php of theme pmahomme seems to be the culprit !! Above it here is this comment */* Set all tables with data... to 100%, let it flow! */* **So it seems like this behavior has been set explicitly. * * * *-- Thanks and Regards, Madhura Jayaratne

Madhura Jayaratne a écrit :
On Wed, Mar 2, 2011 at 4:20 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote:
Hi, as tested with sakila.actor, the actor_id (SMALLINT) column is very wide.
.data{width:100%} in theme_right.css.php of theme pmahomme seems to be the culprit !!
Above it here is this comment */* Set all tables with data... to 100%, let it flow! */*
**So it seems like this behavior has been set explicitly.
Confirmed. Can Mike Hommé comment on this? -- Marc Delisle http://infomarc.info

Hi all, I took a look at this, and it seems like removing the 100% width on the .data selector is the way to go. I'm also planning to commit the following changes asap (by end of weekend): 1. Reduce amount of padding on table rows (to show more data on screen) 2. Use small PMA logo in top left navigation 3. Fix "inline edit" button 4. Possibly reduce header and some margins, 5. Possibly make warnings and success message to be less intensive Thanks, Mike -----Original Message----- From: Marc Delisle [mailto:marc@infomarc.info] Sent: Thursday, March 03, 2011 12:34 PM To: phpmyadmin-devel@lists.sourceforge.net Subject: Re: [Phpmyadmin-devel] pmahomme and column width in browse mode Madhura Jayaratne a écrit :
On Wed, Mar 2, 2011 at 4:20 PM, Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote:
Hi, as tested with sakila.actor, the actor_id (SMALLINT) column is very wide.
.data{width:100%} in theme_right.css.php of theme pmahomme seems to be the culprit !!
Above it here is this comment */* Set all tables with data... to 100%, let it flow! */*
**So it seems like this behavior has been set explicitly.
Confirmed. Can Mike Hommé comment on this? -- Marc Delisle http://infomarc.info ---------------------------------------------------------------------------- -- Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

2011/3/4 Mike Homme <mike@globalcode.org>:
Hi all,
I took a look at this, and it seems like removing the 100% width on the .data selector is the way to go.
I'm also planning to commit the following changes asap (by end of weekend):
1. Reduce amount of padding on table rows (to show more data on screen) 2. Use small PMA logo in top left navigation 3. Fix "inline edit" button 4. Possibly reduce header and some margins, 5. Possibly make warnings and success message to be less intensive
Great :) One more thing - table trees (and possibly database trees) look odd [1], it should get a bullet/icon/bold font, whatever will look good. While we are at it, maybe some <span> around it would make styling easier? [1] http://img683.imageshack.us/img683/3438/navjb.png -- Piotr Przybylski

2011/3/4 Piotr Przybylski <piotr.prz@gmail.com>:
2011/3/4 Mike Homme <mike@globalcode.org>:
Hi all,
I took a look at this, and it seems like removing the 100% width on the .data selector is the way to go.
I'm also planning to commit the following changes asap (by end of weekend):
1. Reduce amount of padding on table rows (to show more data on screen) 2. Use small PMA logo in top left navigation 3. Fix "inline edit" button 4. Possibly reduce header and some margins, 5. Possibly make warnings and success message to be less intensive
Great :)
One more thing - table trees (and possibly database trees) look odd [1], it should get a bullet/icon/bold font, whatever will look good. While we are at it, maybe some <span> around it would make styling easier?
[1] http://img683.imageshack.us/img683/3438/navjb.png
-- Piotr Przybylski
I forgot about one thing: text <input>s have a 6px margin, while <select>s do not, it should be made consistent (look at login page in cookie auth or user preferences forms), and maybe reduced a bit. -- Piotr Przybylski
participants (4)
-
Madhura Jayaratne
-
Marc Delisle
-
Mike Homme
-
Piotr Przybylski