[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Structure ->Mutiple columns->Change
Hi Marc,
Even though my "AJAXify Table->Browse ->Mutiple rows-> Export" option is not yet finished, since my this weeks task is "*Ajaxify Table->Structure ->Mutiple rows->Change*", I worked with it and now it seems working correctly.
1. In this I tried to reuse the "*if($("input[type='hidden'][name='table_type']").val() == "table")" *code segment and placed it in "*displayMoreTableOpts()*" function in functions.js. 2. I used the table structure.js for handling the change event.
I have pushed the code to the repo. Please check that. Thank you.
Regards, Thilanka.
Le 2011-06-25 07:39, Thilanka Kaushalya a écrit :
Hi Marc,
Even though my "AJAXify Table->Browse ->Mutiple rows-> Export" option is not yet finished, since my this weeks task is "*Ajaxify Table->Structure ->Mutiple rows->Change*", I worked with it and now it seems working correctly.
- In this I tried to reuse the "*if($("input[type='hidden'][name='table_type']").val() == "table")" *code segment and placed it in "*displayMoreTableOpts()*" function in functions.js.
- I used the table structure.js for handling the change event.
I have pushed the code to the repo. Please check that. Thank you.
Thilanka, the success case works well. In case of error (for example, renaming a column with an existing column name), tbl_alter.php does not return JSON and the user is not notified of the problem.
Hi Marc,
the success case works well. In case of error (for example, renaming a
column with an existing column name), tbl_alter.php does not return JSON and the user is not notified of the problem.
I fixed that bug. Please check that. Thank you.
Regards, Thilanka.
Le 2011-06-25 12:04, Thilanka Kaushalya a écrit :
Hi Marc,
the success case works well. In case of error (for example, renaming a column with an existing column name), tbl_alter.php does not return JSON and the user is not notified of the problem.I fixed that bug. Please check that. Thank you.
Regards, Thilanka.
Thilanka, I now receive the error message but too late as I'm no longer in my table altering dialog. Many kinds of errors could happen here, not just the one I pointed. As another example, changing the type from INT to VARCHAR and omitting the length.
To compare, try another dialog: in the Create table, try to create some table with the same name as an existing table. In this case, the dialog receives the error message and I'm able to correct my mistake.
Hi Marc,
I now receive the error message but too late as I'm no longer in my
table altering dialog. Many kinds of errors could happen here, not just the one I pointed. As another example, changing the type from INT to VARCHAR and omitting the length.
To compare, try another dialog: in the Create table, try to create some table with the same name as an existing table. In this case, the dialog receives the error message and I'm able to correct my mistake.
I replaced the logic of error shown to show the (".error code") in a ajax message which allows user to find what is the error and resubmit the form. Is it okay or should I use another error message to show. Please check that. Thank you.
Regards, Thilanka.
Le 2011-06-26 14:01, Thilanka Kaushalya a écrit :
Hi Marc,
I now receive the error message but too late as I'm no longer in my table altering dialog. Many kinds of errors could happen here, not just the one I pointed. As another example, changing the type from INT to VARCHAR and omitting the length. To compare, try another dialog: in the Create table, try to create some table with the same name as an existing table. In this case, the dialog receives the error message and I'm able to correct my mistake.I replaced the logic of error shown to show the (".error code") in a ajax message which allows user to find what is the error and resubmit the form. Is it okay or should I use another error message to show. Please check that. Thank you.
Thilanka, it works fine; are you happy with this feature?
If it's ready, I could try to merge the 3 commits that contain this feature, hoping not to merge the code from the unfinished "AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Browse ->Mutiple rows-> Export".
Hi Marc,
it works fine; are you happy with this feature?
Yes. I'm okay with that.
If it's ready, I could try to merge the 3 commits that contain this feature, hoping not to merge the code from the unfinished "AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Browse ->Mutiple rows-> Export".
Yes it is better if you can merge that. I'll try to finish the export as soon as possible. :). Thank you very much for testing and directing me to the correct path.
Regards, Thilanka.
Le 2011-06-26 21:07, Thilanka Kaushalya a écrit :
Hi Marc,
it works fine; are you happy with this feature?Yes. I'm okay with that.
If it's ready, I could try to merge the 3 commits that contain this feature, hoping not to merge the code from the unfinished "AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Browse ->Mutiple rows-> Export".Yes it is better if you can merge that. I'll try to finish the export as soon as possible. :). Thank you very much for testing and directing me to the correct path.
Regards, Thilanka.
Merged. Please have a look at my commit 1970c357a30c44c410578bd4513dfb77125d6126.
-
Marc Delisle -
Thilanka Kaushalya