Hey Michal, I see that phpmyadmin has no translation file in urdu. Having proper support can be quite helpful and will promote the product in countries like Pakistan and India a lot. Should I take the responsibility of developing the .po file for urdu? On Thu, May 9, 2013 at 12:46 PM, Michal Čihař <michal(a)cihar.com> wrote:

Hey Michal, I have successfully developed my first patch for the PMA. But unfortunately I am unable to push the commit to github owing to some proxy issue. Can I send you the updated code in zip and then you can take a look at the patch. I know I am causing trouble but I have no other way right now :( On Thu, May 9, 2013 at 12:56 PM, Michal Čihař <michal(a)cihar.com> wrote:

Ya I am aware of that. I am going to sort out this problem now. Thanks a lot for your guidance :) On Thu, May 9, 2013 at 7:21 PM, Marc Delisle <marc(a)infomarc.info> wrote:

Michal, I have forked the phpmyadmin repo and am going to update changes there. How do I make sure that you people can see that I have contributed? A little help here on git will definitely be great and will give me a jump start. On Fri, May 10, 2013 at 11:22 AM, Michal Čihař <michal(a)cihar.com> wrote:

I have made a commit. Kindly check it out On Fri, May 10, 2013 at 12:03 PM, xmujay(a)gmail.com <xmujay(a)gmail.com> wrote:

Dieter Adriaenssens a écrit : Yes, that's what I concluded too. -- Marc Delisle http://infomarc.info

Hi, Although I changed the "require" to "require _once" on libraries/common.inc.php other redefine error still existed: https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/7223416 so I think to test the files which requires "libraries/common.inc.php", the problem will exist. Any advice? thanks Adam >Hi all, > >I make pull request about adding Unit test case for libraries/ServerStatusData.class.php >https://github.com/phpmyadmin/phpmyadmin/pull/394 > >but a build error if I don't change the "require" to "require _once" on libraries/common.inc.php >https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/7221724 > >it is: >Fatal error: Cannot redeclare class PMA_Error_Handler in /home/travis/build/phpmyadmin/phpmyadmin/libraries/Error_Handler.class.php on line 20 > > >I want to know that Any special reason that "require" but not "require _once" on libraries/common.inc.php > > >thanks, >Adam >------------------------------------------------------------------------------ >AlienVault Unified Security Management (USM) platform delivers complete >security visibility with the essential security capabilities. Easily and >efficiently configure, manage, and operate all of your security controls >from a single console and one unified framework. Download a free trial. >http://p.sf.net/sfu/alienvault_d2d >_______________________________________________ >Phpmyadmin-devel mailing list >Phpmyadmin-devel(a)lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel

Hi Dieter, I agree with you about that. But I don't know why the file libraries/common.inc.php use "require" but not "require _once". this file will be used frequently, so use "require _once" is better. I was thinking that there must be some special reason. thanks for your information. Adam

HI, Thanks Michal. I agree with you that using "require" is for performance. and it is working for most cases. On our page (server_status.php), It is working well, so it is not a problem here. require_once 'libraries/common.inc.php'; require_once 'libraries/server_common.inc.php'; require_once 'libraries/ServerStatusData.class.php'; but you also mentioned that "However with testsuite this gets more complicated...". I think there must be somewhere include the file: 'libraries/common.inc.php' so the testing of pages which include 'libraries/common.inc.php'; will fail due to require_once issue. I will dig into this issue deeper. thanks Adam

Hi Michal, Is there some tips that we can overcome the "Redefine error" in order to add test case for some classes requires libraries/common.inc.php https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/7223416 https://github.com/phpmyadmin/phpmyadmin/pull/394 I think I should have more investigations into it. Adam