[Phpmyadmin-devel] git and $Id$ expansion
Hi, with our switching to git that will happen just after the 3.3.0 release, I guess we should remove this line from all files: * @version $Id$ -- Marc Delisle http://infomarc.info
Hi Dne Sat, 06 Mar 2010 12:15:10 -0500 Marc Delisle <marc@infomarc.info> napsal(a):
with our switching to git that will happen just after the 3.3.0 release, I guess we should remove this line from all files:
* @version $Id$
Yes, removing them seems to be best idea. Also there are several places where we something like @version 1.0, which are IMO also good candidates for removal :-). -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On Sat, Mar 06, 2010 at 12:15:10PM -0500, Marc Delisle wrote:
Hi, with our switching to git that will happen just after the 3.3.0 release, I guess we should remove this line from all files: Git does support $Id$ expansion on export, and I'd suggest we do enable it, so that we know if a user has a partial set of files where they came from.
It does not support any other CVS keywords however, so those we can remove. -- Robin Hugh Johnson Gentoo Linux: Developer, Trustee & Infrastructure Lead E-Mail : robbat2@gentoo.org GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
Robin H. Johnson a écrit :
On Sat, Mar 06, 2010 at 12:15:10PM -0500, Marc Delisle wrote:
Hi, with our switching to git that will happen just after the 3.3.0 release, I guess we should remove this line from all files: Git does support $Id$ expansion on export, and I'd suggest we do enable it, so that we know if a user has a partial set of files where they came from.
It does not support any other CVS keywords however, so those we can remove.
Robin, on my machine when I do "git --help" I don't see an "export" command. -- Marc Delisle http://infomarc.info
Hi Dne Tue, 9 Mar 2010 04:03:55 +0000 "Robin H. Johnson" <robbat2@users.sourceforge.net> napsal(a):
On Sat, Mar 06, 2010 at 12:15:10PM -0500, Marc Delisle wrote:
Hi, with our switching to git that will happen just after the 3.3.0 release, I guess we should remove this line from all files: Git does support $Id$ expansion on export, and I'd suggest we do enable it, so that we know if a user has a partial set of files where they came from.
Well I'd prefer to drop keywords completely because I really did not find them helpful.
It does not support any other CVS keywords however, so those we can remove.
You can implement anything using filters and/or use git archive $Format feature. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi Dne Tue, 9 Mar 2010 12:04:43 +0100 Michal Čihař <michal@cihar.com> napsal(a):
Well I'd prefer to drop keywords completely because I really did not find them helpful.
It does not support any other CVS keywords however, so those we can remove.
You can implement anything using filters and/or use git archive $Format feature.
Any other comments on $Id$ expansion? -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Hi
Dne Tue, 9 Mar 2010 12:04:43 +0100 Michal Čihař <michal@cihar.com> napsal(a):
Well I'd prefer to drop keywords completely because I really did not find them helpful.
It does not support any other CVS keywords however, so those we can remove. You can implement anything using filters and/or use git archive $Format feature.
Any other comments on $Id$ expansion?
Do you plan to remove the lines yourself? -- Marc Delisle http://infomarc.info
Hi Dne Tue, 30 Mar 2010 10:36:21 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Do you plan to remove the lines yourself?
Not right now, I just wanted to know other opinions. I personally don't see anything good on changing files on checkout just add some sort of id into it (it's clear case of mixing metadata and data). -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (3)
-
Marc Delisle -
Michal Čihař -
Robin H. Johnson