Hi,
I've just pushed my commits for show/hide column feature. If you have some time, please give it a try at [0] and let me know if you have any comment or suggestion.
When you are testing, please note that the feature still lack of some things: - column visibility list drop-down arrows are shown in "too many" places when display mode = vertical AND repeatCells = small number - the hide (small X) button is sometimes annoying, especially when we want to sort a small column (e.g., usually ID). I've tried to resize all columns using jQuery to properly display the "hide" button next to the column label. But, unfortunately, it is quite slow. Any other suggestion? Should we remove the "hide" button?
[0] http://demo.phpmyadmin.net/gsoc-aris
Regards, -- Aris Feryanto
On Fri, Jun 24, 2011 at 7:04 PM, Aris Feryanto aris_feryanto@yahoo.com wrote:
Hi,
I've just pushed my commits for show/hide column feature. If you have some time, please give it a try at [0] and let me know if you have any comment or suggestion.
When you are testing, please note that the feature still lack of some things: - column visibility list drop-down arrows are shown in "too many" places when display mode = vertical AND repeatCells = small number
- the hide (small X) button is sometimes annoying, especially when we want to sort a small column (e.g., usually ID). I've tried to resize all columns using jQuery to properly display the "hide" button next to the column label. But, unfortunately, it is quite slow. Any other suggestion? Should we remove the "hide" button?
Looks good, but how about you put "CTRL + Click to hide" into the tooltip and remove the X button therefore? Otherwise theres many features within a really small space, that way its getting difficult to select the right one.
Also I think it would be enough to add one button that resets column order and show/hide state, instead of 2 separate ones.
Regards,
-- Aris Feryanto
All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-06-24 14:53, Tyron Madlener a écrit :
On Fri, Jun 24, 2011 at 7:04 PM, Aris Feryantoaris_feryanto@yahoo.com wrote:
Hi,
I've just pushed my commits for show/hide column feature. If you have some time, please give it a try at [0] and let me know if you have any comment or suggestion.
When you are testing, please note that the feature still lack of some things: - column visibility list drop-down arrows are shown in "too many" places when display mode = vertical AND repeatCells = small number - the hide (small X) button is sometimes annoying, especially when we want to sort a small column (e.g., usually ID). I've tried to resize all columns using jQuery to properly display the "hide" button next to the column label. But, unfortunately, it is quite slow. Any other suggestion? Should we remove the "hide" button?
Looks good, but how about you put "CTRL + Click to hide" into the tooltip and remove the X button therefore? Otherwise theres many features within a really small space, that way its getting difficult to select the right one.
Aris, I am in favor of removing the X button. On the positive side, it's a quick way to hide a column but after it's hidden, the user wonders how to put it back. If you give to the user the idea that some action directly in the column can hide it, his mind is set in the wrong track about how to restore the column.
Also I think it would be enough to add one button that resets column order and show/hide state, instead of 2 separate ones.
I'm not sure about this; the ideas are different.
About the arrow selector in the big T cell, how about some hint showed to the user?
In this selector, there could be also a "(all)" checkbox on top, which is something standard to see on top of a series of checkboxes; if you go this way, the button in navigation might not be needed.
On 25 Jun 2011, at 19:21, Marc Delisle marc@infomarc.info wrote:
Le 2011-06-24 14:53, Tyron Madlener a écrit :
On Fri, Jun 24, 2011 at 7:04 PM, Aris Feryantoaris_feryanto@yahoo.com wrote:
Hi,
I've just pushed my commits for show/hide column feature. If you have some time, please give it a try at [0] and let me know if you have any comment or suggestion.
When you are testing, please note that the feature still lack of some things: - column visibility list drop-down arrows are shown in "too many" places when display mode = vertical AND repeatCells = small number - the hide (small X) button is sometimes annoying, especially when we want to sort a small column (e.g., usually ID). I've tried to resize all columns using jQuery to properly display the "hide" button next to the column label. But, unfortunately, it is quite slow. Any other suggestion? Should we remove the "hide" button?
Looks good, but how about you put "CTRL + Click to hide" into the tooltip and remove the X button therefore? Otherwise theres many features within a really small space, that way its getting difficult to select the right one.
Aris, I am in favor of removing the X button. On the positive side, it's a quick way to hide a column but after it's hidden, the user wonders how to put it back. If you give to the user the idea that some action directly in the column can hide it, his mind is set in the wrong track about how to restore the column.
Hmm. Yes, you are right. I'm confinced that it is better to remove the X button. I asked my friend to try and she didn't get the way to restore the column visibility easily.
I think I would try to remove X button and emphasize the drop-down arrow by adding a hint as you suggested below, Marc.
Also I think it would be enough to add one button that resets column order and show/hide state, instead of 2 separate ones.
I'm not sure about this; the ideas are different.
About the arrow selector in the big T cell, how about some hint showed to the user?
In this selector, there could be also a "(all)" checkbox on top, which is something standard to see on top of a series of checkboxes; if you go this way, the button in navigation might not be needed.
I think "show all" button in the top and bottom of the list would work. If we use (all) checkbox, it would give the user an idea that we can hide all columns, which is pointless when we are browsing a table.
-- Aris Feryanto
Le 2011-06-25 08:37, Aris Feryanto a écrit :
On 25 Jun 2011, at 19:21, Marc Delislemarc@infomarc.info wrote:
Le 2011-06-24 14:53, Tyron Madlener a écrit :
On Fri, Jun 24, 2011 at 7:04 PM, Aris Feryantoaris_feryanto@yahoo.com wrote:
Hi,
I've just pushed my commits for show/hide column feature. If you have some time, please give it a try at [0] and let me know if you have any comment or suggestion.
When you are testing, please note that the feature still lack of some things: - column visibility list drop-down arrows are shown in "too many" places when display mode = vertical AND repeatCells = small number - the hide (small X) button is sometimes annoying, especially when we want to sort a small column (e.g., usually ID). I've tried to resize all columns using jQuery to properly display the "hide" button next to the column label. But, unfortunately, it is quite slow. Any other suggestion? Should we remove the "hide" button?
Looks good, but how about you put "CTRL + Click to hide" into the tooltip and remove the X button therefore? Otherwise theres many features within a really small space, that way its getting difficult to select the right one.
Aris, I am in favor of removing the X button. On the positive side, it's a quick way to hide a column but after it's hidden, the user wonders how to put it back. If you give to the user the idea that some action directly in the column can hide it, his mind is set in the wrong track about how to restore the column.
Hmm. Yes, you are right. I'm confinced that it is better to remove the X button. I asked my friend to try and she didn't get the way to restore the column visibility easily.
Usability testing is very important, good idea to ask a friend.
I think I would try to remove X button and emphasize the drop-down arrow by adding a hint as you suggested below, Marc.
Also I think it would be enough to add one button that resets column order and show/hide state, instead of 2 separate ones.
I'm not sure about this; the ideas are different.
About the arrow selector in the big T cell, how about some hint showed to the user?
In this selector, there could be also a "(all)" checkbox on top, which is something standard to see on top of a series of checkboxes; if you go this way, the button in navigation might not be needed.
I think "show all" button in the top and bottom of the list would work. If we use (all) checkbox, it would give the user an idea that we can hide all columns, which is pointless when we are browsing a table.
Good point.
----- Original Message -----
From: Aris Feryanto aris_feryanto@yahoo.com
On 25 Jun 2011, at 19:21, Marc Delisle marc@infomarc.info wrote:
Le 2011-06-24 14:53, Tyron Madlener a écrit :
On Fri, Jun 24, 2011 at 7:04 PM, Aris Feryantoaris_feryanto@yahoo.com wrote:
Hi,
I've just pushed my commits for show/hide column feature. If
you
have some time, please give it a try at [0] and let me know if you have any comment or suggestion.
When you are testing, please note that the feature still lack of some things: - column visibility list drop-down arrows are shown in "too many" places when display mode = vertical AND
repeatCells =
small number - the hide (small X) button is sometimes annoying, especially when we want to sort a small column (e.g., usually ID). I've tried to resize all columns using jQuery to properly
display
the "hide" button next to the column label. But,
unfortunately, it
is quite slow. Any other suggestion? Should we remove the
"hide"
button?
Looks good, but how about you put "CTRL + Click to hide" into
the
tooltip and remove the X button therefore? Otherwise theres many features within a really small space, that way its getting difficult to select the right one.
Aris, I am in favor of removing the X button. On the positive side, it's a quick way to hide a column but after it's hidden, the user wonders how to put it back. If you give to the user the idea that some action directly in the column can hide it, his mind is set in the wrong track about how to restore the column.
Hmm. Yes, you are right. I'm confinced that it is better to remove the X button. I asked my friend to try and she didn't get the way to restore the column visibility easily.
I think I would try to remove X button and emphasize the drop-down arrow by adding a hint as you suggested below, Marc.
Done in my git. The demo has been updated and you may try it at the usual location [0].
Also I think it would be enough to add one button that resets column order and show/hide state, instead of 2 separate ones.
I'm not sure about this; the ideas are different.
About the arrow selector in the big T cell, how about some hint showed to the user?
In this selector, there could be also a "(all)" checkbox on top,
which
is something standard to see on top of a series of checkboxes; if you go this way, the button in navigation might not be needed.
I think "show all" button in the top and bottom of the list would work. If we use (all) checkbox, it would give the user an idea that we can hide all columns, which is pointless when we are browsing a table.
Done in my git. The "show all" button will only appear in the top and bottom of the list if the list is too long (> 10). Otherwise, it will appear only at the bottom of the list.
I also fixed the "too many" <th> while browsing in vertical mode in my last commit (ba4515212a24c1d81a7251e85a82d7c8649b7604). But not sure if changes in my commit are the best way to fix it.
[0] http://demo.phpmyadmin.net/gsoc-aris
-- Aris Feryanto
Le 2011-06-27 00:25, Aris Feryanto a écrit :
----- Original Message -----
From: Aris Feryantoaris_feryanto@yahoo.com
On 25 Jun 2011, at 19:21, Marc Delislemarc@infomarc.info wrote:
Le 2011-06-24 14:53, Tyron Madlener a écrit :
On Fri, Jun 24, 2011 at 7:04 PM, Aris Feryantoaris_feryanto@yahoo.com wrote:
Hi,
I've just pushed my commits for show/hide column feature. If
you
have some time, please give it a try at [0] and let me know if you have any comment or suggestion.
When you are testing, please note that the feature still lack of some things: - column visibility list drop-down arrows are shown in "too many" places when display mode = vertical AND
repeatCells =
small number - the hide (small X) button is sometimes annoying, especially when we want to sort a small column (e.g., usually ID). I've tried to resize all columns using jQuery to properly
display
the "hide" button next to the column label. But,
unfortunately, it
is quite slow. Any other suggestion? Should we remove the
"hide"
button?
Looks good, but how about you put "CTRL + Click to hide" into
the
tooltip and remove the X button therefore? Otherwise theres many features within a really small space, that way its getting difficult to select the right one.
Aris, I am in favor of removing the X button. On the positive side, it's a quick way to hide a column but after it's hidden, the user wonders how to put it back. If you give to the user the idea that some action directly in the column can hide it, his mind is set in the wrong track about how to restore the column.
Hmm. Yes, you are right. I'm confinced that it is better to remove the X button. I asked my friend to try and she didn't get the way to restore the column visibility easily.
I think I would try to remove X button and emphasize the drop-down arrow by adding a hint as you suggested below, Marc.
Done in my git. The demo has been updated and you may try it at the usual location [0].
Also I think it would be enough to add one button that resets column order and show/hide state, instead of 2 separate ones.
I'm not sure about this; the ideas are different.
About the arrow selector in the big T cell, how about some hint showed to the user?
In this selector, there could be also a "(all)" checkbox on top,
which
is something standard to see on top of a series of checkboxes; if you go this way, the button in navigation might not be needed.
I think "show all" button in the top and bottom of the list would work. If we use (all) checkbox, it would give the user an idea that we can hide all columns, which is pointless when we are browsing a table.
Done in my git. The "show all" button will only appear in the top and bottom of the list if the list is too long (> 10). Otherwise, it will appear only at the bottom of the list.
Aris, is it possible to remove "Show all" when all columns are shown?
I also fixed the "too many"<th> while browsing in vertical mode in my last commit (ba4515212a24c1d81a7251e85a82d7c8649b7604). But not sure if changes in my commit are the best way to fix it.
Could you rename $foo_counter to emphasize the real usage of this variable?
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Le 2011-06-27 00:25, Aris Feryanto a écrit :
----- Original Message ----- Done in my git. The "show all" button will only appear in the top
and
bottom of the list if the list is too long (> 10). Otherwise, it will appear only at the bottom of the list.
Aris, is it possible to remove "Show all" when all columns are shown?
Yes, it is possible. But, I think it will be odd when the "Show all" button suddenly pop out in the top or bottom of the list when we click one of the checkbox.
I also fixed the "too many"<th> while browsing in vertical
mode in
my last commit (ba4515212a24c1d81a7251e85a82d7c8649b7604). But not sure if changes in my commit are the best way to fix it.
Could you rename $foo_counter to emphasize the real usage of this variable?
Done in my git (commit c7892cf5bbb7790ea725196f4a01dd2c40f43013).
P.S.: I've just realized the commit message for the commit ID above is not correct after I pushed it. The correct message should be "Change $foo_counter to $cell_displayed and some code fix".
-- Aris Feryanto
Le 2011-06-27 22:03, Aris Feryanto a écrit :
----- Original Message -----
From: Marc Delislemarc@infomarc.info
Le 2011-06-27 00:25, Aris Feryanto a écrit :
----- Original Message ----- Done in my git. The "show all" button will only appear in the top
and
bottom of the list if the list is too long (> 10). Otherwise, it will appear only at the bottom of the list.
Aris, is it possible to remove "Show all" when all columns are shown?
Yes, it is possible. But, I think it will be odd when the "Show all" button suddenly pop out in the top or bottom of the list when we click one of the checkbox.
Ok then.
By the way I just tested under IE 8 and there are no checkboxes displayed in the new drop-down.
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Le 2011-06-27 22:03, Aris Feryanto a écrit :
----- Original Message -----
From: Marc Delislemarc@infomarc.info
Le 2011-06-27 00:25, Aris Feryanto a écrit :
----- Original Message ----- Done in my git. The "show
all"
button will only appear in the top
and
bottom of the list if the list is too long (> 10). Otherwise, it will appear only at the bottom of the list.
Aris, is it possible to remove "Show all" when all columns
are
shown?
Yes, it is possible. But, I think it will be odd when the "Show
all"
button suddenly pop out in the top or bottom of the list when we click one of the checkbox.
Ok then.
By the way I just tested under IE 8 and there are no checkboxes displayed in the new drop-down.
Hmm.. This is really weird, since the checkbox use a very standard HTML tag. I'll look for the cause.
Thanks for the feedback, Marc.
-- Aris Feryanto
----- Original Message -----
From: Aris Feryanto aris_feryanto@yahoo.com
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Ok then.
By the way I just tested under IE 8 and there are no checkboxes displayed in the new drop-down.
Hmm.. This is really weird, since the checkbox use a very standard HTML tag. I'll look for the cause.
Fixed in my git and now updated in the demo server http://demo.phpmyadmin.net/gsoc-aris
-- Aris Feryanto
On Wed, Jun 29, 2011 at 6:11 AM, Aris Feryanto aris_feryanto@yahoo.com wrote:
----- Original Message -----
From: Aris Feryanto aris_feryanto@yahoo.com
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Ok then.
By the way I just tested under IE 8 and there are no checkboxes displayed in the new drop-down.
Hmm.. This is really weird, since the checkbox use a very standard HTML tag. I'll look for the cause.
Fixed in my git and now updated in the demo server http://demo.phpmyadmin.net/gsoc-aris
Looks very nice now, but there's a bug with the version that has been merged to master:
When removing multiline-cell-columns, and only leaving single line ones, so that the table height reduces, you get to see column borders extending beyond the table: http://www.tyron.at/tmp/columnborder.png
There's a div for those col borders having a fixed height: <div class="cRsz" style="height: 2122px; "> - i guess you need to adjust it when columns are being removed.
-- Aris Feryanto
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
----- Original Message -----
From: Tyron Madlener tyronx@gmail.com
On Wed, Jun 29, 2011 at 6:11 AM, Aris Feryanto aris_feryanto@yahoo.com wrote:
----- Original Message -----
From: Aris Feryanto aris_feryanto@yahoo.com
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Ok then.
By the way I just tested under IE 8 and there are no checkboxes displayed in the new drop-down.
Hmm.. This is really weird, since the checkbox use a very standard HTML
tag.
I'll look for the cause.
Fixed in my git and now updated in the demo server
http://demo.phpmyadmin.net/gsoc-aris
Looks very nice now, but there's a bug with the version that has been merged to master:
When removing multiline-cell-columns, and only leaving single line ones, so that the table height reduces, you get to see column borders extending beyond the table: http://www.tyron.at/tmp/columnborder.png
There's a div for those col borders having a fixed height: <div class="cRsz" style="height: 2122px; "> - i guess you need to adjust it when columns are being removed.
Hi,
Fixed in my git (commit c97ef9d53c554a4e5de6180247ca6d63709db77f). Thank you for reporting this. Marc, could you please merge this to official master branch? Thank you. :)
-- Aris Feryanto
Le 2011-07-05 21:59, Aris Feryanto a écrit :
----- Original Message -----
From: Tyron Madlener tyronx@gmail.com Looks very nice now, but there's a bug with the version that has been merged to master:
When removing multiline-cell-columns, and only leaving single line ones, so that the table height reduces, you get to see column borders extending beyond the table: http://www.tyron.at/tmp/columnborder.png
There's a div for those col borders having a fixed height: <div class="cRsz" style="height: 2122px; "> - i guess you need to adjust it when columns are being removed.
Hi,
Fixed in my git (commit c97ef9d53c554a4e5de6180247ca6d63709db77f). Thank you for reporting this. Marc, could you please merge this to official master branch? Thank you. :)
Done.
Hi,
I have two issues with this feature:
1. I see the tooltip "Click the drop-down arrow..." even when arrow isn't visible (when I have only one column in result set)
2. Clickable area with column name may not span correctly in available space if columns have short names [1]. It may not look too bad in English, but in Polish "Show all" translates to much longer "Pokaż wszystkie". Maybe checkboxes should be inside <label>s with display:block instead of using table for layout? Or styled <dl>, but this would require much more CSS to make it look right.
[1] http://img829.imageshack.us/img829/1531/hidecolumns.png
Hi Piotr,
----- Original Message -----
From: Piotr Przybylski piotr.prz@gmail.com
Hi,
I have two issues with this feature:
- I see the tooltip "Click the drop-down arrow..." even when arrow
isn't visible (when I have only one column in result set)
Fixed in my git [0].
- Clickable area with column name may not span correctly in available
space if columns have short names [1]. It may not look too bad in English, but in Polish "Show all" translates to much longer "Pokaż wszystkie". Maybe checkboxes should be inside <label>s with display:block instead of using table for layout? Or styled <dl>, but this would require much more CSS to make it look right.
Fixed in my git [1]. For the fix, I use nested div, instead of table for layout.
Thank you for your feedback. :)
[0] commit dbf06b6a1ba2ea901351718aad8c1f92de286daa [1] commit 7c4e0114e9d88120b6446eef88b3b9ad2203622c (but when merged to master, it caused merge conflict, which is solved by commit 991deb415ba369d87b2a816feb0180660329b332)
-- Aris Feryanto
Hi Aris
I have reused your Tooltip style (dHint class) and animation effects for my sortable tables on the status page. However I had to copy the code, maybe it's worth investing time in a reusable solution? Maybe based on qtip (or we remove qtip altogether and build our own solution)?
On Sun, Jul 10, 2011 at 5:17 AM, Aris Feryanto aris_feryanto@yahoo.com wrote:
Hi Piotr,
----- Original Message -----
From: Piotr Przybylski piotr.prz@gmail.com
Hi,
I have two issues with this feature:
- I see the tooltip "Click the drop-down arrow..." even when arrow
isn't visible (when I have only one column in result set)
Fixed in my git [0].
- Clickable area with column name may not span correctly in available
space if columns have short names [1]. It may not look too bad in English, but in Polish "Show all" translates to much longer "Pokaż wszystkie". Maybe checkboxes should be inside <label>s with display:block instead of using table for layout? Or styled <dl>, but this would require much more CSS to make it look right.
Fixed in my git [1]. For the fix, I use nested div, instead of table for layout.
Thank you for your feedback. :)
[0] commit dbf06b6a1ba2ea901351718aad8c1f92de286daa [1] commit 7c4e0114e9d88120b6446eef88b3b9ad2203622c (but when merged to master, it caused merge conflict, which is solved by commit 991deb415ba369d87b2a816feb0180660329b332)
-- Aris Feryanto
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
2011/7/10 Aris Feryanto aris_feryanto@yahoo.com:
Hi Piotr,
- Clickable area with column name may not span correctly in available
space if columns have short names [1]. It may not look too bad in English, but in Polish "Show all" translates to much longer "Pokaż wszystkie". Maybe checkboxes should be inside <label>s with display:block instead of using table for layout? Or styled <dl>, but this would require much more CSS to make it look right.
Fixed in my git [1]. For the fix, I use nested div, instead of table for layout.
One more thing.
+ $(listElmt).html('<input type="checkbox" ' + (g.colVisib[i] ? 'checked="checked" ' : '') + '/>' + + $(currHeader).text());
You use raw text - $(currHeader).text() - as HTML code. If a column is named "buggy<!--" then it isn't displayed properly in column list. Use $element.text('here goes any text') to set element's text. In this version you just lose part of the column, but before this commit the entire list after such column was broken.
You can use this SQL to create test table: create table escape_test (`buggy<!--` int, second int); insert into escape_test values(1,1);
----- Original Message -----
From: Tyron Madlener tyronx@gmail.com
Hi Aris
I have reused your Tooltip style (dHint class) and animation effects for my sortable tables on the status page. However I had to copy the code, maybe it's worth investing time in a reusable solution? Maybe based on qtip (or we remove qtip altogether and build our own solution)?
Hi Tyron,
Reusable code is always good. I think we can use qtip, since it is already included in phpMyAdmin jQuery library and the interface also looks nice. I'll try this on browse-mode tooltip.
-- Aris Feryanto
----- Original Message -----
From: Aris Feryanto aris_feryanto@yahoo.com
----- Original Message -----
From: Tyron Madlener tyronx@gmail.com
Hi Aris
I have reused your Tooltip style (dHint class) and animation effects for my sortable tables on the status page. However I had to copy the code, maybe it's worth investing time in a reusable solution? Maybe based on qtip (or we remove qtip altogether and build our own solution)?
Hi Tyron,
Reusable code is always good. I think we can use qtip, since it is already included in phpMyAdmin jQuery library and the interface also looks nice. I'll try this on browse-mode tooltip.
I changed the subject of this email to make it clearer.
I pushed new code using qTip to my repo. You may try the demo at [0]. But, there are some bugs left: - qTip seems to conflict with column highlighting. - I use qtip.hide() to hide the qtip when column header is clicked in order to mark/unmark or to reorder column. But, sometimes it just disappear and never come back again.
I think these problems won't happen in sortable tables on the status page, since it doesn't need special handling as in browse-mode. Before I proceed further, I would like to hear any comment or feedback from other phpMyAdmin developers and GSoC-ers about this qTip usage.
[0] http://demo.phpmyadmin.net/gsoc-aris
-- Aris Feryanto
On Mon, Jul 11, 2011 at 11:34 AM, Aris Feryanto aris_feryanto@yahoo.com wrote:
----- Original Message -----
From: Aris Feryanto aris_feryanto@yahoo.com
----- Original Message -----
From: Tyron Madlener tyronx@gmail.com
Hi Aris
I have reused your Tooltip style (dHint class) and animation effects for my sortable tables on the status page. However I had to copy the code, maybe it's worth investing time in a reusable solution? Maybe based on qtip (or we remove qtip altogether and build our own solution)?
Hi Tyron,
Reusable code is always good. I think we can use qtip, since it is already included in phpMyAdmin jQuery library and the interface also looks nice. I'll try this on browse-mode tooltip.
I changed the subject of this email to make it clearer.
I pushed new code using qTip to my repo. You may try the demo at [0]. But, there are some bugs left:
- qTip seems to conflict with column highlighting.
- I use qtip.hide() to hide the qtip when column header is clicked in order to mark/unmark or to reorder column. But, sometimes it just disappear and never come back again.
I think these problems won't happen in sortable tables on the status page, since it doesn't need special handling as in browse-mode. Before I proceed further, I would like to hear any comment or feedback from other phpMyAdmin developers and GSoC-ers about this qTip usage.
I somehow really liked the style and animation of the old tooltip. It was more aesthetically pleasing ;) Just like the apple site had it.
Maybe we can get qtip tooltips to look that same as well as have this zooming effect on them? Otherwise I would suggest to remove qtip from pma and build our own solution, since pma doesn't need the feature richness of qtip, I think.
And it should probably still follow the mouse cursor, and not point to the corner of the column. So altogether maybe we then define a function PMA_createqTip() in functions.js that applies some default options to qtip. Something like this:
function PMA_createqTip(element, options) { var o = { position: { target: 'mouse' }, style: { border: { width: 1, radius: 5, }, } }
$(element).qtip($.extend(o, options)); }
-- Aris Feryanto
All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-11 04:34, Aris Feryanto a écrit :
----- Original Message -----
From: Aris Feryanto aris_feryanto@yahoo.com
----- Original Message -----
From: Tyron Madlener tyronx@gmail.com
Hi Aris
I have reused your Tooltip style (dHint class) and animation effects for my sortable tables on the status page. However I had to copy the code, maybe it's worth investing time in a reusable solution? Maybe based on qtip (or we remove qtip altogether and build our own solution)?
Hi Tyron,
Reusable code is always good. I think we can use qtip, since it is already included in phpMyAdmin jQuery library and the interface also looks nice. I'll try this on browse-mode tooltip.
I changed the subject of this email to make it clearer.
I pushed new code using qTip to my repo. You may try the demo at [0]. But, there are some bugs left: - qTip seems to conflict with column highlighting. - I use qtip.hide() to hide the qtip when column header is clicked in order to mark/unmark or to reorder column. But, sometimes it just disappear and never come back again.
I confirm that with Firefox 5.0 and IE 9 on Windows Vista, I have a solid conflict with column highlighting. Everytime I hover over the column's header, vertical highlighting does not happen. Then I hover out and highlighting happens (it looks like the column was marked).
Worse: the tip cannot be read in IE 9 (it's very narrow).
I think these problems won't happen in sortable tables on the status page, since it doesn't need special handling as in browse-mode. Before I proceed further, I would like to hear any comment or feedback from other phpMyAdmin developers and GSoC-ers about this qTip usage.
[0] http://demo.phpmyadmin.net/gsoc-aris
-- Aris Feryanto
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2d-c2 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi,
----- Original Message -----
From: Tyron Madlener tyronx@gmail.com
On Mon, Jul 11, 2011 at 11:34 AM, Aris Feryanto aris_feryanto@yahoo.com wrote:
----- Original Message -----
From: Aris Feryanto aris_feryanto@yahoo.com
----- Original Message -----
From: Tyron Madlener tyronx@gmail.com
Hi Aris
I have reused your Tooltip style (dHint class) and animation
effects
for my sortable tables on the status page. However I had to copy
the
code, maybe it's worth investing time in a reusable solution?
Maybe
based on qtip (or we remove qtip altogether and build our own solution)?
Hi Tyron,
Reusable code is always good. I think we can use qtip, since it is
already
included in phpMyAdmin jQuery library and the interface also looks
nice.
I'll try this on browse-mode tooltip.
I changed the subject of this email to make it clearer.
I pushed new code using qTip to my repo. You may try the demo at [0]. But,
there are some bugs left:
- qTip seems to conflict with column highlighting.
- I use qtip.hide() to hide the qtip when column header is clicked in order
to mark/unmark or to reorder column. But, sometimes it just disappear and never come back again.
I think these problems won't happen in sortable tables on the status
page, since it doesn't need special handling as in browse-mode.
Before I proceed further, I would like to hear any comment or feedback from
other phpMyAdmin developers and GSoC-ers about this qTip usage.
I somehow really liked the style and animation of the old tooltip. It was more aesthetically pleasing ;) Just like the apple site had it.
Maybe we can get qtip tooltips to look that same as well as have this zooming effect on them? Otherwise I would suggest to remove qtip from pma and build our own solution, since pma doesn't need the feature richness of qtip, I think.
And it should probably still follow the mouse cursor, and not point to the corner of the column. So altogether maybe we then define a function PMA_createqTip() in functions.js that applies some default options to qtip. Something like this:
function PMA_createqTip(element, options) { var o = { position: { target: 'mouse' }, style: { border: { width: 1, radius: 5, }, } }
$(element).qtip($.extend(o, options)); }
I pushed code for the new tooltip. I used Tyron's suggestion to create a function PMA_createqTip() and added one parameter, "content" *. It looks very similar to the old tooltip, except for some behavior, like the tooltip sometimes not update its position while in the animation phase.
Please check the demo at http://demo.phpmyadmin.net/gsoc-aris.
* Actually, "content" can be specified inside "options" parameter, but I think it is used often and specifying it inside "options" may require people to understand about jQuery qTip's options. Thus, I separated it as a parameter.
-- Aris Feryanto
Le 2011-07-13 21:57, Aris Feryanto a écrit :
I pushed code for the new tooltip. I used Tyron's suggestion to create a function PMA_createqTip() and added one parameter, "content" *. It looks very similar to the old tooltip, except for some behavior, like the tooltip sometimes not update its position while in the animation phase.
Please check the demo at http://demo.phpmyadmin.net/gsoc-aris.
Aris, column highlighting conflict is fixed, however the problem under IE9 persists: I can't read a thing in these tooltips.
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Le 2011-07-13 21:57, Aris Feryanto a écrit :
I pushed code for the new tooltip. I used Tyron's suggestion to create a function PMA_createqTip() and added one parameter,
"content"
*. It looks very similar to the old tooltip, except for some behavior, like the tooltip sometimes not update its position while in the animation phase.
Please check the demo at http://demo.phpmyadmin.net/gsoc-aris.
Aris, column highlighting conflict is fixed, however the problem under IE9 persists: I can't read a thing in these tooltips.
Fixed in my git. After went through the qTip code, I found there was a bug in qTip. The bug make tooltips initialized with empty string always have 20px width in (my) IE. I'll report this bug to qTip community.
Thank you for the feedback.
-- Aris Feryanto
On Thu, 2011-07-14 at 21:25 -0700, Aris Feryanto wrote:
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Le 2011-07-13 21:57, Aris Feryanto a écrit :
I pushed code for the new tooltip. I used Tyron's suggestion to create a function PMA_createqTip() and added one parameter,
"content"
*. It looks very similar to the old tooltip, except for some behavior, like the tooltip sometimes not update its position while in the animation phase.
Please check the demo at http://demo.phpmyadmin.net/gsoc-aris.
Aris, column highlighting conflict is fixed, however the problem under IE9 persists: I can't read a thing in these tooltips.
Fixed in my git. After went through the qTip code, I found there was a bug in qTip. The bug make tooltips initialized with empty string always have 20px width in (my) IE. I'll report this bug to qTip community.
Thank you for the feedback.
I'd say don't bother reporting that to the qTtip crowd since qTip 1 is deprecated (the version we use), they are working on qTip 2, which is not yet released (yeah, I know, that makes no sense...).
By the way, now we have 2 different types of tooltips, I'd love to see them being unified some how. The other kind of tooltips are also created in functions.js, by function initTooltips(). So maybe PMA_createqTip() can be used to create those, too. Also the two functions should be phisically next to each other in the file, since they are kind of related. And the cherry on the cake would be if these two types of tooltips could be styled in a similar way and thus look more consistent.
Rouslan
On Fri, Jul 15, 2011 at 1:27 PM, Rouslan Placella rouslan@placella.com wrote:
On Thu, 2011-07-14 at 21:25 -0700, Aris Feryanto wrote:
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Le 2011-07-13 21:57, Aris Feryanto a écrit :
I pushed code for the new tooltip. I used Tyron's suggestion to create a function PMA_createqTip() and added one parameter,
"content"
*. It looks very similar to the old tooltip, except for some behavior, like the tooltip sometimes not update its position while in the animation phase.
Please check the demo at http://demo.phpmyadmin.net/gsoc-aris.
Aris, column highlighting conflict is fixed, however the problem under IE9 persists: I can't read a thing in these tooltips.
Fixed in my git. After went through the qTip code, I found there was a bug in qTip. The bug make tooltips initialized with empty string always have 20px width in (my) IE. I'll report this bug to qTip community.
Thank you for the feedback.
I'd say don't bother reporting that to the qTtip crowd since qTip 1 is deprecated (the version we use), they are working on qTip 2, which is not yet released (yeah, I know, that makes no sense...).
By the way, now we have 2 different types of tooltips, I'd love to see them being unified some how. The other kind of tooltips are also created in functions.js, by function initTooltips(). So maybe PMA_createqTip() can be used to create those, too. Also the two functions should be phisically next to each other in the file, since they are kind of related. And the cherry on the cake would be if these two types of tooltips could be styled in a similar way and thus look more consistent.
Rouslan
The style can be similar but I still think it's good to have them differ slightly for the 2 different uses. One for hints such as "Hey you can sort this table by clicking the columns" and the others for longer footnotes and explanations.
So I find it great that Aris' tooltip is fancy and animated for the first case.
AppSumo Presents a FREE Video for the SourceForge Community by Eric Ries, the creator of the Lean Startup Methodology on "Lean Startup Secrets Revealed." This video shows you how to validate your ideas, optimize your ideas and identify your business strategy. http://p.sf.net/sfu/appsumosfdev2dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Le 2011-07-15 00:25, Aris Feryanto a écrit :
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Le 2011-07-13 21:57, Aris Feryanto a écrit :
I pushed code for the new tooltip. I used Tyron's suggestion to create a function PMA_createqTip() and added one parameter,
"content"
*. It looks very similar to the old tooltip, except for some behavior, like the tooltip sometimes not update its position while in the animation phase.
Please check the demo at http://demo.phpmyadmin.net/gsoc-aris.
Aris, column highlighting conflict is fixed, however the problem under IE9 persists: I can't read a thing in these tooltips.
Fixed in my git. After went through the qTip code, I found there was a bug in qTip. The bug make tooltips initialized with empty string always have 20px width in (my) IE. I'll report this bug to qTip community.
Thank you for the feedback.
Merged to official. Next time, let's use non-minified versions of the libraries during development (they are compressed at release time).
On Jul 15, 2011, at 6:51 PM, Tyron Madlener tyronx@gmail.com wrote:
On Fri, Jul 15, 2011 at 1:27 PM, Rouslan Placella rouslan@placella.com wrote:
On Thu, 2011-07-14 at 21:25 -0700, Aris Feryanto wrote:
----- Original Message -----
From: Marc Delisle marc@infomarc.info
Le 2011-07-13 21:57, Aris Feryanto a écrit :
I pushed code for the new tooltip. I used Tyron's suggestion to create a function PMA_createqTip() and added one parameter,
"content"
*. It looks very similar to the old tooltip, except for some behavior, like the tooltip sometimes not update its position while in the animation phase.
Please check the demo at http://demo.phpmyadmin.net/gsoc-aris.
Aris, column highlighting conflict is fixed, however the problem under IE9 persists: I can't read a thing in these tooltips.
Fixed in my git. After went through the qTip code, I found there was a bug in qTip. The bug make tooltips initialized with empty string always have 20px width in (my) IE. I'll report this bug to qTip community.
Thank you for the feedback.
I'd say don't bother reporting that to the qTtip crowd since qTip 1 is deprecated (the version we use), they are working on qTip 2, which is not yet released (yeah, I know, that makes no sense...).
By the way, now we have 2 different types of tooltips, I'd love to see them being unified some how. The other kind of tooltips are also created in functions.js, by function initTooltips(). So maybe PMA_createqTip() can be used to create those, too. Also the two functions should be phisically next to each other in the file, since they are kind of related. And the cherry on the cake would be if these two types of tooltips could be styled in a similar way and thus look more consistent.
Rouslan
The style can be similar but I still think it's good to have them differ slightly for the 2 different uses. One for hints such as "Hey you can sort this table by clicking the columns" and the others for longer footnotes and explanations.
So I find it great that Aris' tooltip is fancy and animated for the first case.
Yes, I agree with Tyron about this. I think it is good to have the two slightly different tooltips for different usage.
-- Aris Feryanto
Hi Aris
Is there any possibility to partly or fully reuse the code for column show/hide feature and the column reordering? I would very much like to use the same features for my log tables on the Status page -> Monitor Tab.
Thanks, Tyron
On Fri, Jun 24, 2011 at 8:04 PM, Aris Feryanto aris_feryanto@yahoo.com wrote:
Hi,
I've just pushed my commits for show/hide column feature. If you have some time, please give it a try at [0] and let me know if you have any comment or suggestion.
When you are testing, please note that the feature still lack of some things: - column visibility list drop-down arrows are shown in "too many" places when display mode = vertical AND repeatCells = small number
- the hide (small X) button is sometimes annoying, especially when we want to sort a small column (e.g., usually ID). I've tried to resize all columns using jQuery to properly display the "hide" button next to the column label. But, unfortunately, it is quite slow. Any other suggestion? Should we remove the "hide" button?
[0] http://demo.phpmyadmin.net/gsoc-aris
Regards,
-- Aris Feryanto
All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense.. http://p.sf.net/sfu/splunk-d2d-c1 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
-
Aris Feryanto -
Marc Delisle -
Piotr Przybylski -
Rouslan Placella -
Tyron Madlener