I forgot one more thing:
- lib.inc.php3: the function remove_remarks() is bugged because if a string contains a '#' in a string, it is considered as a comment. As stated in bug #444279.
I already said that comments need not being stripped off queries. Mysql works just fine if you give it all the comments. No need removing them (as is was in my 2.1.0.1 version).
I made tests and removing the call to remove_remarks() does not affect queries that have comments *at all*. The call to remove_remarks() is *really* useless in db_readdump.php3.
PS: sorry for double posting one of my previous messages.
Benjamin Gandon a écrit :
I forgot one more thing:
- lib.inc.php3: the function remove_remarks() is bugged because if a string contains a '#' in a string, it is considered as a comment. As stated in bug #444279.
I already said that comments need not being stripped off queries. Mysql works just fine if you give it all the comments. No need removing them (as is was in my 2.1.0.1 version).
Benjamin,
do you know if there are old MySQL versions that would not like comments?
Marc
On Thu, 2 Aug 2001, Marc Delisle wrote:
Benjamin Gandon a écrit :
I forgot one more thing:
- lib.inc.php3: the function remove_remarks() is bugged because if a string contains a '#' in a string, it is considered as a comment. As stated in bug #444279.
I already said that comments need not being stripped off queries. Mysql works just fine if you give it all the comments. No need removing them (as is was in my 2.1.0.1 version).
Benjamin,
do you know if there are old MySQL versions that would not like comments?
Marc
I did a bit of poking around in the online documentation, and certainly nothing in the 3.2x's cares.
-
Benjamin Gandon -
Ignacio Vazquez-Abrams -
Marc Delisle