Hi Michal,
Juergen reported that in 2.8.2.3, setup script does not work and I confirm (on systems with register_globals set to Off).
At the beginning we now have $PMA_Config_Setup = new PMA_Config();
and later we do if ( $GLOBALS['PMA_Config']->get( 'PMA_PHP_INT_VERSION' ) < 40100) {
which is a line (1836) that fails.
But sometimes this script refers to $PMA_Config_Setup->get('PMA_VERSION')
What is the reason for $GLOBALS['PMA_Config'] ?
Marc
Marc Delisle wrote:
Hi Michal,
Juergen reported that in 2.8.2.3, setup script does not work and I confirm (on systems with register_globals set to Off).
At the beginning we now have $PMA_Config_Setup = new PMA_Config();
and later we do if ( $GLOBALS['PMA_Config']->get( 'PMA_PHP_INT_VERSION' ) < 40100) {
which is a line (1836) that fails.
But sometimes this script refers to $PMA_Config_Setup->get('PMA_VERSION')
What is the reason for $GLOBALS['PMA_Config'] ?
Marc
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&da... _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
maybe a simple typo? works independent from register_globals with $_SESSION['PMA_Config']
Jürgen Wind a écrit :
Marc Delisle wrote:
Hi Michal,
Juergen reported that in 2.8.2.3, setup script does not work and I confirm (on systems with register_globals set to Off).
At the beginning we now have $PMA_Config_Setup = new PMA_Config();
and later we do if ( $GLOBALS['PMA_Config']->get( 'PMA_PHP_INT_VERSION' ) < 40100) {
which is a line (1836) that fails.
But sometimes this script refers to $PMA_Config_Setup->get('PMA_VERSION')
What is the reason for $GLOBALS['PMA_Config'] ?
Marc
maybe a simple typo? works independent from register_globals with $_SESSION['PMA_Config']
Yes; I'll merge and release 2.8.2.4.
Marc, lets first see, if $GLOBALS['PMA_Config_Setup'] is the better patch (also in line 1811)
Marc Delisle wrote:
Jürgen Wind a écrit :
Marc, lets first see, if $GLOBALS['PMA_Config_Setup'] is the better patch (also in line 1811)
Well, many functions in setup.php are using
global $PMA_Config_Setup;
and then $PMA_Config_Setup->something
I think this would be more consistent.
Marc
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&da... _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
and why $GLOBALS['PMA_Config_Setup']->get (2 occurrences) and not $PMA_Config_Setup->get (many occurrences) ?
Jürgen Wind a écrit :
Marc Delisle wrote:
Jürgen Wind a écrit :
Marc, lets first see, if $GLOBALS['PMA_Config_Setup'] is the better patch (also in line 1811)
Well, many functions in setup.php are using
global $PMA_Config_Setup;
and then $PMA_Config_Setup->something
I think this would be more consistent.
Marc
and why $GLOBALS['PMA_Config_Setup']->get (2 occurrences) and not $PMA_Config_Setup->get (many occurrences) ?
This was my question to Michal in the devel-list...
But I think it's safe to merge my latest suggestion.
Marc
Marc Delisle a écrit :
Jürgen Wind a écrit :
Marc Delisle wrote:
Jürgen Wind a écrit :
Marc, lets first see, if $GLOBALS['PMA_Config_Setup'] is the better patch (also in line 1811)
Well, many functions in setup.php are using
global $PMA_Config_Setup;
and then $PMA_Config_Setup->something
I think this would be more consistent.
Marc
and why $GLOBALS['PMA_Config_Setup']->get (2 occurrences) and not $PMA_Config_Setup->get (many occurrences) ?
This was my question to Michal in the devel-list...
But I think it's safe to merge my latest suggestion.
Marc
Well, at this point we are already in the global context, no need for "global ..." .
This should be safe, checking the PHP version is checking the PHP version :)
Marc
Hi
On Tue, 22 Aug 2006 13:24:52 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Jürgen Wind a écrit :
and why $GLOBALS['PMA_Config_Setup']->get (2 occurrences) and not $PMA_Config_Setup->get (many occurrences) ?
I have no idea :-), probably just because of some cut and paste...
This was my question to Michal in the devel-list...
I'm not online 24/365 :-)
Michal Čihař a écrit :
Hi
On Tue, 22 Aug 2006 13:24:52 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
Jürgen Wind a écrit :
and why $GLOBALS['PMA_Config_Setup']->get (2 occurrences) and not $PMA_Config_Setup->get (many occurrences) ?
I have no idea :-), probably just because of some cut and paste...
This was my question to Michal in the devel-list...
I'm not online 24/365 :-)
No problem about this!
I assume you agree with the changes in 2.8.2.4? :)
Marc
On Wed, 23 Aug 2006 06:07:07 -0400 Marc Delisle Marc.Delisle@cegepsherbrooke.qc.ca wrote:
I assume you agree with the changes in 2.8.2.4? :)
Yes :-)
-
Jürgen Wind -
Marc Delisle -
Michal Čihař