Hi all,
I've pushed the implementation of feature "Remember the last way user sorted tables" when browsing tables. You may try it at the demo server [0].
Current implementation only remember the sorting in the session variable. So, when you logout and login again, the sorting will be refreshed. In order to keep it persistent across session, I will add a new table in phpMyAdmin database and store the sorting and maybe other "browsing"-related data in there later.
In the settings page, I added new boolean field (RememberConfig) under Settings -> Main frame -> Browse mode -> Remember table's sorting I set the default value to "true", so you can test the demo without changing any settings.
Any feedback or suggestion is really appreciated.
Regards, -- Aris Feryanto
Sorry, forgot the link. :) From: Aris Feryanto aris_feryanto@yahoo.com
To: "phpmyadmin-devel@lists.sourceforge.net" phpmyadmin-devel@lists.sourceforge.net Sent: Tuesday, May 24, 2011 5:17 PM Subject: [Phpmyadmin-devel] Remember the last way user sorted tables
Hi all,
I've pushed the implementation of feature "Remember the last way user sorted tables" when browsing tables. You may try it at the demo server [0].
Current implementation only remember the sorting in the session variable. So, when you logout and login again, the sorting will be refreshed. In order to keep it persistent across session, I will add a new table in phpMyAdmin database and store the sorting and maybe other "browsing"-related data in there later.
In the settings page, I added new boolean field (RememberConfig) under Settings -> Main frame -> Browse mode -> Remember table's sorting I set the default value to "true", so you can test the demo without changing any settings.
Any feedback or suggestion is really appreciated.
[0] hhttp://demo.phpmyadmin.net/gsoc-aris-- Aris Feryanto
2011/5/24 Aris Feryanto aris_feryanto@yahoo.com:
Hi all, I've pushed the implementation of feature "Remember the last way user sorted tables" when browsing tables. You may try it at the demo server [0]. Current implementation only remember the sorting in the session variable. So, when you logout and login again, the sorting will be refreshed. In order to keep it persistent across session, I will add a new table in phpMyAdmin database and store the sorting and maybe other "browsing"-related data in there later.
If you store all data in memory, I think you can use pma_userconfig table for that, just add a new text column for serialized data.
Piotr Przybylski a écrit :
2011/5/24 Aris Feryanto aris_feryanto@yahoo.com:
Hi all, I've pushed the implementation of feature "Remember the last way user sorted tables" when browsing tables. You may try it at the demo server [0]. Current implementation only remember the sorting in the session variable. So, when you logout and login again, the sorting will be refreshed. In order to keep it persistent across session, I will add a new table in phpMyAdmin database and store the sorting and maybe other "browsing"-related data in there later.
If you store all data in memory, I think you can use pma_userconfig table for that, just add a new text column for serialized data.
I think it's preferable not to modify this table's structure. It will be easier to handle for users and packagers, to have a new table, rather than changing the structure of the existing table.
Hi,
From: Marc Delisle marc@infomarc.info To: phpmyadmin-devel@lists.sourceforge.net Sent: Tuesday, May 24, 2011 7:45 PM Subject: Re: [Phpmyadmin-devel] Remember the last way user sorted tables
Piotr Przybylski a écrit :
If you store all data in memory, I think you can use pma_userconfig table for that, just add a new text column for serialized data.
I think it's preferable not to modify this table's structure. It will be easier to handle for users and packagers, to have a new table, rather than changing the structure of the existing table.
I pushed changes to my repository. In the repo, I did some changes regarding the storage for "remember the last way user sorted tables":
- For the storage, I created a new table which store per table's data. The table consist of 4 columns: username, db_name, table_name, and prefs. I haven't put any limit for the number of records, as suggested by Piotr. I will do it after all features regarding table-browsing implemented. - I put new code to load and store "table sorting" in PMA_Table class.
To test these changes, you will need to create new table using script in scripts/create_tables.sql and change the configuration
$cfg['Servers'][$i]['table_uiprefs'] = 'pma_table_uiprefs';
(which I think cannot be done in demo server)
After this setup, you will be able to browse a table, sort them by clicking table's header, logout, login again, browse to the table, and the table will remain sorted in the last way you sorted it. Comments and suggestions are really appreciated.
Regards,
-- Aris Feryanto
Aris Feryanto a écrit :
Hi,
From: Marc Delisle marc@infomarc.info To: phpmyadmin-devel@lists.sourceforge.net Sent: Tuesday, May 24, 2011 7:45 PM Subject: Re: [Phpmyadmin-devel] Remember the last way user sorted tables
Piotr Przybylski a écrit :
If you store all data in memory, I think you can use pma_userconfig table for that, just add a new text column for serialized data.
I think it's preferable not to modify this table's structure. It will be easier to handle for users and packagers, to have a new table, rather than changing the structure of the existing table.
I pushed changes to my repository. In the repo, I did some changes regarding the storage for "remember the last way user sorted tables":
- For the storage, I created a new table which store per table's data. The table consist of 4 columns: username, db_name, table_name, and prefs. I haven't put any limit for the number of records, as suggested by Piotr. I will do it after all features regarding table-browsing implemented.
- I put new code to load and store "table sorting" in PMA_Table class.
To test these changes, you will need to create new table using script in scripts/create_tables.sql and change the configuration
$cfg['Servers'][$i]['table_uiprefs'] = 'pma_table_uiprefs';
(which I think cannot be done in demo server)
After this setup, you will be able to browse a table, sort them by clicking table's header, logout, login again, browse to the table, and the table will remain sorted in the last way you sorted it. Comments and suggestions are really appreciated.
Hi Aris, the feature works fine and I believe it's ready to be merged in origin/master, do you agree?
Hi Marc,
On 27 Mei 2011, at 23:53, Marc Delisle marc@infomarc.info wrote:
Aris Feryanto a écrit :
Hi,
I pushed changes to my repository. In the repo, I did some changes regarding the storage for "remember the last way user sorted tables":
- For the storage, I created a new table which store per table's data. The table consist of 4 columns: username, db_name, table_name, and prefs. I haven't put any limit for the number of records, as suggested by Piotr. I will do it after all features regarding table-browsing implemented.
- I put new code to load and store "table sorting" in PMA_Table class.
To test these changes, you will need to create new table using script in scripts/create_tables.sql and change the configuration
$cfg['Servers'][$i]['table_uiprefs'] = 'pma_table_uiprefs';
(which I think cannot be done in demo server)
After this setup, you will be able to browse a table, sort them by clicking table's header, logout, login again, browse to the table, and the table will remain sorted in the last way you sorted it. Comments and suggestions are really appreciated.
Hi Aris, the feature works fine and I believe it's ready to be merged in origin/master, do you agree?
I agree. Only one thing left to do later: limiting the number of records in table_uiprefs table.
My commits for this feature is located in "tablesort" branch in my git repo.
-- I don't have any experience in merging to official master and I don't know how hard it would be to do merging from my "mixed" master repo. So, I separated each feature in each branch, in case you find it easier to merge this way.
-- Aris Feryanto
Le 2011-05-27 13:48, Aris Feryanto a écrit :
Hi Marc,
On 27 Mei 2011, at 23:53, Marc Delisle marc@infomarc.info wrote:
Aris Feryanto a écrit :
Hi,
I pushed changes to my repository. In the repo, I did some changes regarding the storage for "remember the last way user sorted tables":
- For the storage, I created a new table which store per table's
data. The table consist of 4 columns: username, db_name, table_name, and prefs. I haven't put any limit for the number of records, as suggested by Piotr. I will do it after all features regarding table-browsing implemented. - I put new code to load and store "table sorting" in PMA_Table class.
To test these changes, you will need to create new table using script in scripts/create_tables.sql and change the configuration
$cfg['Servers'][$i]['table_uiprefs'] = 'pma_table_uiprefs';
(which I think cannot be done in demo server)
After this setup, you will be able to browse a table, sort them by clicking table's header, logout, login again, browse to the table, and the table will remain sorted in the last way you sorted it. Comments and suggestions are really appreciated.
Hi Aris, the feature works fine and I believe it's ready to be merged in origin/master, do you agree?
I agree. Only one thing left to do later: limiting the number of records in table_uiprefs table.
My commits for this feature is located in "tablesort" branch in my git repo.
-- I don't have any experience in merging to official master and I don't know how hard it would be to do merging from my "mixed" master repo. So, I separated each feature in each branch, in case you find it easier to merge this way.
Merged, thanks. It's probably easier to merge from separate branch, especially if you add something to this feature later; OTOH, in the long term these features will need some code from your other features so you must ensure that they all work together in your master branch.
Aris Feryanto a écrit :
Hi all,
I've pushed the implementation of feature "Remember the last way user sorted tables" when browsing tables. You may try it at the demo server [0].
Current implementation only remember the sorting in the session variable. So, when you logout and login again, the sorting will be refreshed. In order to keep it persistent across session, I will add a new table in phpMyAdmin database and store the sorting and maybe other "browsing"-related data in there later.
In the settings page, I added new boolean field (RememberConfig) under Settings -> Main frame -> Browse mode -> Remember table's sorting I set the default value to "true", so you can test the demo without changing any settings.
Any feedback or suggestion is really appreciated.
Aris,
The feature works well so far. Please have a look at this notice:
Notice in ./sql.php#364 Use of undefined constant table_ref - assumed 'table_ref'
On Tue, May 24, 2011 at 6:12 PM, Marc Delisle marc@infomarc.info wrote:
Aris Feryanto a écrit :
Hi all,
I've pushed the implementation of feature "Remember the last way user sorted tables" when browsing tables. You may try it at the demo server [0].
Current implementation only remember the sorting in the session variable. So, when you logout and login again, the sorting will be refreshed. In order to keep it persistent across session, I will add a new table in phpMyAdmin database and store the sorting and maybe other "browsing"-related data in there later.
In the settings page, I added new boolean field (RememberConfig) under Settings -> Main frame -> Browse mode -> Remember table's sorting I set the default value to "true", so you can test the demo without changing any settings.
Any feedback or suggestion is really appreciated.
Aris,
The feature works well so far. Please have a look at this notice:
Notice in ./sql.php#364 Use of undefined constant table_ref - assumed 'table_ref'
There is a bug in commit 8f2a040f41f2cd03e359bcadeb8d9f24c23290fa (which seems related to the discussed table list here).
This added lines of js code in function.js throw "Uncaught TypeError: Cannot call method 'PMA_reloadRecentTable' of undefined" when you open a page in a new tab since there is no window.parent
+ $('#update_recent_tables').ready(function() { + window.parent.frame_navigation.PMA_reloadRecentTable(); + });
-- Marc Delisle http://infomarc.info
vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
On 24 Mei 2011, at 23:48, Tyron Madlener tyronx@gmail.com wrote:
On Tue, May 24, 2011 at 6:12 PM, Marc Delisle marc@infomarc.info wrote:
Aris,
The feature works well so far. Please have a look at this notice:
Notice in ./sql.php#364 Use of undefined constant table_ref - assumed 'table_ref'
There is a bug in commit 8f2a040f41f2cd03e359bcadeb8d9f24c23290fa (which seems related to the discussed table list here).
This added lines of js code in function.js throw "Uncaught TypeError: Cannot call method 'PMA_reloadRecentTable' of undefined" when you open a page in a new tab since there is no window.parent
Thanks, Tyron. I'll fix this in next commit. :)
$('#update_recent_tables').ready(function() {window.parent.frame_navigation.PMA_reloadRecentTable();});
-- Aris Feryanto
On 24 Mei 2011, at 23:12, Marc Delisle marc@infomarc.info wrote:
Aris Feryanto a écrit :
Hi all,
I've pushed the implementation of feature "Remember the last way user sorted tables" when browsing tables. You may try it at the demo server [0].
Current implementation only remember the sorting in the session variable. So, when you logout and login again, the sorting will be refreshed. In order to keep it persistent across session, I will add a new table in phpMyAdmin database and store the sorting and maybe other "browsing"-related data in there later.
In the settings page, I added new boolean field (RememberConfig) under Settings -> Main frame -> Browse mode -> Remember table's sorting I set the default value to "true", so you can test the demo without changing any settings.
Any feedback or suggestion is really appreciated.
Aris,
The feature works well so far. Please have a look at this notice:
Notice in ./sql.php#364 Use of undefined constant table_ref - assumed 'table_ref'
Missed that one. Thank you, Marc. Commit for the fix will be in my next push.
-- Aris Feryanto
-
Aris Feryanto -
Marc Delisle -
Piotr Przybylski -
Tyron Madlener