[Phpmyadmin-devel] Martynas tree - codingstandards
Martynas, Unfortunately the latest git version is broken for me. At least in libraries/chart.lib.php on line 5 you use a lower case filename which does not match in case-sensitive environments. Some other points: * Please use curly braces even in situations where they are technically optional. Not: if (is_null($options)) return; but if (is_null($options)) { return; } * Please make sure you properly escape variables you print to the user. $sql_query in tbl_chart.php should probably have htmlspecialchars() In general ... distrust any data you get from the outside. Most code looks OK though, nice going. -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions
Hey, I am back on the track. I have fixed the case problem a while ago but it did not solve the problem completely. I was wondering maybe it would be possible to enable all error reporting on the http://demo.phpmyadmin.net/gsoc-blinky so that I can find where the error is. If this is not possible then an ability for me to tell the demo server to fetch the latest revision from repository would be nice. This would decrease debugging time substantially. Martynas On 23 June 2010 12:08, Herman van Rink <rink@initfour.nl> wrote:
Martynas,
Unfortunately the latest git version is broken for me. At least in libraries/chart.lib.php on line 5 you use a lower case filename which does not match in case-sensitive environments.
Some other points: * Please use curly braces even in situations where they are technically optional. Not: if (is_null($options)) return;
but
if (is_null($options)) { return; }
* Please make sure you properly escape variables you print to the user. $sql_query in tbl_chart.php should probably have htmlspecialchars() In general ... distrust any data you get from the outside.
Most code looks OK though, nice going.
-- Met vriendelijke groet / Regards,
Herman van Rink Initfour websolutions
------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Dne Tue, 6 Jul 2010 16:37:21 +0300 Martynas Mickevičius <mmartynas@gmail.com> napsal(a):
Hey, I am back on the track.
I have fixed the case problem a while ago but it did not solve the problem completely.
I was wondering maybe it would be possible to enable all error reporting on the http://demo.phpmyadmin.net/gsoc-blinky so that I can find where the error is.
What kind of error reporting is missing?
If this is not possible then an ability for me to tell the demo server to fetch the latest revision from repository would be nice. This would decrease debugging time substantially.
It is updated every hour, I don't think more frequent updates are needed. Plus you should rather debug stuff locally, this is just for others to see your code as it is progressing. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
On 7 July 2010 16:54, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Tue, 6 Jul 2010 16:37:21 +0300 Martynas Mickevičius <mmartynas@gmail.com> napsal(a):
Hey, I am back on the track.
I have fixed the case problem a while ago but it did not solve the problem completely.
I was wondering maybe it would be possible to enable all error reporting on the http://demo.phpmyadmin.net/gsoc-blinky so that I can find where the error is.
What kind of error reporting is missing?
Well I had one problem with the demo server. My fork kept on stopping without any error or warning on the demo server while it ran OK on my local server. I did not know where the problem was so I thought that turning all error reporting would help me to debug that. Yesterday I figured out where the problem was. As far as I understand there is no GD installed on the demo server. (:
If this is not possible then an ability for me to tell the demo server to fetch the latest revision from repository would be nice. This would decrease debugging time substantially.
It is updated every hour, I don't think more frequent updates are needed. Plus you should rather debug stuff locally, this is just for others to see your code as it is progressing.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Could you install GD library on the demo server? 2010/7/7 Martynas Mickevičius <mmartynas@gmail.com>
On 7 July 2010 16:54, Michal Čihař <michal@cihar.com> wrote:
Hi
Dne Tue, 6 Jul 2010 16:37:21 +0300 Martynas Mickevičius <mmartynas@gmail.com> napsal(a):
Hey, I am back on the track.
I have fixed the case problem a while ago but it did not solve the problem completely.
I was wondering maybe it would be possible to enable all error reporting on the http://demo.phpmyadmin.net/gsoc-blinky so that I can find where the error is.
What kind of error reporting is missing?
Well I had one problem with the demo server. My fork kept on stopping without any error or warning on the demo server while it ran OK on my local server. I did not know where the problem was so I thought that turning all error reporting would help me to debug that. Yesterday I figured out where the problem was. As far as I understand there is no GD installed on the demo server. (:
If this is not possible then an ability for me to tell the demo server to fetch the latest revision from repository would be nice. This would decrease debugging time substantially.
It is updated every hour, I don't think more frequent updates are needed. Plus you should rather debug stuff locally, this is just for others to see your code as it is progressing.
-- Michal Čihař | http://cihar.com | http://blog.cihar.com
------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hi Dne Thu, 8 Jul 2010 15:29:57 +0300 Martynas Mickevičius <mmartynas@gmail.com> napsal(a):
Could you install GD library on the demo server?
Installed, but your code should properly warn in this case (using PMA_warnMissingExtension). -- Michal Čihař | http://cihar.com | http://blog.cihar.com
participants (3)
-
Herman van Rink -
Martynas Mickevičius -
Michal Čihař