Hi,
I'm currently experiencing an issue with hhvm, see https://travis-ci.org/phpmyadmin/phpmyadmin/builds/32882088 As you can see, all unit tests are ok, except for tests of stristr with hhvm. It seems that the hhvm version used on Travis is "HipHop VM 3.2.0".
Does anyone have hhvm (this version or another) please, could run phpunit on test/libraries/PMA_String_Compare_test.php and give me a feedback?
Thanks, Hugues
On Tue, Aug 19, 2014 at 12:53 AM, Hugues Peccatte <hugues.peccatte@gmail.com
wrote:
Hi,
I'm currently experiencing an issue with hhvm, see https://travis-ci.org/phpmyadmin/phpmyadmin/builds/32882088 As you can see, all unit tests are ok, except for tests of stristr with hhvm. It seems that the hhvm version used on Travis is "HipHop VM 3.2.0".
Does anyone have hhvm (this version or another) please, could run phpunit on test/libraries/PMA_String_Compare_test.php and give me a feedback?
I tested it online here: http://3v4l.org/SpjWN It seems like 3 argument is still not present for hhvm. However these HHVM docs [1], which does seem to be a copy PHP Manual says it is there.
[1]: http://docs.hhvm.com/manual/en/function.stristr.php
Hi
Dne Mon, 18 Aug 2014 21:23:56 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I'm currently experiencing an issue with hhvm, see https://travis-ci.org/phpmyadmin/phpmyadmin/builds/32882088 As you can see, all unit tests are ok, except for tests of stristr with hhvm. It seems that the hhvm version used on Travis is "HipHop VM 3.2.0".
Does anyone have hhvm (this version or another) please, could run phpunit on test/libraries/PMA_String_Compare_test.php and give me a feedback?
It indeed does not work, I've reported it here:
https://github.com/facebook/hhvm/issues/3520
PS: We don't seem to use this functionality in our code, so maybe support for this could be removed from PMA_String?
2014-08-19 8:00 GMT+02:00 Michal Čihař michal@cihar.com:
Hi
Dne Mon, 18 Aug 2014 21:23:56 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
I'm currently experiencing an issue with hhvm, see https://travis-ci.org/phpmyadmin/phpmyadmin/builds/32882088 As you can see, all unit tests are ok, except for tests of stristr with hhvm. It seems that the hhvm version used on Travis is "HipHop VM 3.2.0".
Does anyone have hhvm (this version or another) please, could run phpunit on test/libraries/PMA_String_Compare_test.php and give me a feedback?
It indeed does not work, I've reported it here:
https://github.com/facebook/hhvm/issues/3520
PS: We don't seem to use this functionality in our code, so maybe support for this could be removed from PMA_String?
-- Michal Čihař | http://cihar.com | http://phpmyadmin.net
Hi,
We're using it, see https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/DisplayResult... (many uses in this file). But, as Marc suggested, we may remove it from PMA_String for now.
Hugues.
Hi
Dne Tue, 19 Aug 2014 11:59:42 +0200 Hugues Peccatte hugues.peccatte@gmail.com napsal(a):
We're using it, see https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/DisplayResult... (many uses in this file).
I know the function is used, what I meant is that we always use just two parameters, so not supporting third one is not really an issue for us.
-
Chirayu Chiripal -
Hugues Peccatte -
Michal Čihař