i have merged in devel tree tbl_dump and db_dump to tbl_dump, because the code was 98% identical.
I saw that yesterday on the CVS. It's a good idea :)
I agree, in fact it should be easier to implement the "gzip of the dump feature" that way. Is anybody working on that, I think someone does ?!
Oops, why not add the phpMyAdmin version in the dump header ? Maybe, it could be useful.
Yep, maybe the version should be a var in lib.inc.php3 or config.inc.php3 (all incremental changes in one place) ?
Regards, Alain.
_______________________________________________________
Hi,
I agree, in fact it should be easier to implement the "gzip of the dump feature" that way. Is anybody working on that, I think someone does ?!
Last month, i worked on the gzip dump, just for fun. But, i had problem.
** First method use gzwrite(). Binary-safe gz-file write.
Good : support by php3/php4 Bad : require write access on the server.
** Second method use gzencode(). Create a gzip compressed string
Good : create a gzip compressed string...on the fly Bad : support by >= php4.0.4
What do you think about this ?
I prefer the second one. With a simple test for this feature, like :
if (function_exists('gzencode')) { // gzip dump feature is ok }
Regards,
Armel.
** Second method use gzencode(). Create a gzip compressed string
Good : create a gzip compressed string...on the fly Bad : support by >= php4.0.4
What do you think about this ?
I prefer the second one. With a simple test for this feature, like :
if (function_exists('gzencode')) { // gzip dump feature is ok }
Yes, second one ;-) ... in spite of the annoying php4 dependancy.
Alain.
On Mon, Jun 25, 2001 at 07:45:50PM +0100, Armel FAUVEAU wrote:
Last month, i worked on the gzip dump, just for fun. But, i had problem.
** First method use gzwrite(). Binary-safe gz-file write.
Good : support by php3/php4 Bad : require write access on the server.
** Second method use gzencode(). Create a gzip compressed string
Good : create a gzip compressed string...on the fly Bad : support by >= php4.0.4
What do you think about this ?
The chances are bigger to find a php4 server than a server where you have write access, so I also think the second way would be the best.
Greetings, Olivier