Hi everybody
why do we need target="phpmain.. in many forms? I liked previous behaviour that I could open few (or many :-) windows for ONE phpMyAdmin installation and they didn't influent each other. Now everything posted goes into one frame...
Hi Michal!
why do we need target="phpmain.. in many forms? I liked previous behaviour that I could open few (or many :-) windows for ONE phpMyAdmin installation and they didn't influent each other. Now everything posted goes into one frame...
It's for the sake of the new query window. When opening multiple instances, everything entered into the window would only affect a single frame, but the desired effect would be that each query instance only affects its parent. This was discussed in a bug item, somewhen after RC1 release: #723713
With the current implementation the multiple windows should also only affect their own parents, using JS and QueryFrameJS = true.
Regards, Garvin.
Hi Garvin & list
On 28.04.2003 16:32, Garvin Hicking wrote:
why do we need target="phpmain.. in many forms? I liked previous behaviour that I could open few (or many :-) windows for ONE phpMyAdmin installation and they didn't influent each other. Now everything posted goes into one frame...
It's for the sake of the new query window. When opening multiple instances, everything entered into the window would only affect a single frame, but the desired effect would be that each query instance only affects its parent. This was discussed in a bug item, somewhen after RC1 release: #723713
With the current implementation the multiple windows should also only affect their own parents, using JS and QueryFrameJS = true.
And what's problem with no target? It will go to the same place as original was...
Hi Michal!
With the current implementation the multiple windows should also only affect their own parents, using JS and QueryFrameJS = true.
And what's problem with no target? It will go to the same place as original was...
When using no target, the results of the querywindow will be shown inside the querywindow, which isn't useful.
We could, though, try to find a way to only insert the target-Tag using JavaScript for tbl_query_box.php3.
Because you seem to be working with the files, would you like to try that implementation or should I have a go at it?
Regards, Garvin.
Hi Garvin
On 28.04.2003 17:06, Garvin Hicking wrote:
With the current implementation the multiple windows should also only affect their own parents, using JS and QueryFrameJS = true.
And what's problem with no target? It will go to the same place as original was...
When using no target, the results of the querywindow will be shown inside the querywindow, which isn't useful.
Okay, use target in querywindow, but nowhere else...
We could, though, try to find a way to only insert the target-Tag using JavaScript for tbl_query_box.php3.
I'm not much familiar with JavaScript, so I really don't know how to deal with this...
Because you seem to be working with the files, would you like to try that implementation or should I have a go at it?
I won't have time to work on phpMyAdmin till tommorow, so feel free to do that.
Hi Michal!
I won't have time to work on phpMyAdmin till tommorow, so feel free to do that.
I did some rewrites of some parts and now always use optional, differing <noscript> Tags when working with QueryFramesJS. I put them into CVS for you to play with around. As for me, the current solution is better than we currently are, so even though its only 90% tested we should expect less bugs with this solution.
Maybe you can have a look at it, I'm quite tired and done for today. ;)
Regards, Garvin.
-
Garvin Hicking -
Michal Čihař -
Michal Čihař