[Phpmyadmin-devel] Proposed changes to create_tables.sql (mainly pma_recent and pma_uiprefs)
Hi,
I was looking at create_tables.sql and spotted some places we can change to simplify this file. If possible, I would like to change these:
1) Remove all charset and collation overrides for columns which specify utf8/utf8_bin, as they already inherit that from table settings (concerns pma_recent, pma_uiprefs and pma_tracking). 2) Remove "DEFAULT CHARACTER SET utf8 COLLATE utf8_bin" for all tables, as this is default setting in 'phpmyadmin' database. Unless we think that our users have their databases incorrectly created. 3) Change BLOB to TEXT in pma_recent and pma_table_uiprefs - they store text data (JSON), not binary data.
Piotr Przybylski a écrit :
Hi,
I was looking at create_tables.sql and spotted some places we can change to simplify this file. If possible, I would like to change these:
- Remove all charset and collation overrides for columns which
specify utf8/utf8_bin, as they already inherit that from table settings (concerns pma_recent, pma_uiprefs and pma_tracking). 2) Remove "DEFAULT CHARACTER SET utf8 COLLATE utf8_bin" for all tables, as this is default setting in 'phpmyadmin' database. Unless we think that our users have their databases incorrectly created. 3) Change BLOB to TEXT in pma_recent and pma_table_uiprefs - they store text data (JSON), not binary data.
Piotr, Agreed for all this.
2011/6/1 Marc Delisle marc@infomarc.info:
Piotr Przybylski a écrit :
Hi,
I was looking at create_tables.sql and spotted some places we can change to simplify this file. If possible, I would like to change these:
- Remove all charset and collation overrides for columns which
specify utf8/utf8_bin, as they already inherit that from table settings (concerns pma_recent, pma_uiprefs and pma_tracking). 2) Remove "DEFAULT CHARACTER SET utf8 COLLATE utf8_bin" for all tables, as this is default setting in 'phpmyadmin' database. Unless we think that our users have their databases incorrectly created. 3) Change BLOB to TEXT in pma_recent and pma_table_uiprefs - they store text data (JSON), not binary data.
Piotr, Agreed for all this.
Ok, pushed to master. This allowed me for less differences between MySQL and Drizzle scripts.
Michal, can you update my demo [1] to use configuration storage in Drizzle database? SQL script is in my latest commit [2].
[1] http://demo.phpmyadmin.net/gsoc-piotr/ [2] http://repo.or.cz/w/phpmyadmin/crack.git/commit/10c7353c3ce58b5dc1bee1ac0344...
Hi
Dne Thu, 2 Jun 2011 01:16:01 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
Michal, can you update my demo [1] to use configuration storage in Drizzle database? SQL script is in my latest commit [2].
The configuration should be same for all servers, there just no automatic maintenance for Drizzle (yet) to create the phpmyadmin database (and it seems the SQL script still fails).
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 2 Jun 2011 01:16:01 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
Michal, can you update my demo [1] to use configuration storage in Drizzle database? SQL script is in my latest commit [2].
The configuration should be same for all servers, there just no automatic maintenance for Drizzle (yet) to create the phpmyadmin database (and it seems the SQL script still fails).
create_tables_drizzle.sql loads fine through both drizzle and mysql commandline clients.
Hi
Dne Thu, 2 Jun 2011 16:19:34 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Thu, 2 Jun 2011 01:16:01 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
Michal, can you update my demo [1] to use configuration storage in Drizzle database? SQL script is in my latest commit [2].
The configuration should be same for all servers, there just no automatic maintenance for Drizzle (yet) to create the phpmyadmin database (and it seems the SQL script still fails).
create_tables_drizzle.sql loads fine through both drizzle and mysql commandline clients.
Ah right, the Drizzle database is now maintained in similar way as MySQL one.
Hi
Dne Wed, 1 Jun 2011 19:39:03 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
- Remove "DEFAULT CHARACTER SET utf8 COLLATE utf8_bin" for all
tables, as this is default setting in 'phpmyadmin' database. Unless we think that our users have their databases incorrectly created.
Please avoid depending on database settings as some users might want to put phpMyAdmin tables into their database (usually the only database they can access on hosting). This is also the reason why all tables have pma_ prefix.
2011/6/2 Michal Čihař michal@cihar.com:
Hi
Dne Wed, 1 Jun 2011 19:39:03 +0200 Piotr Przybylski piotr.prz@gmail.com napsal(a):
- Remove "DEFAULT CHARACTER SET utf8 COLLATE utf8_bin" for all
tables, as this is default setting in 'phpmyadmin' database. Unless we think that our users have their databases incorrectly created.
Please avoid depending on database settings as some users might want to put phpMyAdmin tables into their database (usually the only database they can access on hosting). This is also the reason why all tables have pma_ prefix.
Table charset/collation restored. I also added it to my Drizzle version.
-
Marc Delisle -
Michal Čihař -
Piotr Przybylski