[Phpmyadmin-devel] common.js and Mootools
Hi, Now that js/update-location.js is converted to jQuery -- thanks Michal -- I believe we could remove the loading of mootools.js from index.php. Unless there is some dependency to Mootools inside js/common.js but I think not. -- Marc Delisle http://infomarc.info
Hi Dne Thu, 01 Apr 2010 11:03:00 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Now that js/update-location.js is converted to jQuery -- thanks Michal -- I believe we could remove the loading of mootools.js from index.php.
Unless there is some dependency to Mootools inside js/common.js but I think not.
Probably yes. BTW: Does anybody know where all do we use mootools? -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Hi
Dne Thu, 01 Apr 2010 11:03:00 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Now that js/update-location.js is converted to jQuery -- thanks Michal -- I believe we could remove the loading of mootools.js from index.php.
Unless there is some dependency to Mootools inside js/common.js but I think not.
Probably yes.
Yes there is a dependency?
BTW: Does anybody know where all do we use mootools?
I expect that it's only where we include it. Is it oversimplified? -- Marc Delisle http://infomarc.info
Hi Dne Thu, 01 Apr 2010 11:20:30 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Michal Čihař a écrit :
Hi
Dne Thu, 01 Apr 2010 11:03:00 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Now that js/update-location.js is converted to jQuery -- thanks Michal -- I believe we could remove the loading of mootools.js from index.php.
Unless there is some dependency to Mootools inside js/common.js but I think not.
Probably yes.
Yes there is a dependency?
Yes, we can remove it.
BTW: Does anybody know where all do we use mootools?
I expect that it's only where we include it. Is it oversimplified?
The only mootools user I found is mootools_common.js (it should be rather named replication.js), but I checked only separate js files and not inline code. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Hi Dne Thu, 1 Apr 2010 17:33:12 +0200 Michal Čihař <michal@cihar.com> napsal(a):
The only mootools user I found is mootools_common.js (it should be rather named replication.js), but I checked only separate js files and not inline code.
Ah okay, in functions.js there are some blob streaming functions which do also use mootools. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Hi
Dne Thu, 1 Apr 2010 17:33:12 +0200 Michal Čihař <michal@cihar.com> napsal(a):
The only mootools user I found is mootools_common.js (it should be rather named replication.js), but I checked only separate js files and not inline code.
Ah okay, in functions.js there are some blob streaming functions which do also use mootools.
Mootools also used in /setup. -- Marc Delisle http://infomarc.info
In infinite wisdom Michal Čihař <michal@cihar.com> wrote:
BTW: Does anybody know where all do we use mootools?
One way to find this would be to run the selenium test scripts and then grep the apache logs for mootool*.js. The referrer page in the access log should give an idea of which all pages use mootools (or include it). -- Raj Shekhar - If there's anything more important than my ego around, I want it caught and shot now. - Read the latest at my blog: "casio's g-shock watch" <http://rajshekhar.net/blog/archives/360-casios-g-shock-watch.html>
Hi Dne Thu, 01 Apr 2010 09:37:00 -0700 Raj Shekhar <rajlist@rajshekhar.net> napsal(a):
In infinite wisdom Michal Čihař <michal@cihar.com> wrote:
BTW: Does anybody know where all do we use mootools?
One way to find this would be to run the selenium test scripts and then grep the apache logs for mootool*.js. The referrer page in the access log should give an idea of which all pages use mootools (or include it).
We don't have problem finding code which references to mootools*js, but rather code which uses some of mootools functions. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Just a related issue - main.php loads jQuery two times, it's added to js_include in common.inc.php and main.php 2010/4/1 Marc Delisle <marc@infomarc.info>:
Hi, Now that js/update-location.js is converted to jQuery -- thanks Michal -- I believe we could remove the loading of mootools.js from index.php.
Unless there is some dependency to Mootools inside js/common.js but I think not.
-- Marc Delisle http://infomarc.info
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Dne Thu, 1 Apr 2010 17:08:43 +0200 Piotr Przybylski <piotr.prz@gmail.com> napsal(a):
Just a related issue - main.php loads jQuery two times, it's added to js_include in common.inc.php and main.php
It was the case in more files, fixed in Git. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Michal Čihař a écrit :
Dne Thu, 1 Apr 2010 17:08:43 +0200 Piotr Przybylski <piotr.prz@gmail.com> napsal(a):
Just a related issue - main.php loads jQuery two times, it's added to js_include in common.inc.php and main.php
It was the case in more files, fixed in Git.
Ah, I was not aware that common.inc.php now loads it. Well, this brings another question: how will we document which code depends on jQuery? or do we need to document it? -- Marc Delisle http://infomarc.info
Hi Dne Thu, 01 Apr 2010 11:28:11 -0400 Marc Delisle <marc@infomarc.info> napsal(a):
Ah, I was not aware that common.inc.php now loads it. Well, this brings another question: how will we document which code depends on jQuery? or do we need to document it?
As the location updater requires it and it is used on each page, I think it's safe to assume jQuery is always present. And it was probably mine fault, because other users were added earlier than the one in common and I should have removed it. -- Michal Čihař | http://cihar.com | http://blog.cihar.com
Piotr Przybylski a écrit :
Just a related issue - main.php loads jQuery two times, it's added to js_include in common.inc.php and main.php
Thanks I'll fix this. -- Marc Delisle http://infomarc.info
participants (4)
-
Marc Delisle -
Michal Čihař -
Piotr Przybylski -
Raj Shekhar