[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Browse ->Mutiple rows-> Change
17 Jun
2011
17 Jun
'11
7:11 a.m.
Hi Marc,
I'm planning to ajaxify the Table->Browse->Multiple rows->Changes by using
the click event for "*rowsDeleteForm*". I'm planing to add it to
"sql.js"
file. Is it okay. I'll update you soon on this.
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
17 Jun
17 Jun
9:06 a.m.
Thilanka Kaushalya a écrit :
Hi Marc,
I'm planning to ajaxify the Table->Browse->Multiple rows->Changes by
using the click event for "*rowsDeleteForm*". I'm planing to add it to
"sql.js" file. Is it okay. I'll update you soon on this.
Regards,
Thilanka.
Thilanka.
OK. Now would be the time to rename this form to something better like
resultsForm.
--
Marc Delisle
http://infomarc.info
18 Jun
18 Jun
2:24 p.m.
Hi Marc,
I pushed my first set of changes to the repo on ajaxify the
table->multi_row->change option, please check that. For that I have used
some existing events in sql.js file.
When I submit the "*#insetForm*" I used "*
$("#pageselector").trigger('change');*" for reload the
"#*resultsForm*"
table because since this is related to multiple rows and there are many
actions in "*#insertForm*" such as "*Save*" and "*add as a new
row*", it is
better to update the table.
And there are few issues with this.
1. I used "*PMA_ajaxShowMessage(PMA_messages['strNoRowSelected']);*"
to
show a message when user not selected a row and click on change. Is this
okay or should I change it.
2. When a row get changed I used following actions to reload the "#*
resultsForm*"
$("#pageselector").trigger('change');
$("#result_query").remove();
$("#sqlqueryresults").prepend(data.sql_query);
But since last two actions runs in the middle of first trigger I
cannot remove the *result_query * with the updated row message after the
table get reloaded. I cannot find why this happens. Please can you help me
on this.
Thank you.
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
8 p.m.
Le 2011-06-18 13:24, Thilanka Kaushalya a écrit :
Hi Marc,
I pushed my first set of changes to the repo on ajaxify the
table->multi_row->change option, please check that. For that I have used
some existing events in sql.js file.
When I submit the "*#insetForm*" I used
"*$("#pageselector").trigger('change');*" for reload the
"#*resultsForm*" table because since this is related to multiple rows
and there are many actions in "*#insertForm*" such as "*Save*" and
"*add
as a new row*", it is better to update the table.
And there are few issues with this.
1. I used
"*PMA_ajaxShowMessage(PMA_messages['strNoRowSelected']);*"
to show a message when user not selected a row and click on
change. Is this okay or should I change it.
Thilanka,
this is fine but please use the already existing 'No rows selected'
message, it's better to reuse messages to avoid too much work for our
translators.
2. When a row get changed I used following actions
to reload the
"#*resultsForm*"
$("#pageselector").trigger('change');
$("#result_query").remove();
$("#sqlqueryresults").prepend(data.sql_query);
But since last two actions runs in the middle of first
trigger I cannot remove the *result_query * with the updated row message
after the table get reloaded. I cannot find why this happens. Please can
you help me on this.
I'm not sure I understand your question. In my test, the original
result_query div has been removed (it contained a SELECT) then with the
.prepend() it reappears with the UPDATE queries. The only problem I see
is an empty div with class notice at the beginning of the result_query div.
Maybe I did not test the same way you did.
Thank you.
Regards,
Thilanka.
Also, the first time the "Change table" panel is displayed, I see many
notices of undefined variable submit_mult at the bottom of the panel.
--
Marc Delisle
http://infomarc.info
19 Jun
19 Jun
2:18 a.m.
Hi Marc,
On Sun, Jun 19, 2011 at 4:30 AM, Marc Delisle <marc(a)infomarc.info> wrote:
Yes. I fixed it with by removing the .notice and replace it with success
message.
I fixed it.
I pushed my code to the repo and please check that out. I'll update you soon
on "*ajaxify Expot*" task. Thank you.
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
Le 2011-06-18 13:24, Thilanka Kaushalya a écrit :
Okay. I changed it to "*$js_messages['strNoRowSelected'] = __('No
rows
selected');*"
Hi Marc,
I pushed my first set of changes to the repo on ajaxify the
table->multi_row->change option, please check that. For that I have used
some existing events in sql.js file.
When I submit the "*#insetForm*" I used
"*$("#pageselector").trigger('change');*" for reload the
"#*resultsForm*" table because since this is related to multiple rows
and there are many actions in "*#insertForm*" such as "*Save*" and
"*add
as a new row*", it is better to update the table.
And there are few issues with this.
1. I used
"*PMA_ajaxShowMessage(PMA_messages['strNoRowSelected']);*"
to show a message when user not selected a row and click on
change. Is this okay or should I change it.
Thilanka,
this is fine but please use the already existing 'No rows selected'
message, it's better to reuse messages to avoid too much work for our
translators.
2. When a
row get changed I used following actions to reload the
"#*resultsForm*"
$("#pageselector").trigger('change');
$("#result_query").remove();
$("#sqlqueryresults").prepend(data.sql_query);
But since last two actions runs in the middle of first
trigger I cannot remove the *result_query * with the updated row message
after the table get reloaded. I cannot find why this happens. Please can
you help me on this.
I'm not sure I understand your question. In my test, the original
result_query div has been removed (it contained a SELECT) then with the
.prepend() it reappears with the UPDATE queries. The only problem I see
is an empty div with class notice at the beginning of the result_query div.
Maybe I did not test the same way you did.
Thank you.
Regards,
Thilanka.
Also, the first time the "Change table" panel is displayed, I see many
notices of undefined variable submit_mult at the bottom of the panel.
8:39 a.m.
Le 2011-06-19 01:18, Thilanka Kaushalya a écrit :
(...)
I pushed my code to the repo and please check that
out. I'll update you soon
on "*ajaxify Expot*" task. Thank you.
Regards,
Thilanka.
Thilanka,
still a few issues:
1. If I'm browsing in vertical mode, the new feature does not work (I
get "No rows selected").
2. In js/sql.js, instead of "if(" please use "if (".
3. Instead of introducing a new message "Change Table", please use the
already existing "Change".
--
Marc Delisle
http://infomarc.info
2:55 p.m.
Hi Marc,
Thanks for testing the modification.
1. If I'm browsing in vertical mode, the new feature does not work (I
get "No rows selected").
2. In js/sql.js, instead of "if(" please use "if (".
3. Instead of introducing a new message "Change Table", please use the
already existing "Change".
I fixed those issues and pushed my changes to the repo. Please check those.
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
20 Jun
20 Jun
9:08 a.m.
Thilanka Kaushalya a écrit :
Hi Marc,
Thanks for testing the modification.
1. If I'm browsing in vertical mode, the new feature does not work (I
get "No rows selected").
2. In js/sql.js, instead of "if(" please use "if (".
3. Instead of introducing a new message "Change Table", please use the
already existing "Change".
I fixed those issues and pushed my changes to the repo. Please check those.
Regards,
Thilanka.
Great. Feature merged to origin/master.
--
Marc Delisle
http://infomarc.info
3:29 p.m.
Hi Marc,
On Mon, Jun 20, 2011 at 5:38 PM, Marc Delisle <marc(a)infomarc.info> wrote:
Thilanka Kaushalya a écrit :
I published the blog post[1] on my work done in 4th week. Sorry for the
delay of submitting it and next time 'll put it on Sunday.
[1] -
http://coders-view.blogspot.com/2011/06/ajaxify-phpmyadmin-interface-gsoc-2…
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
Hi Marc,
Thanks for testing the modification.
1. If I'm browsing in vertical mode, the new feature does not work (I
get "No rows selected").
2. In js/sql.js, instead of "if(" please use "if (".
3. Instead of introducing a new message "Change Table", please use
the
already existing "Change".
I fixed those issues and pushed my changes to the repo. Please check
those.
Regards,
Thilanka.
Great. Feature merged to origin/master.
4:36 p.m.
On Mon, 2011-06-20 at 23:59 +0530, Thilanka Kaushalya wrote:
Hi Marc,
On Mon, Jun 20, 2011 at 5:38 PM, Marc Delisle <marc(a)infomarc.info> wrote:
I had a quick look at the functionality that you worked on and I noticed
that the font in the dialog is bigger than in the actual page behind.
I'm not sure why this is happening, but I this was happening in my code
as well. To fix this I specified a smaller font-size when creating the
AJAX dialog. For example:
$ajaxDialog = $('<div style="font-size: 0.9em;">'+data.message
+'</div>').dialog({ /* options go here */ });
Bye,
Rouslan
Thilanka Kaushalya a écrit :
I published the blog post[1] on my work done in 4th week. Sorry for the
delay of submitting it and next time 'll put it on Sunday.
[1] -
http://coders-view.blogspot.com/2011/06/ajaxify-phpmyadmin-interface-gsoc-2…
Hi Marc,
Thanks for testing the modification.
1. If I'm browsing in vertical mode, the new feature does not work (I
get "No rows selected").
2. In js/sql.js, instead of "if(" please use "if (".
3. Instead of introducing a new message "Change Table", please use
the
already existing "Change".
I fixed those issues and pushed my changes to the repo. Please check
those.
Regards,
Thilanka.
Great. Feature merged to origin/master.
21 Jun
21 Jun
6:19 a.m.
On Mon, 2011-06-20 at 20:36 +0100, Rouslan Placella wrote:
On Mon, 2011-06-20 at 23:59 +0530, Thilanka Kaushalya
wrote:
I also noticed that the "Create table" button in the navigation frame
does not a show a "Loading" ajax message when clicked, like the one seen
if you create table from database structure tab.
Rouslan
Hi Marc,
On Mon, Jun 20, 2011 at 5:38 PM, Marc Delisle <marc(a)infomarc.info> wrote:
I had a quick look at the functionality that you worked on and I noticed
that the font in the dialog is bigger than in the actual page behind.
I'm not sure why this is happening, but I this was happening in my code
as well. To fix this I specified a smaller font-size when creating the
AJAX dialog. For example:
$ajaxDialog = $('<div style="font-size: 0.9em;">'+data.message
+'</div>').dialog({ /* options go here */ });
Bye,
Rouslan Thilanka Kaushalya a écrit :
I published the blog post[1] on my work done in 4th week. Sorry for the
delay of submitting it and next time 'll put it on Sunday.
[1] -
http://coders-view.blogspot.com/2011/06/ajaxify-phpmyadmin-interface-gsoc-2…
Hi Marc,
Thanks for testing the modification.
1. If I'm browsing in vertical mode, the new feature does not work (I
get "No rows selected").
2. In js/sql.js, instead of "if(" please use "if (".
3. Instead of introducing a new message "Change Table", please use
the
already existing "Change".
I fixed those issues and pushed my changes to the repo. Please check
those.
Regards,
Thilanka.
Great. Feature merged to origin/master.
12:09 p.m.
Hi Rouslan,
I also noticed that the "Create table"
button in the navigation frame
does not a show a "Loading" ajax message when clicked, like the one seen
if you create table from database structure tab.
Thanks for testing and reporting this problem and I'll fix it as soon as
possible.
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
12:06 p.m.
Hi Rouslan and Marc,
I had a quick look at the functionality that you
worked on and I noticed
that the font in the dialog is bigger than in the actual page behind.
I'm not sure why this is happening, but I this was happening in my code
as well. To fix this I specified a smaller font-size when creating the
AJAX dialog. For example:
$ajaxDialog = $('<div style="font-size: 0.9em;">'+data.message
+'</div>').dialog({ /* options go here */ });
Thanks for your suggestion. But I'm not sure whether it is good to have
inline styles in PMA because it makes difficult to maintain them in the
future.
If it id okay to do inline style, I'll fix that. I think Marc can comment on
this problem.
Regards,
Thilanka.
--
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka
Connect with me at,
Gmail : lgtkaushalya(a)gmail.com
Twitter : @thilanka_k
Facebook : Thilanka Kaushalya
Yahoo : lgtkaushalya(a)yahoo.com
Blog : http://coders-view.blogspot.com/
12:51 p.m.
Thilanka Kaushalya a écrit :
Hi Rouslan and Marc,
I had a quick look at the functionality that you worked on and I noticed
that the font in the dialog is bigger than in the actual page behind.
I'm not sure why this is happening, but I this was happening in my code
as well. To fix this I specified a smaller font-size when creating the
AJAX dialog. For example:
$ajaxDialog = $('<div style="font-size:
0.9em;">'+data.message
+'</div>').dialog({ /* options go here */ });
Thanks for your suggestion. But I'm not sure whether it is good to have
inline styles in PMA because it makes difficult to maintain them in the
future.
If it id okay to do inline style, I'll fix that. I think Marc
can comment on this problem.
Indeed, styling should normally go in each theme's CSS; but in jQuery
you can use some class in the generated div and define this in the CSS
for the two included themes.
--
Marc Delisle
http://infomarc.info
22 Jun
22 Jun
3:43 p.m.
On Tue, 2011-06-21 at 11:51 -0400, Marc Delisle wrote:
Thilanka Kaushalya a écrit :
I guess that the best would be to figure out why jQuery is using the
wrong font-size in the first place though :)
Rouslan
Hi Rouslan and Marc,
I had a quick look at the functionality that you worked on and I noticed
that the font in the dialog is bigger than in the actual page behind.
I'm not sure why this is happening, but I this was happening in my code
as well. To fix this I specified a smaller font-size when creating the
AJAX dialog. For example:
$ajaxDialog = $('<div style="font-size:
0.9em;">'+data.message
+'</div>').dialog({ /* options go here */ });
Thanks for your suggestion. But I'm not sure whether it is good to have
inline styles in PMA because it makes difficult to maintain them in the
future.
If it id okay to do inline style, I'll fix that. I think Marc
can comment on this problem.
Indeed, styling should normally go in each theme's CSS; but in jQuery
you can use some class in the generated div and define this in the CSS
for the two included themes.
3:52 p.m.
On Wed, 2011-06-22 at 19:43 +0100, Rouslan Placella wrote:
On Tue, 2011-06-21 at 11:51 -0400, Marc Delisle
wrote:
It looks like it's line 50 from 'jquery-ui-1.8.custom.css' that causes
this issue:
---SNIP---
.ui-widget { font-family: Verdana,Arial,sans-serif; font-size: 1.1em; }
---SNIP---
That font-size should be '1em'. Although I wonder if there would be any
side-effects...
Rouslan
Thilanka Kaushalya a écrit :
I guess that the best would be to figure out why jQuery is using the
wrong font-size in the first place though :)
Rouslan Hi Rouslan and Marc,
I had a quick look at the functionality that you worked on and I noticed
that the font in the dialog is bigger than in the actual page behind.
I'm not sure why this is happening, but I this was happening in my code
as well. To fix this I specified a smaller font-size when creating the
AJAX dialog. For example:
$ajaxDialog = $('<div style="font-size:
0.9em;">'+data.message
+'</div>').dialog({ /* options go here */ });
Thanks for your suggestion. But I'm not sure whether it is good to have
inline styles in PMA because it makes difficult to maintain them in the
future.
If it id okay to do inline style, I'll fix that. I think Marc
can comment on this problem.
Indeed, styling should normally go in each theme's CSS; but in jQuery
you can use some class in the generated div and define this in the CSS
for the two included themes.
4826
days inactive
4831
days old
15 comments
3 participants
participants (3)
-
Marc Delisle -
Rouslan Placella -
Thilanka Kaushalya