
Hi Jason, I could not find the exact commit, but it seems that the introduction of StructureController caused a problem. To reproduce, display the structure of a database, tick the checkbox for one of the tables, and in the drop-down "With selected" menu, try to optimize this table. Notice in ./libraries/mult_submits.inc.php#254 Undefined variable: pmaThemeImage Backtrace ./libraries/controllers/StructureController.class.php#139: include(./libraries/mult_submits.inc.php) ./db_structure.php#45: PMA\Controllers\StructureController->indexAction() -- Marc Delisle | phpMyAdmin

Hi, I noticed this problem, and it cause by incorrect scope of the variable. The $pmaImageTheme is a global variable, which means it can be access globally. But in this case the mult_submits.inc.php was included in the scope of StructureController, where the script can’t access global variables correctly. After declaring global of the $pmaImageTheme in the mult_submits.inc.php, the problem should be fixed. Best regards, Jason On Thu, Aug 6, 2015 at 4:40 AM Marc Delisle <marc@infomarc.info> wrote:
Hi Jason,
I could not find the exact commit, but it seems that the introduction of StructureController caused a problem.
To reproduce, display the structure of a database, tick the checkbox for one of the tables, and in the drop-down "With selected" menu, try to optimize this table.
Notice in ./libraries/mult_submits.inc.php#254 Undefined variable: pmaThemeImage
Backtrace
./libraries/controllers/StructureController.class.php#139: include(./libraries/mult_submits.inc.php) ./db_structure.php#45: PMA\Controllers\StructureController->indexAction()
-- Marc Delisle | phpMyAdmin
_______________________________________________ Developers mailing list Developers@phpmyadmin.net http://lists.phpmyadmin.net/mailman/listinfo/developers

Le 2015-08-06 22:16, 章浩 a écrit :
Hi,
I noticed this problem, and it cause by incorrect scope of the variable. The $pmaImageTheme is a global variable, which means it can be access globally. But in this case the mult_submits.inc.php was included in the scope of StructureController, where the script can’t access global variables correctly. After declaring global of the $pmaImageTheme in the mult_submits.inc.php, the problem should be fixed.
Thanks!
Best regards, Jason
On Thu, Aug 6, 2015 at 4:40 AM Marc Delisle <marc@infomarc.info <mailto:marc@infomarc.info>> wrote:
Hi Jason,
I could not find the exact commit, but it seems that the introduction of StructureController caused a problem.
To reproduce, display the structure of a database, tick the checkbox for one of the tables, and in the drop-down "With selected" menu, try to optimize this table.
Notice in ./libraries/mult_submits.inc.php#254 Undefined variable: pmaThemeImage
Backtrace
./libraries/controllers/StructureController.class.php#139: include(./libraries/mult_submits.inc.php) ./db_structure.php#45: PMA\Controllers\StructureController->indexAction()
-- Marc Delisle | phpMyAdmin
_______________________________________________ Developers mailing list Developers@phpmyadmin.net <mailto:Developers@phpmyadmin.net> http://lists.phpmyadmin.net/mailman/listinfo/developers
_______________________________________________ Developers mailing list Developers@phpmyadmin.net http://lists.phpmyadmin.net/mailman/listinfo/developers
-- Marc Delisle | phpMyAdmin
participants (2)
-
Marc Delisle
-
章浩