Re: [Phpmyadmin-devel] [phpmyadmin] add test getFontsizeOptions for "em", "Pt", "px" unit (#390)
20 May
2013
20 May
'13
6:20 a.m.
Hi Marc,
About the test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link
http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5)
$HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS.
my case, there is $_COOKIE['pma_fontsize'] = "10em"; which is not
working in your side for Cookie setting.
Hi Adam,
I am running phpunit 3.6.10 on Linux, and when I type
```
phpunit
```
I get this error. Maybe my version of phpunit is too old?
---
Reply to this email directly or view it on GitHub:
https://github.com/phpmyadmin/phpmyadmin/pull/390#issuecomment-18075456
Thanks,
Adam
20 May
20 May
2:51 p.m.
New subject: [Phpmyadmin-devel] [phpmyadmin] add test getFontsizeOptions for "em", "Pt", "px" unit (#390)
adam a écrit :
Hi Marc,
About the test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link
http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5)
$HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS.
I am using PHP 5.3.25 on this server.
my case, there is $_COOKIE['pma_fontsize'] = "10em"; which is not
working in your side for Cookie setting.
--
Marc Delisle
http://infomarc.info
Hi Adam,
I am running phpunit 3.6.10 on Linux, and when I type
```
phpunit
```
I get this error. Maybe my version of phpunit is too old?
---
Reply to this email directly or view it on GitHub:
https://github.com/phpmyadmin/phpmyadmin/pull/390#issuecomment-18075456
Thanks,
Adam
3:32 p.m.
New subject: [Phpmyadmin-devel] [phpmyadmin] add test getFontsizeOptions for "em", "Pt", "px" unit (#390)
Hi Marc,
Is errors still existed when using PHP 5.3.25?
the travis build is working for PHP 5.3 5.4 5.5:
https://travis-ci.org/phpmyadmin/phpmyadmin/builds/7193718
Job Duration Finished Php
2356.1 1 min 8 sec 4 days ago 5.5
2356.2 1 min 12 sec 4 days ago 5.4
2356.3 1 min 22 sec 4 days ago 5.3
Adam
About the test
case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link
http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5)
$HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS.
I am using PHP 5.3.25 on this server.
3:37 p.m.
New subject: [Phpmyadmin-devel] [phpmyadmin] add test getFontsizeOptions for "em", "Pt", "px" unit (#390)
adam a écrit :
Hi Marc,
Is errors still existed when using PHP 5.3.25?
Yes. Which phpunit version are you using? Mine is 3.6.10.
--
Marc Delisle
http://infomarc.info
About the
test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link
http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5)
$HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS.
I am using
PHP 5.3.25 on this server.
4:16 p.m.
New subject: [Phpmyadmin-devel] [phpmyadmin] add test getFontsizeOptions for "em", "Pt", "px" unit (#390)
Hi Marc,
adam a écrit :
I agree with Michal that it is due to fontsize setting,
https://github.com/phpmyadmin/phpmyadmin/pull/390#issuecomment-18144602
by Michal:
Adam, I guess the problem is that
$GLOBALS['PMA_Config']->get('fontsize') returns something here. Older
phpunit might have changed ordering of the tests so that $GLOBALS['PMA_Config'] is
different than what you expect (what can happen unless you explicitly set it in test).
I sent a new pull request here which to make font size setting empty,
https://github.com/phpmyadmin/phpmyadmin/pull/397
can you have a try, thanks
Sorry for the inconvinence.
Adam
Hi Marc,
Is errors still existed when using PHP 5.3.25?
Yes. Which phpunit version are you using? Mine is 3.6.10.
About the
test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link
http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5)
$HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS.
I am using PHP 5.3.25 on this server.
5:29 p.m.
New subject: [Phpmyadmin-devel] [phpmyadmin] add test getFontsizeOptions for "em", "Pt", "px" unit (#390)
adam a écrit :
Hi Marc,
Hi Adam,
your pull request fixed my problem and I have merged it, thanks.
--
Marc Delisle
http://infomarc.info
adam a écrit :
I agree with Michal that it is due to fontsize setting,
https://github.com/phpmyadmin/phpmyadmin/pull/390#issuecomment-18144602
by Michal:
Adam, I guess the problem is that
$GLOBALS['PMA_Config']->get('fontsize') returns something here. Older
phpunit might have changed ordering of the tests so that $GLOBALS['PMA_Config'] is
different than what you expect (what can happen unless you explicitly set it in test).
I sent a new pull request here which to make font size setting empty,
https://github.com/phpmyadmin/phpmyadmin/pull/397
can you have a try, thanks
Sorry for the inconvinence. Hi Marc,
Yes. Which phpunit version are you
using? Mine is 3.6.10. > About the test case,
https://github.com/phpmyadmin/phpmyadmin/pull/390
>
> I think I find the reason. Refer to the link
http://php.net/manual/en/reserved.variables.cookies.php
>
> $_COOKIE (PHP 4 >= 4.1.0, PHP 5)
> $HTTP_COOKIE_VARS [deprecated]
>
> So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS.
I am using PHP 5.3.25 on this server.
Is errors still existed when using PHP 5.3.25?
4141
days inactive
4141
days old
5 comments
2 participants
participants (2)
-
adam -
Marc Delisle