Re: [Phpmyadmin-devel] [phpmyadmin] add test getFontsizeOptions for "em", "Pt", "px" unit (#390)
Hi Marc, About the test case, https://github.com/phpmyadmin/phpmyadmin/pull/390 I think I find the reason. Refer to the link http://php.net/manual/en/reserved.variables.cookies.php $_COOKIE (PHP 4 >= 4.1.0, PHP 5) $HTTP_COOKIE_VARS [deprecated] So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS. my case, there is $_COOKIE['pma_fontsize'] = "10em"; which is not working in your side for Cookie setting.
Hi Adam, I am running phpunit 3.6.10 on Linux, and when I type ``` phpunit ``` I get this error. Maybe my version of phpunit is too old?
--- Reply to this email directly or view it on GitHub: https://github.com/phpmyadmin/phpmyadmin/pull/390#issuecomment-18075456
Thanks, Adam
adam a écrit :
Hi Marc,
About the test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5) $HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS.
I am using PHP 5.3.25 on this server.
my case, there is $_COOKIE['pma_fontsize'] = "10em"; which is not working in your side for Cookie setting.
Hi Adam, I am running phpunit 3.6.10 on Linux, and when I type ``` phpunit ``` I get this error. Maybe my version of phpunit is too old?
--- Reply to this email directly or view it on GitHub: https://github.com/phpmyadmin/phpmyadmin/pull/390#issuecomment-18075456
Thanks, Adam
-- Marc Delisle http://infomarc.info
Hi Marc,
About the test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5) $HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS.
I am using PHP 5.3.25 on this server.
Is errors still existed when using PHP 5.3.25? the travis build is working for PHP 5.3 5.4 5.5: https://travis-ci.org/phpmyadmin/phpmyadmin/builds/7193718 Job Duration Finished Php 2356.1 1 min 8 sec 4 days ago 5.5 2356.2 1 min 12 sec 4 days ago 5.4 2356.3 1 min 22 sec 4 days ago 5.3 Adam
adam a écrit :
Hi Marc,
About the test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5) $HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS. I am using PHP 5.3.25 on this server.
Is errors still existed when using PHP 5.3.25?
Yes. Which phpunit version are you using? Mine is 3.6.10. -- Marc Delisle http://infomarc.info
Hi Marc,
adam a écrit :
Hi Marc,
About the test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5) $HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS. I am using PHP 5.3.25 on this server.
Is errors still existed when using PHP 5.3.25?
Yes. Which phpunit version are you using? Mine is 3.6.10.
I agree with Michal that it is due to fontsize setting, https://github.com/phpmyadmin/phpmyadmin/pull/390#issuecomment-18144602 by Michal: Adam, I guess the problem is that $GLOBALS['PMA_Config']->get('fontsize') returns something here. Older phpunit might have changed ordering of the tests so that $GLOBALS['PMA_Config'] is different than what you expect (what can happen unless you explicitly set it in test). I sent a new pull request here which to make font size setting empty, https://github.com/phpmyadmin/phpmyadmin/pull/397 can you have a try, thanks Sorry for the inconvinence. Adam
adam a écrit :
Hi Marc,
adam a écrit :
Hi Marc,
About the test case, https://github.com/phpmyadmin/phpmyadmin/pull/390
I think I find the reason. Refer to the link http://php.net/manual/en/reserved.variables.cookies.php
$_COOKIE (PHP 4 >= 4.1.0, PHP 5) $HTTP_COOKIE_VARS [deprecated]
So PHP 4.1.0, Introduced $_COOKIE that deprecated $HTTP_COOKIE_VARS. I am using PHP 5.3.25 on this server.
Is errors still existed when using PHP 5.3.25? Yes. Which phpunit version are you using? Mine is 3.6.10.
I agree with Michal that it is due to fontsize setting, https://github.com/phpmyadmin/phpmyadmin/pull/390#issuecomment-18144602 by Michal: Adam, I guess the problem is that $GLOBALS['PMA_Config']->get('fontsize') returns something here. Older phpunit might have changed ordering of the tests so that $GLOBALS['PMA_Config'] is different than what you expect (what can happen unless you explicitly set it in test).
I sent a new pull request here which to make font size setting empty, https://github.com/phpmyadmin/phpmyadmin/pull/397 can you have a try, thanks Sorry for the inconvinence.
Hi Adam, your pull request fixed my problem and I have merged it, thanks. -- Marc Delisle http://infomarc.info
participants (2)
-
adam -
Marc Delisle