[Phpmyadmin-devel] GSoC 2009 - tracking mechanism for PhpMyAdmin (Mid Term Evaluation)

Hi all, I finished my part for Googles mid term evaluation. Please feel free to try out my code, you will find it as attachment. KEY ACCOMPLISHMENTS LAST WEEKS ============================== Finished following functionalities: - Tables can be tracked by mechanism now - System logs data definition and data manipulation statements: INSERT, UDATE, DELETE, TRUNCATE, ALTER TABLE, RENAME TABLE - Tracking can be activated for a subset of these commands - Tables with active tracking are marked with an "eye" icon. - Simple versioning system. User can create new tracking versions. - Deactivation and Reactivation of tracking jobs is possible. - Simple schema (structure) snapshot, uses SHOW FULL COLUMNS FROM and SHOW INDEX FROM - When user is selecting a tracked table, a notice will printed out - Switching between tables within a database is possible - Tracking report is available. Contains dates and statements. - Simple export form added, it can be used for undo action. (structure only|data only|both) -> (SQL dump|SQL execution) - Date_from - Date_to range selection for exports added. KEY CONCERNS ============ I want to teach the tracker more SQL statements: ALTER VIEW, CREATE INDEX, DROP INDEX Tracker should handle whole databases. TASKS IN THE UPCOMING WEEK(S) ============================= - Evaluate your feedback to my PMA_Tracker - Localize english-only strings - Add more export possibilities - Snapshot comparison would be fine - Prettify some layout elements I hope you are happy about the new Tracker, please send me your feedback. I need it for a successful progress. Thank you very much and my best regards Alexander Rutkowski

Hi Installed on the demo: http://demo.phpmyadmin.net/gsoc-alex/ Again (as others) it emits lot of warnings: Notice in ./libraries/Tracker.class.php#107 Undefined offset: 0 Backtrace ./libraries/tbl_links.inc.php#130: PMA_Tracker::isTracked( string menagerie, string event, ) ./sql.php#589: require(./libraries/tbl_links.inc.php) On tracking page even more: Notice in ./libraries/Tracker.class.php#107 Undefined offset: 0 Backtrace ./libraries/tbl_links.inc.php#130: PMA_Tracker::isTracked( string phpmyadmin, string pma_tracking, ) ./tbl_tracking.php#43: require_once(./libraries/tbl_links.inc.php) Notice in ./tbl_tracking.php#94 Undefined index: submit_deactivate_now Backtrace Notice in ./tbl_tracking.php#104 Undefined index: submit_activate_now Backtrace Notice in ./tbl_tracking.php#114 Undefined index: export_report Backtrace Notice in ./tbl_tracking.php#194 Undefined index: snapshot Backtrace Notice in ./tbl_tracking.php#221 Undefined index: report Backtrace Notice in ./tbl_tracking.php#221 Undefined index: export_report Backtrace -- Michal Čihař | http://cihar.com | http://blog.cihar.com

Hi Dne Sun, 12 Jul 2009 21:10:34 +0200 Alexander Rutkowski <alexander.rutkowski@googlemail.com> napsal(a):
I hope you are happy about the new Tracker, please send me your feedback. I need it for a successful progress.
Comments on patch: - Do not mess up end of lines. - Does the tracker need to create copy of configuration (pma_db, pma_table)? - You don't need to change active database before all your queries, just use full table name. - You should use control user connection for all operations in pma_db (PMA_query_as_controluser). - You should use sql parser rather than creating own way to detect statement types. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

Michal Čihař schrieb:
Comments on patch:
- Do not mess up end of lines.
Sorry but I'm not sure what you mean. Do you mean the length of my code lines or the CR char '\n' I used ? Perhaps someone else can give me hint because Michal is in vacation. Thanks a lot Alex

Hi Dne Fri, 17 Jul 2009 22:33:25 +0200 Alexander Rutkowski <alexander.rutkowski@googlemail.com> napsal(a):
Michal Čihař schrieb:
Comments on patch:
- Do not mess up end of lines.
Sorry but I'm not sure what you mean. Do you mean the length of my code lines or the CR char '\n' I used ?
All our files have unix end of lines, while lines you added have dos end of lines.
Perhaps someone else can give me hint because Michal is in vacation.
Not yet, leaving tomorrow ;-). -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz
participants (2)
-
Alexander Rutkowski
-
Michal Čihař