Hi, I was going through the codes and at many places I found use of *count() *inside the *for* statement. I think statements like
*for($i = 0; $i < count($arr); $i++)* should be converted with statements like
*$len = count($arr);* *for($i = 0; $i < $len; $i++)*
this would help us speed up the whole phpMyAdmin system.
Regards, Minhaz cistoner.org
Probably I was wrong here .... There hasn't been much use of this style. My bad :/
Hi,
2014-02-14 23:21 GMT+01:00 Minhaz A V minhazav@gmail.com:
Hi, I was going through the codes and at many places I found use of *count() *inside the *for* statement. I think statements like
*for($i = 0; $i < count($arr); $i++)* should be converted with statements like
*$len = count($arr);* *for($i = 0; $i < $len; $i++)*
this would help us speed up the whole phpMyAdmin system.
You're right. The second write is better. But as you said in your second mail, we try to avoid the first syntax. If you find the use of count into a loop, please fix it a send a pull request.
Thanks, Hugues.
Regards, Minhaz cistoner.org
Hi, Do I have to add it to bug tracker first or I can directly send the pull request!
Minhaz cistoner.org
On Sun, Feb 16, 2014 at 8:55 PM, Hugues Peccatte hugues.peccatte@gmail.comwrote:
Hi,
2014-02-14 23:21 GMT+01:00 Minhaz A V minhazav@gmail.com:
Hi,
I was going through the codes and at many places I found use of *count() *inside the *for* statement. I think statements like
*for($i = 0; $i < count($arr); $i++)* should be converted with statements like
*$len = count($arr);* *for($i = 0; $i < $len; $i++)*
this would help us speed up the whole phpMyAdmin system.
You're right. The second write is better. But as you said in your second mail, we try to avoid the first syntax. If you find the use of count into a loop, please fix it a send a pull request.
Thanks, Hugues.
Regards, Minhaz cistoner.org
Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.cl... _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Minhaz A V a écrit :
Hi, Do I have to add it to bug tracker first or I can directly send the pull request!
Hi, (Please use bottom-posting on this list).
This is not a bug, it's a speed improvement.
Minhaz cistoner.org
On Sun, Feb 16, 2014 at 8:55 PM, Hugues Peccatte hugues.peccatte@gmail.comwrote:
Hi,
2014-02-14 23:21 GMT+01:00 Minhaz A V minhazav@gmail.com:
Hi,
I was going through the codes and at many places I found use of *count() *inside the *for* statement. I think statements like
*for($i = 0; $i < count($arr); $i++)* should be converted with statements like
*$len = count($arr);* *for($i = 0; $i < $len; $i++)*
this would help us speed up the whole phpMyAdmin system.
You're right. The second write is better. But as you said in your second mail, we try to avoid the first syntax. If you find the use of count into a loop, please fix it a send a pull request.
Thanks, Hugues.
Hi,
2014-02-17 13:56 GMT+01:00 Marc Delisle marc@infomarc.info:
Minhaz A V a écrit :
Hi, Do I have to add it to bug tracker first or I can directly send the pull request!
Hi, (Please use bottom-posting on this list).
This is not a bug, it's a speed improvement.
I would add: don't forget to sign your commit with the -s option.
Minhaz cistoner.org
On Sun, Feb 16, 2014 at 8:55 PM, Hugues Peccatte hugues.peccatte@gmail.comwrote:
Hi,
2014-02-14 23:21 GMT+01:00 Minhaz A V minhazav@gmail.com:
Hi,
I was going through the codes and at many places I found use of
*count()
*inside the *for* statement. I think statements like
*for($i = 0; $i < count($arr); $i++)* should be converted with statements like
*$len = count($arr);* *for($i = 0; $i < $len; $i++)*
this would help us speed up the whole phpMyAdmin system.
You're right. The second write is better. But as you said in your second mail, we try to avoid the first syntax. If you find the use of count into a loop, please fix it a send a pull request.
Thanks, Hugues.
-- Marc Delisle http://infomarc.info | http://phpmyadmin.net
Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.cl... _______________________________________________ Phpmyadmin-devel mailing list Phpmyadmin-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
Hugues.
-
Hugues Peccatte -
Marc Delisle -
Minhaz A V