June 2013 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] AJAX error reporting system (catching errors)
by Mohamed Ashraf 26 Jun '13

26 Jun '13

I was researching about how to catch errors in javascript. I faced a problem. due to the way javascript works for a try block to catch an error it has to be within the context of execution which means in the following code: try { function f(){ throw new Error() } } catch (e) {} calling f(); the error will not be caught in the try block. essentially what this means is that if we need to catch the errors using try and catch blocks we need to wrap the inside of every function with a try block. I am not sure how feasible is this idea but it I am sure it would reduce code readability. The other option is using window.onerror which allows you to hook a function that gets executed whenever an uncaught exception occurs. This is obviously much simpler and less invasive and has an upside that errors in any context anywhere will still be reported to the hooked function. But there is a catch. which is that window.onerror does not provide a stacktrace because it is executed in a different context from the error itself. what it has access to is the line number, file name and exception message. so my question is which method should I use, the surrounding all functions by try blocks or using the window.onerror callback method? how important is the stacktrace?

3 21

[Phpmyadmin-devel] Drizzle demo server
by Isaac Bennetch 26 Jun '13

26 Jun '13

Hi, I'm seeing some oddities in the demo server when using the Drizzle backend. I'm not sure if these are problems with phpMyAdmin, shortcomings of Drizzle itself, or inconsistencies due to user error (though I think I've waited long enough for the server to reset). So I wanted to get a second opinion before opening tickets. 1) There is no Users tab displayed on the main page 2) Clicking the + button to expand the navigation tree has no effect

3 2

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3724
by michal＠cihar.com 25 Jun '13

25 Jun '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3724/changes> Changes: [Supun Chathuranga Nakandala] gis_visualization.lib.php renamed as tbl_gis_visualization.lib.php. PMA_getHtmlForGisVisualization, PMA_getHtmlForOptionsList methods added to the tbl_gis_visualization.lib.php [Supun Chathuranga Nakandala] added methods PMA_getHtmlForColumn and PMA_getHtmlForUseOpenStreetMaps ------------------------------------------ Started by GitHub push by lem9 Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@2a29052b Using strategy: Default Last Built Revision: Revision bcc9a2e3133ab6d2e2066852a5583e8f0c812b2f (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision ba390cdf02e393c045dd65e31473a27a4fe3acf3 (origin/master) Checking out Revision ba390cdf02e393c045dd65e31473a27a4fe3acf3 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson6885668951842520618.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] Not supported query: SHOW GRANTS [exec] PHP Warning: require_once(libraries/gis_visualization.lib.php): failed to open stream: No such file or directory in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_GI…> on line 14 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] PHP Fatal error: require_once(): Failed opening required 'libraries/gis_visualization.lib.php' (include_path='.:/usr/share/php:/usr/share/pear:') in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_GI…> on line 14 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] Result: 255 phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 20 exact clones with 425 duplicated lines in 23 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-138 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2778-2784 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:140-257 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:145-262 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-215 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1871-1878 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:205-211 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:341-347 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:597-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:615-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-955 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:924-962 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-961 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:796-840 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:453-460 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:654-682 [exec] [exec] 0.29% duplicated lines out of 144400 total lines of code. [exec] [exec] Time: 8 seconds, Memory: 126.00Mb [exec] Result: 1 phpcs: [exec] Time: 01:32, Memory: 59.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 411 [exec] [exec] Lines of Code (LOC): 144400 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 45134 [exec] Non-Comment Lines of Code (NCLOC): 99266 [exec] [exec] Namespaces: 0 [exec] Interfaces: 3 [exec] Traits: 0 [exec] Classes: 204 [exec] Abstract: 26 (12.75%) [exec] Concrete: 178 (87.25%) [exec] Average Class Length (NCLOC): 222 [exec] Methods: 1750 [exec] Scope: [exec] Non-Static: 1467 (83.83%) [exec] Static: 283 (16.17%) [exec] Visibility: [exec] Public: 1356 (77.49%) [exec] Non-Public: 394 (22.51%) [exec] Average Method Length (NCLOC): 25 [exec] Cyclomatic Complexity / Number of Methods: 4.22 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 629 [exec] [exec] Constants: 168 [exec] Global constants: 108 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 1 minute 50 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2871 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3723 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 38 warnings. [DRY] Computing warning deltas based on reference build #3723 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 605 files to scan for tasks [TASKS] Found 197 open tasks. [TASKS] Computing warning deltas based on reference build #3723 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3723 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.x (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 0

Re: [Phpmyadmin-devel] Tests related to DB
by Madhura Jayaratne 24 Jun '13

24 Jun '13

On Mon, Jun 24, 2013 at 11:41 AM, Ayush Chaudhary <ayushchd(a)gmail.com>wrote: > Hi, > > I was testing Tracker.class.php. There are a quite a few > assertions related to database queries I might need to implement. I wanted > to know what would be the best approach between using dummy queries and > mocking the database interface class. > > What I thought was to use dummy queries when the SQL query is a SELECT > statement and the result of the query is being further used. > > Please advice. > > Thanks! > -- > Ayush Chaudhary > > Hi Ayush, Dummy DBI and mocking has it's own advantages and choosing between them should be based on the case at hand. Dummy DBI would make it easy to add a common behavior for a query that is used in more than one test case where the expected output of all the tests are the same. On the other hand mocking would give you more control over the behavior. If different tests need to see the database interface return different results for the same query, you have no choice other than mocking. Another situation where you cannot use dummy DBI is ascertaining the correctness of the queries generated. For example, in Node::getData() to test the correctness of the generated query you need to use mocking. In this case the solution would be to create a mock database interface which expected the correct query just once. -- Thanks and Regards, Madhura Jayaratne

1 0

[Phpmyadmin-devel] further refactoring of sql.php
by Marc Delisle 24 Jun '13

24 Jun '13

Hi Supun, If you are looking for further ideas about refactoring, I have suggestions. First, have a look at tbl_select.php, both in the QA_3_5 and the QA_4_0 branches, and see what kind of high-level calls have been left in this refactored script. Everything else went to functions. In this case, Atul also OOPed the code, which is only expected from you if you have time, as it's not part of your proposal. All chunks of code having a common goal (see for example the "Bookmark add" section) should be extracted to sql.lib.php. I was pretty sure you were aware of this, as your proposal plans to spend 6 weeks x 40 hours on refactoring sql.php. Second, as discussed previously, your proposal says "The sql.php is a very large script and is also one of the central components in phpMyAdmin. As it is large it is hard to read and maintain. It needs refactoring and better integration with other scripts calling it." So, all scripts that are including sql.php (for example db_qbe.php) should probably be including a library file then call a high-level function. Hint: sql.php's main job is to deal with $sql_query. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] fixing code style warnings by changing messages?
by Marc Delisle 24 Jun '13

24 Jun '13

Hi, I think we had this discussion, but if so, I could not find the outcome in [0]. Is it a good idea to wrap long messages like Bin is doing in [1], to fix code style warnings? I believe that this would produce new messages for our translators. [0] http://wiki.phpmyadmin.net/pma/Gettext_for_developers [1] https://github.com/xmujay/phpmyadmin/commit/239067f35ff67bc2d707054ed17bc49… -- Marc Delisle http://infomarc.info

4 3

[Phpmyadmin-devel] not uglifying js for production
by Mohamed Ashraf 24 Jun '13

24 Jun '13

Uglifying js code would prevent any meaningful reports from reaching us in the error reporting system since all function and variable names are useless and all the scripts are inlined. I am suggesting that we refrain from uglifing js code in production. Since bandwidth is now sufficiently large to handle pretty js code in production. It would give us access to a wealth of info to help us diagnose and reproduce error reports that may not be feasible with ugly js scripts. what do you think?

4 12

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3678
by michal＠cihar.com 23 Jun '13

23 Jun '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3678/changes> Changes: [weblate] Translated using Weblate (Hindi) [weblate] Translated using Weblate (Traditional Chinese) ------------------------------------------ Started by GitHub push by weblate Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@dbf2988 Using strategy: Default Last Built Revision: Revision 7eb560877d23b52a248feed9c030a01c3271cee6 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision 592b86156c760a9dd70afb5d8e8041ec90351bf6 (origin/master) Checking out Revision 592b86156c760a9dd70afb5d8e8041ec90351bf6 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson2107526584297685716.sh + ./scripts/generate-mo --quiet po/zh_TW.po:12249: 'msgstr' is not a valid PHP format string, unlike 'msgid'. Reason: The character that terminates the directive number 1 is not a valid conversion specifier. msgfmt: found 1 fatal error Build step 'Execute shell' marked build as failure [CHECKSTYLE] Skipping publisher since build result is FAILURE [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 38 warnings. [DRY] Computing warning deltas based on reference build #3677 [TASKS] Skipping publisher since build result is FAILURE [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3677 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [ERROR] - Test reports were found but not all of them are new. Did all the tests run? * <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml> is 3 min 0 sec old [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build.

1 4

[Phpmyadmin-devel] submitting error reports automatically
by Mohamed Ashraf 21 Jun '13

21 Jun '13

Should I allow the user to submit error reports automatically without looking or adding his description to the events that lead to the error page. Currently I have two options for sending error reports. one is never send error report and the second is always ask to send. in the project description you wanted a third option to automatically send an error report. should I allow this option given that the user will not have the ability to add steps to reproduce the error to the report?

2 3

[Phpmyadmin-devel] Relational view interface improvements
by Kasun Chathuranga 21 Jun '13

21 Jun '13

Hi all, I have been working on this feature during the last couple of days and I've sent a pull request [1] containing what I've done. With the changes the long dropdown to select foreign column has been split to two dropdowns, one to select the foreign table and the other to select the foreign column. I have also extended this to support cross database relations with an additional dropdown to select the foreign database. So when the user selects the database, the entries in the table dropdown are filtered only to show tables in that database and column dropdown is filtered in a similar manner when a table is selected. Own database is selected by default as it's more common to setup relations inside the same database. Checking relational integrity feature was already supporting cross database relations. I've added table name to the displayed text to make it clearer. I have also updated a couple of FAQs in the documentation related to these features. I would be grateful if you could check out this feature and suggest any improvements. [1] https://github.com/phpmyadmin/phpmyadmin/pull/438 -- Regards Kasun Chathuranga

1 0