June 2013 - Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] phpMyAdmin 4.0.4 is released
by Marc Delisle 17 Jun '13

17 Jun '13

Welcome to phpMyAdmin 4.0.4, a bugfix version. Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Unit tests failing
by Ayush Chaudhary 17 Jun '13

17 Jun '13

Hi, I recently merged with upstream. However, a lot of unit tests seem to be failing on my machine. All of the failures seem to be related to database. I do have a database named 'pma_test'. It seems I need to import some SQL and also, set me database authentication details somewhere. It would be great if someone could point out those settings (phpunit.xml?) -- Ayush Chaudhary

5 10

[Phpmyadmin-devel] GSoC 2013 : Start of coding
by Dieter Adriaenssens 16 Jun '13

16 Jun '13

Dear GSoC 2013 students, Tomorrow, Monday, June 17th 2013, GSoC 2013 really takes off. By now you should be fully prepared to start coding : your Git repo and blog are set up, you had contact with your mentor, you made a schedule and you know what you will be working on the following 12 weeks and the next week in particular, you got familiar with the code you will be working on and you have discussed any issues with your mentor or on the developers' mailing list [0]. I was pleased to see quite a lot of activity from you on the developers' mailing list and on github : some of you even started coding. I'd like to remind you that we expect you to publish a weekly report on your blog, indicating your progress, any problems you might have had and your plans for the following week. These reports are due on Monday of each week at 12:00 (Noon) UTC. So by tomorrow there should be a first blogpost explaining what you will be working on this week, and from then on, every week a report, so 13 reports in total. I'd also like to point out that, although you are working autonomously on your project, we consider you a part of the phpMyAdmin community, on which you can rely in case of problems and questions. So don't hesitate to ask questions on the developers' mailing list [0], or contact your mentor or one of the GSoC org admins [1] in case of a problem. The mentors are here to help you and guide you, and they can do this best if you report any problems early. tldr; Best of luck with your project and GSoC 2013! I'm sure this will be an interesting experience for you. The phpMyAdmin community is looking forward to your contributions during GSoC 2013 and beyond. Happy coding! [0] phpmyadmin-devel(a)lists.sourceforge.net [1] phpMyAdmin GSoC 2013 org admins : Michal Cihar (michal(a)cihar.com) Dieter Adriaenssens (dieter.adriaenssens(a)gmail.com) Kind regards, Dieter Adriaenssens GSoC 2013 org admin

1 0

[Phpmyadmin-devel] Error reporting settings page
by Mohamed Ashraf 16 Jun '13

16 Jun '13

A large subset of phpmyadmin users are not the ones who deployed it. we need a place to put the settings for error reporting where unpriviliged users can change them. Is the normal settings page available for all users or can it be hidden by those offering limited services such as shared hosting providers. Also in which tab should I put my settings or should put them in a tab of it own.

4 12

[Phpmyadmin-devel] about refactoring the SQL executor
by Marc Delisle 15 Jun '13

15 Jun '13

Hi Supun, I was reading again your proposal. About sql.php, you mention "It needs refactoring and better integration with other scripts calling it." In your suggestions for implementing this, you mention moving code from sql.php to functions in sql.lib.php, functions that will be called from sql.php. However, for "better integration with other scripts calling it", what do you have in mind? A number of scripts are doing include or include_once of sql.php, so I assume that instead of this, these other scripts will be calling a function located in sql.lib.php? -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] Transferring some code in sql.php into parser/analyser
by Supun Nakandala 14 Jun '13

14 Jun '13

Hi, I am refactoring sql.php and I see some places where parsing of the sql query done in the sql.php (eg line 445). I am planning to crate new methods for these tasks in sqlparser.lib.php and call them from sql.php . I would like to know the opinion from the developers about this approach. Regards Supun

3 6

[Phpmyadmin-devel] Error reporting system
by Mohamed Ashraf 13 Jun '13

13 Jun '13

What info do you need to collect about the configuration of phpmyadmin that would help indebugging the code. I think that i can show the different enabled optional plugins like bookmarks, the designer and other options that may not be enabled by default. I am not sure however what other config settings may be relevant -- Mohamed Ashraf Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

2 1

[Phpmyadmin-devel] phpMyAdmin 4.0.4-rc1 is released
by Marc Delisle 13 Jun '13

13 Jun '13

Welcome to the first release candidate for phpMyAdmin 4.0.4, a bugfix version. Please test. Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Source of $_POST['fields'] variables
by Supun Nakandala 13 Jun '13

13 Jun '13

Hi, I am refactoring sql.php and I want to rename the $_POST['fields'][...] variables such that they better reflect their intended use. I was trying to find out the origin of these variables and I was not successful. I would appreciate if someone can help me to find the source and the rationale of these variables. Regards Supun

4 8

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3604
by michal＠cihar.com 12 Jun '13

12 Jun '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3604/changes> Changes: [madhura.cj] Optional @test annotation for tests ------------------------------------------ Started by GitHub push by madhuracj Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@4f3cc73c Using strategy: Default Last Built Revision: Revision df657a2a2ed54ae56b880353a871c6016f7a0bd9 (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision ca3c8a0383f4dd094bcd5cd368b4ec1786d030f0 (origin/master) Checking out Revision ca3c8a0383f4dd094bcd5cd368b4ec1786d030f0 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson6352362110099527209.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] PHP Notice: Undefined variable: cfg in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/charset_con…> on line 18 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] PHP 12. require_once() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_ch…>:12 [exec] PHP Notice: Undefined variable: cfg in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/charset_con…> on line 32 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] PHP 12. require_once() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_ch…>:12 [exec] PHP Notice: Undefined variable: cfg in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/charset_con…> on line 39 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:784 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:860 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] PHP 12. require_once() <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/test/libraries/PMA_ch…>:12 [exec] PHPUnit 3.7.19 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.nocoverage> [exec] [exec] ............ [exec] Result: 139 phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 20 exact clones with 425 duplicated lines in 23 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-138 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2778-2784 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:140-257 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:145-262 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-215 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1871-1878 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:205-211 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:341-347 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:597-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:615-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-955 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:924-962 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:917-961 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:796-840 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:453-460 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:654-682 [exec] [exec] 0.30% duplicated lines out of 143613 total lines of code. [exec] [exec] Time: 12 seconds, Memory: 125.25Mb [exec] Result: 1 phpcs: [exec] Time: 01:32, Memory: 58.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 408 [exec] [exec] Lines of Code (LOC): 143613 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 44917 [exec] Non-Comment Lines of Code (NCLOC): 98696 [exec] [exec] Namespaces: 0 [exec] Interfaces: 3 [exec] Traits: 0 [exec] Classes: 200 [exec] Abstract: 26 (13.00%) [exec] Concrete: 174 (87.00%) [exec] Average Class Length (NCLOC): 225 [exec] Methods: 1728 [exec] Scope: [exec] Non-Static: 1467 (84.90%) [exec] Static: 261 (15.10%) [exec] Visibility: [exec] Public: 1334 (77.20%) [exec] Non-Public: 394 (22.80%) [exec] Average Method Length (NCLOC): 26 [exec] Cyclomatic Complexity / Number of Methods: 4.26 [exec] [exec] Anonymous Functions: 0 [exec] Functions: 620 [exec] [exec] Constants: 168 [exec] Global constants: 108 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 2 minutes 6 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2852 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3603 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 38 warnings. [DRY] Computing warning deltas based on reference build #3603 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 581 files to scan for tasks [TASKS] Found 200 open tasks. [TASKS] Computing warning deltas based on reference build #3603 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3603 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [ERROR] - The result file '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml'> for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 0