Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] selflink not included in some pages
by Mohamed Ashraf 01 Aug '13

01 Aug '13

I noticed that the selflink is not appearing in some pages like for example tbl_addfield.php. It took me a couple of hours to find out why and it was because a global variable was set which was $checked_special it was set in the checkParameters method in Util.class.php I am not sure what this variable means. anyways this variable gets checked in getDisplay in the footer class and if it is true the self link is not shown. can someone tell me if this is correct behavior and why should we not show the self link in those pages. I need the self link to get the current token so it is important that the self link should be available in all pages. -- Mohamed Ashraf

2 2

[Phpmyadmin-devel] Changing the way script files are added
by Mohamed Ashraf 31 Jul '13

31 Jul '13

I was testing how stactraces are returned for the same bug given that the user encountered it on a refresh of the page or on ajax navigate. I found that when using ajax navigation the part of the code that was loaded using ajax is not available in the stacktrace, even though a lot of the time it is the most important part where the exception actually happens. I found out that we need to load javascript the old fashioned way by appending script tags into the head of the page. And we have to do it manually using regular javascript because for some reason jquery intercepts attempts injections of script elements and tries to load them using "evalScript routine" as shown here [0]. I looked at the AJAX class and how it handles script loading and figured out I can easily change the old way of loading scripts from getScript to appending script elements. The problem is when to call the "done" function. While there are some callbacks that get called when a script is loaded, they are not consistent and are sometimes different among browsers specifically IE. Another way is using a function call in the get_scripts.js.php output. I can append the line AJAX.scriptHandler.done(); at the end to call the done function. I think this is the best way to go. I am writing this to tell you about this change since this is a major change in how scripts are loaded and to ask if anyone thinks there is a problem with my line of thought or if you have a better idea. I will do this change and add it to the change log and it should be merged when I merge the rest of my code for GSoC. [0] http://stackoverflow.com/a/3603496/1369210 -- Mohamed Ashraf

3 2

[Phpmyadmin-devel] webbrowser support
by Mohamed Ashraf 31 Jul '13

31 Jul '13

I was reading about webbrowser support to see which javascript features I may rely on and I read this: "Any web browser with cookies enabled". Are we really supporting all browsers with cookies enabled. like even really old IE 5 or strange browsers such as Konqueror. Is this information up to date or is this a bit dated. By the way the libraries we are using aren't so generous with their guarantees. jquery supports only the last two versions of Chrome, Firefox, Safari and Opera and IE 6+ as seen on [0]. I think we should provide a more conservative estimate on what browsers we support. [0] http://jquery.com/browser-support/ -- Mohamed Ashraf

4 4

[Phpmyadmin-devel] about "Edit user group"
by Marc Delisle 31 Jul '13

31 Jul '13

Hi, In Users overview, there is now a link to "Edit user group". This link should not be presented when no user group is defined. -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] Coding style for error reporting server
by Michal Čihař 30 Jul '13

30 Jul '13

Hi I've added error reporting server to Jenkins, but I wonder what coding style it should use - the CakePHP one (as it is CakePHP based) or phpMyAdmin one (as it is part of phpMyAdmin)? Currently it does not really match either of them: https://ci.phpmyadmin.net/job/phpMyAdmin-error-reporting-server/ -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 6

[Phpmyadmin-devel] about "User group privileges"
by Marc Delisle 30 Jul '13

30 Jul '13

Hi, I would like to replace "User group privileges" by "User group menu assignments" because what you assign a user group are not privileges in the MySQL sense. Any objection? -- Marc Delisle http://infomarc.info

3 2

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3984
by michal＠cihar.com 30 Jul '13

30 Jul '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3984/changes> Changes: [Michal Čihař] No parenthesis around include [Michal Čihař] Share code for checking whether to show icons ------------------------------------------ Started by GitHub push by nijel Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@23b2f0c7 Using strategy: Default Last Built Revision: Revision 7ee30619c9d42f824ec3604a19060a4de4b4fd4f (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision 7a97781c238a6b1bc887a9dff8f96afe9bbf82d0 (origin/master) Checking out Revision 7a97781c238a6b1bc887a9dff8f96afe9bbf82d0 (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson1431340865434283118.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] Enabling headers testing... [exec] PHP Parse error: syntax error, unexpected ']' in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/Util.class.…> on line 120 [exec] PHP Stack trace: [exec] PHP 1. {main}() /usr/bin/phpunit:0 [exec] PHP 2. PHPUnit_TextUI_Command::main() /usr/bin/phpunit:46 [exec] PHP 3. PHPUnit_TextUI_Command->run() /usr/share/php/PHPUnit/TextUI/Command.php:129 [exec] PHP 4. PHPUnit_TextUI_Command->handleArguments() /usr/share/php/PHPUnit/TextUI/Command.php:138 [exec] PHP 5. PHPUnit_Util_Configuration->getTestSuiteConfiguration() /usr/share/php/PHPUnit/TextUI/Command.php:657 [exec] PHP 6. PHPUnit_Util_Configuration->getTestSuite() /usr/share/php/PHPUnit/Util/Configuration.php:797 [exec] PHP 7. PHPUnit_Framework_TestSuite->addTestFiles() /usr/share/php/PHPUnit/Util/Configuration.php:873 [exec] PHP 8. PHPUnit_Framework_TestSuite->addTestFile() /usr/share/php/PHPUnit/Framework/TestSuite.php:416 [exec] PHP 9. PHPUnit_Util_Fileloader::checkAndLoad() /usr/share/php/PHPUnit/Framework/TestSuite.php:355 [exec] PHP 10. PHPUnit_Util_Fileloader::load() /usr/share/php/PHPUnit/Util/Fileloader.php:76 [exec] PHP 11. include_once() /usr/share/php/PHPUnit/Util/Fileloader.php:92 [exec] Result: 255 phpcpd: [exec] phpcpd 1.4.2 by Sebastian Bergmann. [exec] [exec] Found 32 exact clones with 576 duplicated lines in 39 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-143 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2782-2793 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:155-272 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:160-277 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:119-130 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:121-132 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:202-208 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:313-319 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:159-173 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:243-257 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:28-41 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:30-43 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/server_priv…>:3887-3900 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/ServerStatu…>:367-380 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:602-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:620-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:929-966 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:935-972 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:929-972 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:807-850 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:460-467 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:661-689 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/tbl_row_action.php>:127-133 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/tbl_select.php>:63-69 [exec] [exec] 0.39% duplicated lines out of 148138 total lines of code. [exec] [exec] Time: 6 seconds, Memory: 131.00Mb [exec] Result: 1 phpcs: [exec] Time: 01:20, Memory: 57.75Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 425 [exec] [exec] Lines of Code (LOC): 148138 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 46231 [exec] Non-Comment Lines of Code (NCLOC): 101907 [exec] [exec] Namespaces: 0 [exec] Interfaces: 5 [exec] Traits: 0 [exec] Classes: 208 [exec] Abstract: 28 (13.46%) [exec] Concrete: 180 (86.54%) [exec] Average Class Length (NCLOC): 224 [exec] Methods: 1820 [exec] Scope: [exec] Non-Static: 1541 (84.67%) [exec] Static: 279 (15.33%) [exec] Visibility: [exec] Public: 1416 (77.80%) [exec] Non-Public: 404 (22.20%) [exec] Average Method Length (NCLOC): 25 [exec] Cyclomatic Complexity / Number of Methods: 4.20 [exec] [exec] Anonymous Functions: 2 [exec] Functions: 679 [exec] [exec] Constants: 167 [exec] Global constants: 107 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 1 minute 35 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2676 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3983 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 55 warnings. [DRY] Computing warning deltas based on reference build #3983 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 672 files to scan for tasks [TASKS] Found 203 open tasks. [TASKS] Computing warning deltas based on reference build #3983 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3983 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - No test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. Did you enter a pattern relative to the correct directory? Did you generate the result report(s) for 'PHPUnit-3.x (default)'? [xUnit] [ERROR] - No test reports found for the metric 'PHPUnit' with the resolved pattern 'build/logs/junit.xml'. Configuration error?. [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 2

[Phpmyadmin-devel] mbstring and ctype in the doc
by Marc Delisle 30 Jul '13

30 Jul '13

Hi, in our doc for 4.0.x, the PHP requirements mention these (among other lines): ----------- You need PHP 5.2.0 or newer, with ``session`` support, the Standard PHP Library (SPL) extension and JSON support. For proper support of multibyte strings (eg. UTF-8, which is currently the default), you should install the ``mbstring`` and ``ctype`` extensions. ----------- It would be simpler to say: ----------- You need PHP 5.2.0 or newer, with ``session`` support, the Standard PHP Library (SPL) extension, JSON support, and the ``mbstring`` and ``ctype`` extensions. ----------- I would use this as a doc fix for https://sourceforge.net/p/phpmyadmin/bugs/4036/ -- Marc Delisle http://infomarc.info

2 1

[Phpmyadmin-devel] phpMyAdmin 4.0.5-rc2 is released
by Marc Delisle 30 Jul '13

30 Jul '13

Welcome to the second release candidate for phpMyAdmin 4.0.5, a bugfix and security fix version. Details will appear on http://phpmyadmin.net. In a hurry? you can visit https://sourceforge.net/projects/phpmyadmin/files to download. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] repeated code in Version check
by Mohamed Ashraf 30 Jul '13

30 Jul '13

I pulled master lately and I found that Michal Čihař has refactored the code that requests the latest version info. I needed to update a few things specifically with the renaming of the proxy variable names. Anyway I noticed a strange piece of code in the function: if ($save) { $_SESSION['cache']['version_check'] = array( 'response' => $response, 'timestamp' => time() ); } $data = json_decode($response); if (is_object($data) && strlen($data->version) && strlen($data->date) ) { if ($save) { $_SESSION['cache']['version_check'] = array( 'response' => $response, 'timestamp' => time() ); } } why is the part that saves the response in the cache written twice in succession. I looked at the commit in question dcd8d12cf6c4a345 and noticed that the first repetition did not exist in the original code. I think that the first repetition should be removed but I thought I should run it by you first -- Mohamed Ashraf

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers