Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Treat error reports individually or as groups
by Mohamed Ashraf 17 Jul '13

17 Jul '13

Error reports are submitted individually and are stored individually in the database. however I am not sure of the usage statistics of phpmyadmin however exceptions happen and an automated report system is bound to send a huge amount of error reports. The system should be able to mark a report as related to another report either manually or hopefully automatically with some degree of effectiveness. When a developer views an error report should I display only the information in that error report or should I show the info in related error reports as well. for example if this specific report came from a chrome 23.7.5.253 browser and just provide links at the bottom to related reports or I can show the browser versions in related error reports as well. The good thing about showing the related info in the same report is that the developer may be able to see patterns to help diagnose the problem however the problems is that it would clutter the interface and there may be alot of differences in the reports that every report is different and there may be a 1000 different browser versions affected in the related reports if for example it has nothing to do with browser versions.

3 2

[Phpmyadmin-devel] origin of the variable $selected in sql.php
by Supun Nakandala 16 Jul '13

16 Jul '13

Hi devs, According to my research I couldn't find any place where the variable $selected is set which is used in sql.php. Also this variable is used to check indexes if indexes should be checked in sql.lib.php. I am not sure about what is meant by checking an index. But since $selected seems to be not initialized this code will never run. I would like to know your opinion on this issue. regards supun.

3 2

[Phpmyadmin-devel] token mismatch with server variables
by Isaac Bennetch 16 Jul '13

16 Jul '13

Hi, I just took a bug report/suggested fix from "an anonymous IRC user" who doesn't have a SourceForge or github account. The thing is, I can't reproduce it. Does anyone have any comment on this? I 'm running latest 4.0.4.1 and wanted to change a server variable, but every time I clicked on one I got a token mismatch. Turns out, line 128 of server_variables.php does: $url = htmlspecialchars('server_variables.php?' . PMA_generate_common_url()); The html special chars converts an '&' to & where it shouldn't. This effectively makes it impossible to change any server variables via phpMyAdmin. Changing it to: $url = ('server_variables.php?' . PMA_generate_common_url()); (kill the htmlspecialchars()) works. But I'm not certain this would be the correct fix.

3 4

[Phpmyadmin-devel] Mocking static methods - Unit tests
by Ayush Chaudhary 16 Jul '13

16 Jul '13

Hi, I have been writing Unit Tests for classes and libraries under libraries/config/*. For isolation between different libraries, its preferred to mock certain functions. Since some of the code is functional, I tried to convert (for a start) libraries/config/validate.lib.php into a class with static methods. However, the issue here is that mocking static methods is not really possible with PHPUnit and there are a few workarounds I came across and would like to know which one should we go for, or if there is anything better that can be done. So, while the writer of PHPUnit specifies how to mock static methods here[0], its only possible if the static calls are to the same class. For example, for testing FormDisplay::_validate, I need to mock PMA_config_validate. After I convert validate.lib.php to a class, say, PMA_Validator, I will have to mock PMA_Validator::config_validate, but the above solution won't work here (since PMA_Validator cannot be mocked). A workaround for this could be to pass the mocked static class as mentioned in [0] to the FormDisplay.class.php and make all static calls via that class. For this, we could have something of this sort in the constructor of FormDisplay: if (defined('TESTSUITE')) $this->validator = $GLOBALS['dummyValidator'] or $this->validator = <mockedClassPassedInTheArgument> else $this->validator = 'PMA_Validator' and the calls can be made like: $caller = $this->validator; // $this->validator::config_validate won't work $caller:config_validate(); Another solution could be what is mentioned in a blog here[1]. The problem with this solution is that the file, FormDisplay.class.php would include and hence declare the PMA_Validator class before our test suite tries to (re)declare it by extending MockProxy class. In either case, it looks like some sort of modification would be needed to test these classes. Please advice. [0] http://sebastian-bergmann.de/archives/883-Stubbing-and-Mocking-Static-Metho… [1] http://www.deanspot.org/content/mocking-static-method-calls-phpunit -- Ayush Chaudhary

3 5

[Phpmyadmin-devel] Goals for GSOC week 5
by Supun Nakandala 15 Jul '13

15 Jul '13

Hi devs, I am facing a difficulty in setting up the goals for the week 5. I think I have considerably refactored the sql.php using extract method. I would like to hear from you whether I should consider further refactoring using extract method or any other suggestions to work on during the next week. Regards Supun

2 3

[Phpmyadmin-devel] About the configurable menus
by Isaac Bennetch 15 Jul '13

15 Jul '13

Hi Kasun, I may be missing it, but in your recent work[1] is there a way to see which users are in a usergroup? Perhaps an additional link from the Action column of the User groups area of the Users page with the text "View users" or something???? Copying the phpmyadmin-devel list to see if others think this would be useful and get input on the location/label of the link. 1 - https://github.com/phpmyadmin/phpmyadmin/pull/484

3 4

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3856
by michal＠cihar.com 15 Jul '13

15 Jul '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3856/changes> Changes: [weblate] Translated using Weblate (Greek) ------------------------------------------ Started by GitHub push by weblate Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@948d3a0 Using strategy: Default Last Built Revision: Revision 8ce9acb65bc9e8294a29ea0e7b4d29cb7fbfbece (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision 7873d84c709637689b36cec3125dd549b4c3289a (origin/master) Checking out Revision 7873d84c709637689b36cec3125dd549b4c3289a (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson3710597234498839662.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] [exec] [exec] PHPUnit 3.7.22 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.nocoverage> [exec] [exec] ............ [exec] Result: 139 phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 31 exact clones with 564 duplicated lines in 36 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-143 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2778-2789 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:140-257 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:145-262 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-215 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1871-1878 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:119-130 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:121-132 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:202-208 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:313-319 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:28-41 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:30-43 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:602-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:620-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:929-966 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:935-972 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:929-972 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:807-850 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:453-460 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:654-682 [exec] [exec] 0.39% duplicated lines out of 145455 total lines of code. [exec] [exec] Time: 35 seconds, Memory: 127.75Mb [exec] Result: 1 phpcs: [exec] Time: 02:07, Memory: 59.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 414 [exec] [exec] Lines of Code (LOC): 145455 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 45324 [exec] Non-Comment Lines of Code (NCLOC): 100131 [exec] [exec] Namespaces: 0 [exec] Interfaces: 3 [exec] Traits: 0 [exec] Classes: 205 [exec] Abstract: 26 (12.68%) [exec] Concrete: 179 (87.32%) [exec] Average Class Length (NCLOC): 224 [exec] Methods: 1775 [exec] Scope: [exec] Non-Static: 1475 (83.10%) [exec] Static: 300 (16.90%) [exec] Visibility: [exec] Public: 1382 (77.86%) [exec] Non-Public: 393 (22.14%) [exec] Average Method Length (NCLOC): 25 [exec] Cyclomatic Complexity / Number of Methods: 4.23 [exec] [exec] Anonymous Functions: 2 [exec] Functions: 641 [exec] [exec] Constants: 166 [exec] Global constants: 106 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 3 minutes 38 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2801 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3855 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 53 warnings. [DRY] Computing warning deltas based on reference build #3855 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 637 files to scan for tasks [TASKS] Found 199 open tasks. [TASKS] Computing warning deltas based on reference build #3855 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3855 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [ERROR] - The result file '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml'> for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 0

[Phpmyadmin-devel] Build failed in Jenkins: phpMyAdmin-continuous #3850
by michal＠cihar.com 14 Jul '13

14 Jul '13

See <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/3850/changes> Changes: [marc] Fix typo ------------------------------------------ Started by GitHub push by lem9 Building in workspace <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> Checkout:workspace / <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> - hudson.remoting.LocalChannel@6b414655 Using strategy: Default Last Built Revision: Revision 6c71eb3431da6bd7f043e686701892dd6c7aaa4d (origin/master) Fetching changes from 1 remote Git repository Fetching upstream changes from origin Commencing build of Revision ddbdc6e16cda4afdcfb074dc7ab8a284b902dd6c (origin/master) Checking out Revision ddbdc6e16cda4afdcfb074dc7ab8a284b902dd6c (origin/master) [workspace] $ /bin/sh -xe /tmp/hudson722331927783630170.sh + ./scripts/generate-mo --quiet [workspace] $ ant clean phpunit-nocoverage phpcpd phpcs phploc jshint Unable to locate tools.jar. Expected to find it in /usr/lib/jvm/java-6-openjdk-amd64/lib/tools.jar Buildfile: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build.xml> clean: [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [delete] Deleting directory <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/api> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/code-browser> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/coverage> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs> [mkdir] Created dir: <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/pdepend> phpunit-nocoverage: [exec] [exec] [exec] PHPUnit 3.7.22 by Sebastian Bergmann. [exec] [exec] Configuration read from <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/phpunit.xml.nocoverage> [exec] [exec] ............ [exec] Result: 139 phpcpd: [exec] phpcpd 1.4.1 by Sebastian Bergmann. [exec] [exec] Found 31 exact clones with 564 duplicated lines in 36 files: [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/e…>:65-73 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/p…>:520-528 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/j…>:132-143 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/c…>:2778-2789 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/pmahomme/css/n…>:140-257 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/themes/original/css/n…>:145-262 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-215 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:1871-1878 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:204-211 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:220-227 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:119-130 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:121-132 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:202-208 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:208-214 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/exp…>:313-319 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:157-171 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/aut…>:233-247 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:28-41 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:30-43 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/tra…>:29-42 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:557-572 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:572-587 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:86-93 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/imp…>:87-94 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Exp…>:192-204 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/plugins/Imp…>:46-58 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:279-297 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:283-301 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:396-417 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:429-450 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-459 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:479-490 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:602-643 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:620-661 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:929-966 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Eps_…>:935-972 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:277-284 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:929-972 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Dia_…>:807-850 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:448-455 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:453-460 [exec] [exec] - <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Svg_…>:620-648 [exec] <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/libraries/schema/Pdf_…>:654-682 [exec] [exec] 0.39% duplicated lines out of 145257 total lines of code. [exec] [exec] Time: 5 seconds, Memory: 127.50Mb [exec] Result: 1 phpcs: [exec] Time: 01:38, Memory: 59.25Mb [exec] [exec] Result: 1 phploc: [exec] phploc 1.7.4 by Sebastian Bergmann. [exec] [exec] Directories: 33 [exec] Files: 414 [exec] [exec] Lines of Code (LOC): 145257 [exec] Cyclomatic Complexity / Lines of Code: 0.13 [exec] Comment Lines of Code (CLOC): 45236 [exec] Non-Comment Lines of Code (NCLOC): 100021 [exec] [exec] Namespaces: 0 [exec] Interfaces: 3 [exec] Traits: 0 [exec] Classes: 205 [exec] Abstract: 26 (12.68%) [exec] Concrete: 179 (87.32%) [exec] Average Class Length (NCLOC): 224 [exec] Methods: 1775 [exec] Scope: [exec] Non-Static: 1475 (83.10%) [exec] Static: 300 (16.90%) [exec] Visibility: [exec] Public: 1382 (77.86%) [exec] Non-Public: 393 (22.14%) [exec] Average Method Length (NCLOC): 25 [exec] Cyclomatic Complexity / Number of Methods: 4.23 [exec] [exec] Anonymous Functions: 2 [exec] Functions: 630 [exec] [exec] Constants: 166 [exec] Global constants: 106 [exec] Class constants: 60 jshint: [apply] Result: 1 BUILD SUCCESSFUL Total time: 2 minutes 10 seconds [CHECKSTYLE] Collecting checkstyle analysis files... [CHECKSTYLE] Finding all files that match the pattern build/logs/checkstyle.xml [CHECKSTYLE] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [CHECKSTYLE] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/checkstyle…> of module with 2810 warnings. [CHECKSTYLE] Computing warning deltas based on reference build #3849 [DRY] Collecting duplicate code analysis files... [DRY] Finding all files that match the pattern build/logs/pmd-cpd.xml [DRY] Parsing 1 files in <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/> [DRY] Successfully parsed file <http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/pmd-cpd.xml> of module with 53 warnings. [DRY] Computing warning deltas based on reference build #3849 [TASKS] Scanning folder '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for files matching the pattern '**/*.php' - excludes: build/**,libraries/PHPExcel/**,libraries/tcpdf/**,libraries/php-gettext/** [TASKS] Found 637 files to scan for tasks [TASKS] Found 199 open tasks. [TASKS] Computing warning deltas based on reference build #3849 [ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #3849 Recording plot data [xUnit] [INFO] - Starting to record. [xUnit] [INFO] - Processing PHPUnit-3.x (default) [xUnit] [INFO] - [PHPUnit-3.x (default)] - 1 test report file(s) were found with the pattern 'build/logs/junit.xml' relative to '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/'> for the testing framework 'PHPUnit-3.x (default)'. [xUnit] [ERROR] - The result file '<http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/ws/build/logs/junit.xml'> for the metric 'PHPUnit' is empty. The result file has been skipped. [xUnit] [INFO] - Fail BUILD because 'set build failed if errors' option is activated. [xUnit] [INFO] - There are errors when processing test results. [xUnit] [INFO] - Skipping tests recording. [xUnit] [INFO] - Stop build. Build step 'Publish xUnit test result report' changed build result to FAILURE

1 0

[Phpmyadmin-devel] CALL recognized as alpha_identifier by the sql parser
by Supun Nakandala 14 Jul '13

14 Jul '13

Hi, I was trying to transfer the check for "is_procedure" in sql.php to sql parser. There I realized that "CALL" is recognized as alpha_identifier rather than alpha_reservedWord. But CALL is a mysql reserved word. I would like to have a clarification regarding this issue. Regards Supun.

2 1

[Phpmyadmin-devel] about "Not supported query: SHOW GRANTS"
by Marc Delisle 13 Jul '13

13 Jul '13

Hi, on my test server, git bisect tells me that this commit introduced this UT message: https://github.com/phpmyadmin/phpmyadmin/commit/82e361376c42433df75a0035693… -- Marc Delisle http://infomarc.info

4 3

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers