Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Problem with recent tables
by Rouslan Placella 05 Aug '11

05 Aug '11

I noticed that the JS code that handles the recent tables in the navigation frame operates under the assumption that there will only ever be one dot in the database+table string. This is not true. To reproduce the problem: * create database 'abc.def' * in this database create table 'ghi' * browse this table * now select it from the recent table dropdown * you are dropped to main.php because PMA is looking for database 'abc' and table 'def' (the 'ghi' part is discarded) I'm not saying that it's sane to put dots in the database name, but it's certainly legal. So maybe the check should be for the last occurrence of a dot... Rouslan

4 6

[Phpmyadmin-devel] Grid editing versus Inline edit
by Marc Delisle 05 Aug '11

05 Aug '11

Hi, I just tried Aris's new feature: grid editing (or Edit mode). A few things are not ready, for example ENUM, SET and TEXT editing; however I feel that with this, we won't need inline edit (for rows) any more. -- Marc Delisle http://infomarc.info

5 24

[Phpmyadmin-devel] AJAX: No success message
by Tyron Madlener 05 Aug '11

05 Aug '11

Maybe we can fix this bug: https://sourceforge.net/tracker/index.php?func=detail&aid=3364150&group_id=… It affects quite some people and is very annoying. I have added my research as comment, but I'd need to know why it has been coded like this (it doesn't look like its a bug).

1 0

[Phpmyadmin-devel] Advisor bugs
by Piotr Przybylski 05 Aug '11

05 Aug '11

Hi, I run Advisor on my MySQL 5.5 and got two bogus warnings: 1. The MySQL server version less then 5.1. It's not, but the rule does something else that description says: substr(value,0,3) != "5.1" 2. Version less then 5.1.30 (the first GA release of 5.1). I have 5.5.14, and it is triggered by the rule "substr(value,4,2) < 30" - "14 < 30" -- Regards, Piotr Przybylski

2 2

[Phpmyadmin-devel] [phpMyAdmin] bug ID: 3306875
by Marcos Mendonça 05 Aug '11

05 Aug '11

Hi all, I've been using phpMyAdmin for a while now and recently started with a group focused on open source. Personally, I'd like to contribute with phpMyAdmin. So I joined the list and going through the buglist I run into issue: 3306875 Can't rename a database that contains views. I'm still getting familiar with the code, so I could use some pointers or directions that could help me find a solution for this one. Thanks any help in advance. -- Marcos Mendonça

3 5

[Phpmyadmin-devel] htmlspecialchars for gettext output?
by Herman van Rink 05 Aug '11

05 Aug '11

Hi, I feel that http://wiki.phpmyadmin.net/pma/Gettext_for_developers should mention something about whether it is useful/needed to run the output of __('Default') through htmlspecialchars. To the best of my knowledge this is not needed, and just adds overhead. But a quick grep in the code pointed me to 23 lines doing this. Please correct me if I'm wrong here...Michal? -- Met vriendelijke groet / Regards, Herman van Rink Initfour websolutions

2 1

[Phpmyadmin-devel] JS error in master
by Piotr Przybylski 05 Aug '11

05 Aug '11

When I run phpMyAdmin (latest master) I get an error in FIrebug console: window.parent.currentWidth is not a function. It's caused by this line in functions.js: if(window.parent.currentWidth() == 0) -- Regards, Piotr Przybylski

3 3

[Phpmyadmin-devel] file_echo.php
by Michal Čihař 04 Aug '11

04 Aug '11

Hi Tyron your changes include unprotected (does not require user being logged in and no token check) file file_echo.php, which allows to download arbitrary data. This could be easily used by attacker to pretend data is coming from safe location (where phpMyAdmin is running), while it would actually come from attacker. I've removed defining of PMA_MINUMUM_COMMON (which does skip all the checks) from this file. As you already seem to pass token with the request, no other change should be needed, but please take care of such dangerous code in future. -- Michal Čihař | http://cihar.com | http://blog.cihar.com

3 6

[Phpmyadmin-devel] Zoom-search and initial data reading
by Marc Delisle 04 Aug '11

04 Aug '11

Ammar, With Firebug I had a look at the network traffic when I click a data point to edit it: I was surprised to see none. IMO this is not good: it means that all the columns for all rows are in memory, making the browser able to handle far less rows. Is there a reason why you are reading the complete rows to generate the plot? I expected that you would just read the necessary columns, then use AJAX to read a complete row when the user wants to edit it. -- Marc Delisle http://infomarc.info

4 9

[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Operations
by Thilanka Kaushalya 04 Aug '11

04 Aug '11

Hi Marc, I went through other options which could be able to ajaxify. I found following issues with them. 1. Since "Move Table to database" option should redirect to the moved table in the new database, we have to anyhow refresh the "Frame content" after this action. So there is no point of applying ajax behavior to it. 2. For "*Table options*" if I add the ajax behavior to submit the form without reloading the page I may need to replace all the table parameters which are currently embedded with the "*href*" attributes in the whole page. As an example it I change the table name from "actor" to "actor1" using "*Table options*" I may need to change the "*href*" of all four links in "*Table maintenance*" and "*Delete data or table*" to actor1 by using ajax. Is it okay to do that. 3. In "*Delete data or table*" section currently there is a "* ("#truncate_tbl_anchor").live('click'')*" action in functions.js file. In there after using the $.get() function, the two frames are reloaded. We can modify this action to stay at the same page after "*Truncate the table*". We cannot apply ajax to "*Delete the table(Drop)*" option because anyhow we have to quit the "*Table options*" after deleting the table. I think all the options in "*Table maintenance*" section need ajax behavior (process without reloading the page). If you find any of the above mentioned options need changes can you please comment on those. I'll work with ajaxifying the "*Table maintenance*" section and update you as soon as possible. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers