Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Grid editing and escaping
by Michal Čihař 19 Aug '11

19 Aug '11

Hi it looks like grid editing does not properly handle escaping HTML entities. Just try importing test/test_data/exploit_test.sql and edit any row in exploit_test.evil_content. -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

2 1

[Phpmyadmin-devel] Bug in Ajax table Structure column Change
by Marc Delisle 19 Aug '11

19 Aug '11

Thilanka, could you have a look at this bug? I can reproduce it. https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3392824&group_… -- Marc Delisle http://infomarc.info

2 3

[Phpmyadmin-devel] SQL Pretty printer
by Tyron Madlener 19 Aug '11

19 Aug '11

On Thu, Aug 18, 2011 at 1:02 PM, Michal Čihař <michal(a)cihar.com> wrote: > Hi > > Dne Wed, 17 Aug 2011 20:45:44 +0300 > Tyron Madlener <tyronx(a)gmail.com> napsal(a): > >> Ok I just added this behavior myself. We just need a new css class for >> this now. Maybe it makes sense to give statements verbs a different >> color, let's say blue? Or better just the same keyword color? > > I think it should stay consistent with PHP parser/highlighter, so see > $GLOBALS['cfg']['SQP']['fmtColor'] for possible types. > I've just added a css rule for this with using the same as 'keyword' for now. I've also took the liberty to fix up the matching of multipart keywords such as "insert into", "group by". Those are now identified as one keyword instead of both being identified individually. And the reason for these 2 changes is because I've now implemented a sql pretty printer using the codemirror/mysql-mode tokenizer. This replaces the bunch of regex's that I used earlier to pretty print queries in the query analyzer dialog, since they fail in many cases. The new implementation should now pretty print any query correctly, including subqueries. I could need some more test data though. I've added this feature in the form of PMA_SQLPrettyPrint() in functions.js - maybe we use it for the sql query editor as well? Here's a screenshot of how it looks like: http://www.tyron.at/tmp/prettyprinter.png

2 1

[Phpmyadmin-devel] Codemirror highlighting glitch
by Tyron Madlener 18 Aug '11

18 Aug '11

Michal, The MySQL highlighter mistakenly highlights any word as function that are contained in the function list, even if they don't have the functions brackets appended. In my case with the substring "MAX(x)" the highlighter interprets 'MAX' as well as 'x' as function.

2 4

Re: [Phpmyadmin-devel] column reorder potential problem
by Aris Feryanto 17 Aug '11

17 Aug '11

On 12 Agu 2011, at 03:28, Marc Delisle <marc(a)infomarc.info> wrote: > Aris Feryanto a écrit : >> Hi Marc, >> >>> From: Marc Delisle <marc(a)infomarc.info> >> >>> Aris Feryanto a écrit : >>>> Hi, >>>> >>>>> From: Aris Feryanto <aris_feryanto(a)yahoo.com> >>>>> Hi Marc, >>>>> >>>>>> From: Marc Delisle <marc(a)infomarc.info> >>>>>> Aris, >>>>>> >>>>>> please have a look at [0]. It's interesting to see your code >>> being >>>>>> tested by many users at such an earlier stage. >>>>>> >>>>>> [0] >>>>>> >>> https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3386436&group_… >>>>> Thanks for noticing this. I just looked at the bug report: >>>>> >>>>> Details: The column reorder-patch breaks or complicates the selection >>> the text >>>>> of a column in FF5, especially for (smaller) id columns. >>>>> >>>>> >>>>> In my test, I cannot reproduce this after reordering some columns. The >>> bug only >>>>> happen after shift+click to select some rows in a table. This is a >>> known >>>>> disadvantage of enabling shift+click (I've stated this in when we >>> were >>>>> discussing to enable shift+click feature). Should we change it? >>>>> >>>>> Another way to keep the shift+click feature and text-selection work >>> together: >>>>> use javascript to clear selection after shift+click, but it makes the >>> screen >>>>> flickering for a while. You may try this in "clear_selection" >>> branch >>>>> in my git. >>>>> >>>> Any comment on the text selection problem? >>> Aris, >>> I cannot reproduce this problem. By the way, I believe that what Sven >>> Strickroth means is not that to reproduce the problem, you have to >>> reorder the columns. He means that since this patch has been merged, he >>> has this problem. >>> >>> You might want to clarify this with him, in the bug tracker. >> >> Yes, you are right. I just want to know exactly if he had the same issue like the one that I found. >> >> Here is my scenario to reproduce the text selection problem: >> - browse a table >> - make a selection in some text inside the table interface and notice that the text can be selected > > I tried with current master. > > Do you mean selecting some text which is part of the data rows? Yes, correct. Do you get the same problem? > >> - click on one of the checkboxes in the table rows >> - now, try to make a text selection again and notice that the text cannot be selected anymore >> >>> Also, ask him if he has FF extensions other than Firebug, and what is >>> his workstation platform. >>> >> -- Aris Feryanto

2 7

[Phpmyadmin-devel] Problem with "Advisor" unit tests
by Rouslan Placella 17 Aug '11

17 Aug '11

Hi there, On my computer there is a problem with the unit tests for "Advisor". If I just run the advisor test, everything is fine, it's run very quickly and succeeds. But if I run all unit tests in one go, then the "Advisor" unit test takes over a minute and eats up well over 1GB of my memory (which is unacceptable). However I can't see this issue on ci.phpmyadmin.net, where all tests complete within 25s and using only 85MB of memory. Can anyone else confirm this behaviour? Any ideas what could be the cause of this problem? I've attached 2 screenshots as proof, one at the beginning of the tests and one just before the Advisor test has finished running. Rouslan

3 5

[Phpmyadmin-devel] backquotes in SQL query
by Dieter Adriaenssens 16 Aug '11

16 Aug '11

Hi, I noticed Piotr removed back quotes from a few fields in an SQL query. They were fixed strings (no variables), so they don't really need escaping, but I was under the impression that it is good practice to add back quotes to every field/table/database name in a SQL query, not only the dynamic ones? -- Kind regards, Dieter Adriaenssens

4 4

[Phpmyadmin-devel] Any last wishes?
by Tyron Madlener 16 Aug '11

16 Aug '11

Since the google summer of code is ending and my project of supplying phpMyAdmin users with tools to help them improve their database performance is as good as completed, I'd like to ask the devs if there's anything important missing for my proposal? Maybe some feature that would greatly help with optimizing the server, lacking documentation on how the tools work, bugs that would need fixing or issues with the code? The recommendation don't necessarily need to fit into the last week of GSoC as I do not plan to completely stop my contributions right after GSoC.

3 5

Re: [Phpmyadmin-devel] Any last wishes?
by Tyron Madlener 16 Aug '11

16 Aug '11

Resending to devlist... On Mon, Aug 15, 2011 at 3:53 PM, Tyron Madlener <tyronx(a)gmail.com> wrote: > On Mon, Aug 15, 2011 at 11:19 AM, Michal Čihař <michal(a)cihar.com> wrote: >> Hi >> >> what I would like to see: >> >> - improve page load speed, currently it takes quite long till tabs are >> initialized > > - Do you have any knowledge about js/config.js? It doesn't look like > it's needed on the status page at all. Maybe we could include this > file only where it's needed. > > - I could load the status variables on demand (when the user clicks > the tab), I guess that would be the next best speed improvement. > > Apart from these two optimizations I'm not sure whether there's > anything left to optimize that would result in big loading speed > improvements. Well I could also load the query statistics on demand. > But having almost every tab load on demand only shifts the loading > time to a later point. > > Also I'm not sure whether it's really necessary for the status page to > load so quick. Each tab has some sort of refresh functionality so you > never have to fully reload the page anyway. > >> - automatically start monitor when switching to monitor tab >> > > I'm also not so sure about this. The Monitor adds some overhead to the > mysql server as well as to your client browser, through the regular > refreshes. > Having it start automatically it will be more likely that people will > have the monitor running without actually needing it. > > Though, I do agree that showing an empty page instead isn't very nice either. > >> -- >> Michal Čihař | http://cihar.com | http://phpmyadmin.cz >> >

3 4

[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Operations->table maintenance
by Thilanka Kaushalya 15 Aug '11

15 Aug '11

Hi Mac, > I think all the options in "*Table maintenance*" section need ajax > > behavior (process without reloading the page). If you find any of the > > above mentioned options need changes can you please comment on those. > > I'll work with ajaxifying the "*Table maintenance*" section and update > > you as soon as possible. > > In Table maintenance's current non-Ajax behavior, the results page > contains unneeded parts. > > For example, choosing "Check table" does this: > - display the generated query (ok) > - show the results containing status (ok) > - show Query results operations (unneeded) > - show Bookmark section (unneeded) > > This is because tbl_operations.php calls sql.php when > $_REQUEST['table_maintenance'] is set. > > Try to remove the unneeded parts, at least for the new Ajax bahavior. > > I worked with this feature and pushed my changes to the repo. Since I'm not very much familiar with the back end logic related with these features can you please check the operations and comment on the results. Thank you. Regards, Thilanka. -- L G Thilanka Kaushalya Computer Science & Engineering, University of Moratuwa, Sri Lanka Connect with me at, Gmail : lgtkaushalya(a)gmail.com Twitter : @thilanka_k Facebook : Thilanka Kaushalya Yahoo : lgtkaushalya(a)yahoo.com Blog : http://coders-view.blogspot.com/

2 6

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers