Developers

developers@phpmyadmin.net

2 participants
7003 discussions

[Phpmyadmin-devel] Variables duplicated in config.default.php and data_mysql.inc.php
by Michal Čihař 15 Aug '11

15 Aug '11

Hi what is actually reason for duplicating variables in config.default.php and data_mysql.inc.php? -- Michal Čihař | http://cihar.com | http://phpmyadmin.cz

2 2

Re: [Phpmyadmin-devel] Remember the last way user sorted tables
by Aris Feryanto 12 Aug '11

12 Aug '11

On 24 Mei 2011, at 18:56, Piotr Przybylski <piotr.prz(a)gmail.com> wrote: > 2011/5/24 Aris Feryanto <aris_feryanto(a)yahoo.com>: > Remember that when storing data per table you will have to set some > upper limit, or you may have data in which half of the tables don't > exist. Limiting eg. to 100 takes care of dealing with removed tables - > after some time you will just "forget" about them (they get pushed out > of saved table list). Thank you for the good suggestion, Piotr. I will limit the records if I store them per table. -- Aris Feryanto

2 2

Re: [Phpmyadmin-devel] Merging grid editing
by Aris Feryanto 12 Aug '11

12 Aug '11

On 12 Agu 2011, at 01:14, Aris Feryanto <aris_feryanto(a)yahoo.com> wrote: > > On 12 Agu 2011, at 01:01, Marc Delisle <marc(a)infomarc.info> wrote: > >> Aris Feryanto a écrit : >>>> From: Marc Delisle <marc(a)infomarc.info> >>> >>>> Aris Feryanto a écrit : >>>>> Hi Marc, >>>>> >>>>>> From: Marc Delisle <marc(a)infomarc.info> Aris Feryanto a écrit : >>>>>> >>>>>>> Hi Marc, >>>>>>> >>>>>>>> From: Marc Delisle <marc(a)infomarc.info> Aris, I would >>>> like to >>>>>>>> merge this feature but I get merge conflicts, can you have >>>>>>>> a look at this? >>>>>>>> >>>>>>> I just fixed the merge conflict in my master branch. Kindly >>>>>>> merge the grid editing from there. The master branch also >>>>>>> contain some fix for recent tables and configuration for qTip >>>>>>> hint. Thanks. >>>>>> Done. >>>>>>> Btw, I'm currently refactoring and cleaning code in >>>>>>> js/makegrid.js and there will be a significant code structure >>>>>>> changes in that file. I'll update you once it is finished. >>>>>> OK. >>>>>> >>>>> I finished cleaning code in js/makegrid.js and pushed the changes >>>>> to my git repo. >>>>> >>>>> I change the structure of the code to match existing PMA code, >>>>> but I still keep the OOP style inside the function. The new >>>>> PMA_makegrid() function can accept some optional parameters, in >>>>> order to adjust which functionality (resize, reorder, show/hide, >>>>> grid edit) that want to be enabled for a table. This may be >>>>> useful for applying some features for other types of table (other >>>>> than the one generated while browsing database). >>>>> >>>>> -- Aris Feryanto >>>> Pushed, thanks. >>>> >>>> I am making a last attempt about this issue: do you have an idea >>>> about advertising (for example with a tip) about grid editing? >>>> >>> >>> Oh, right. Adding tooltips in every editable cells will be >>> disturbing, IMO. >>> >>> How about add a hint tooltip in "Edit" link in table's rows? Maybe >>> some hint like: "You can also edit a field by clicking directly on a >>> cell in the table.". Actually, we may add more hint to tell the users >>> that grid editing doesn't work for BLOB data type, but the hint will >>> be too long to be displayed. >> >> Good idea, but I suggest "You can also edit most columns by clicking >> directly on their content." >> >> These are columns, not fields; and using "most" explains in a short way >> that not everything is editable. >> > > Great! I think that will work. I'll add this soon. > Added in my git and updated on the demo server. The tooltip should look more fancy (like the old tooltip before using qTip), after Tyron's branch is merged. -- Aris Feryanto

2 1

[Phpmyadmin-devel] column reorder potential problem
by Marc Delisle 11 Aug '11

11 Aug '11

Aris, please have a look at [0]. It's interesting to see your code being tested by many users at such an earlier stage. [0] https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3386436&group_… -- Marc Delisle http://infomarc.info

2 5

[Phpmyadmin-devel] Merging grid editing
by Marc Delisle 11 Aug '11

11 Aug '11

Aris, I would like to merge this feature but I get merge conflicts, can you have a look at this? -- Marc Delisle http://infomarc.info

3 11

[Phpmyadmin-devel] advisory rules and translation
by Marc Delisle 11 Aug '11

11 Aug '11

Tyron, the messages in the rules are not translatable using our standard gettext mechanism? -- Marc Delisle http://infomarc.info

4 7

[Phpmyadmin-devel] legal concerns about external libraries
by Isaac Bennetch 10 Aug '11

10 Aug '11

Good day, team The Fedora legal team has discovered a potential licensing problem in the PHPExcel library bundled with phpMyAdmin. If true, and I am not a lawyer but it seems they are correct, that puts phpMyAdmin itself in violation and Fedora would then remove our package until we resolve the licensing problem. The report is at https://bugzilla.redhat.com/show_bug.cgi?id=629214 and the Tom there is from the Fedora Legal team, Robert is the (friendly) Fedora phpMyAdmin maintainer who I've also copied on this message (who first came to us on IRC to discuss this problem). It looks like the problem had been reported to the PHPExcel in February of 2010 but not resolved (http://phpexcel.codeplex.com/Thread/View.aspx?ThreadId=83335). Robert's also mentioned that they're investigating a similar claim regarding tcpdf; I believe that discussion is at https://bugzilla.redhat.com/show_bug.cgi?id=548260 Regards, ~isaac

5 19

[Phpmyadmin-devel] Query statistics chart slows down page load
by Piotr Przybylski 10 Aug '11

10 Aug '11

Hi, Query statistics tab greatly increases page load time in my browser - I get about 5s delay before tabs are created which is IMO too slow. Removing "<?php printQueryStatistics(); ?>" from the code decreases it to less than a second and causes page load event to be fired about 10 seconds earlier (at 2nd second instead of 12th). I think this should be fixed, eg. by initializing chart only when user actually navigates to it. -- Regards, Piotr Przybylski

2 7

[Phpmyadmin-devel] Codemirror syntax highlighting gone?
by Tyron Madlener 10 Aug '11

10 Aug '11

Michal, not to long ago I thought I saw codemirror highlighting mysql keywords in red. Now there seems to be no related css classes for the highlighting anymore. Was this change on purpose?

3 2

[Phpmyadmin-devel] Broken Jenkins build
by Rouslan Placella 09 Aug '11

09 Aug '11

I managed to break the Jenkins build :( This happened when I was fixing a bug where triggers cannot be associated with views, as reported by Madhura on the list. Well, I just added in some calls to PMA_table::isView() to fix the issue, but the PMA_table class calls PMA_DBI_get_tables_full() which is not defined in unit tests. I'm not sure how I can fix this. Any ideas? Thanks. Rouslan

1 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

Developers