- Developers - lists.phpmyadmin.net

[Phpmyadmin-devel] MySQL-Error #1062 - Duplicate entry
by Stewart Morgan 12 Jan '06

12 Jan '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, I've noticed an "undefined offset" error in common.lib.php:736 v2.7.0pl2 when "manually" inserting a row with a duplicate primary-key value. The attached patch adds to mkkeck's update for feature request #1036254 by extracting the table name from "INSERT INTO" as well as "ALTER TABLE"; there are probably others too. PMA is a great bit of software, keep up the excellent work! Stewart, -- Stewart Morgan MEng MIEE Technical Director, Nameless-UK Phone : +44 870 757 1625 | Address : The Production House Fax : +44 870 168 0210 | 147a Saint Michael's Hill PGP ID : 0xECD5CE64 | Bristol, BS2 8DB, UK ---------------------------x------------------------------------- PGP Fingerprint: 89DE F8C3 CA14 598C 30DB 504A 3055 DDD7 ECD5 CE64 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1-nr1 (Windows XP) iD8DBQFDxSj3MFXd1+zVzmQRAlC9AKDHmk43t5KLVsOEReMMtPT3PXgNUQCffYGy YOxPyn31uLzfdZesNbelImY= =Ow7r -----END PGP SIGNATURE----- --- common.lib.php.orig Mon Jan 9 15:02:24 2006 +++ common.lib.php Tue Jan 10 12:32:04 2006 @@ -732,7 +732,7 @@ // get the duplicate entry // get table name - preg_match( '°ALTER\sTABLE\s\`([^\`]+)\`°iu', $the_query, $error_table = array() ); + preg_match( '°(?:ALTER\sTABLE|INSERT\sINTO)\s\`([^\`]+)\`°iu', $the_query, $error_table = array() ); $error_table = $error_table[1]; // get fields

2 3

Re: [Phpmyadmin-devel] Re: globals
by Michal Čihař 10 Jan '06

10 Jan '06

Hi I guess this should go to the list :-) On Thu, 22 Dec 2005 08:16:41 +0100 Sebastian Mendel <lists(a)sebastianmendel.de> wrote: > Michal Čihař schrieb: > > I don't see much benefit of this. This would mean to split files into > > smaller ones, what means more maintenance. For most things splitting > > will be tricky or will end in main category. > > with templates PMA will not include the text itself, but its name > > <?php > ... > $strings['CouldNotLoadExtension'] = null; > $template->append_by_ref( 'errors', $strings['CouldNotLoadExtension'] ); > ... > > ... > // load strings from DB > $sql = 'SELECT `id`, `string` FROM `cz` WHERE `id` IN (\'' . > implode(array_keys($strings)) . '\')'; > $strings = PMA_DBI_fetch_result($sql, 'id', 'string'); > ... > > ... > $template->display(); > ... > ?> Yes, templates would be great, but I still do not see advantage of db stored strings ;-). -- Michal Čihař | http://cihar.com

4 4

[Phpmyadmin-devel] problem with PMA_array_merge_recursive()
by Marc Delisle 06 Jan '06

06 Jan '06

Hi, can someone have a look at this, as I'm not familiar with this function. Here is my problem: in config.default.php we have $cfg['ForeignKeyDropdownOrder'] = array( 'content-id', 'id-content'); If in config.inc.php I put $cfg['ForeignKeyDropdownOrder'] = array( 'content-id'); the effective $cfg['ForeignKeyDropdownOrder'] after the merge contains 2 values and not just one are I configured. This problem can potentially happen with any directive containing an array. Marc

2 1

[Phpmyadmin-devel] how to set variables from $_REQUEST
by Marc Delisle 06 Jan '06

06 Jan '06

Hi, here is what I did in tbl_change.php: /** * Sets global variables. * Here it's better to use a if, instead of the '?' operator * to avoid setting a variable to '' when it's not present in $_REQUEST */ if (isset($_REQUEST['pos'])) { $pos = $_REQUEST['pos']; } if (isset($_REQUEST['session_max_rows'])) { $session_max_rows = $_REQUEST['session_max_rows']; } if (isset($_REQUEST['disp_direction'])) { $disp_direction = $_REQUEST['disp_direction']; } if (isset($_REQUEST['repeat_cells'])) { $repeat_cells = $_REQUEST['repeat_cells']; } if (isset($_REQUEST['dontlimitchars'])) { $dontlimitchars = $_REQUEST['dontlimitchars']; } if (isset($_REQUEST['primary_key'])) { $primary_key = $_REQUEST['primary_key']; } if (isset($_REQUEST['sql_query'])) { $sql_query = $_REQUEST['sql_query']; } ----------- I had to get variables from $_REQUEST to fix bug #1381856. I think we'll have to do this everywhere, to avoid getting "undefined variable" errors when fetching something that might not be present in $_REQUEST. Comments? Marc

2 1

[Phpmyadmin-devel] phpMyAdmin 2.7.0-pl2 is released
by Marc Delisle 27 Dec '05

27 Dec '05

Hi, This is patch level 2 for phpMyAdmin 2.7.0; in some MySQL 4.0.x installations, the dialog to create a table was not displayed. Marc Delisle, for the team

1 0

[Phpmyadmin-devel] Re: PMA db copy and InnoDB
by Michal Čihař 23 Dec '05

23 Dec '05

Hi Marc replying to devel list as I thing it belongs there. On Thu, 22 Dec 2005 13:46:20 -0500 Marc Delisle <Marc.Delisle(a)cegepsherbrooke.qc.ca> wrote: > Can you confirm that there remains some work to do, to be able to copy a > db containing innodb constraints? The constraints creation must be done > after all necessary tables have been created. If you copy one table, you have to handle constraints manually. While copying whole database, it should work (if there are not possible cross db relations, what I don't know right now). > Also, what's the goal of "Add constraints" ? I see that if someone does > not tick it, it's a way to copy a db without an error about constraints, > but what's next for the user? Manual constraints creation on the copy? Yes, currently you can use this to copy table without constraints. > A user cannot choose to copy "constraints only". If he could, this would > be interesting for him because he can do the full db copy in 2 passes > (assuming PMA does not let him do it in one pass). This should be easy to add, is it really needed? Shouldn't we provide tool for copying all dependent tables? -- Michal Čihař | http://cihar.com

2 4

[Phpmyadmin-devel] Merry Christmas and a Happy new Year
by Sebastian Mendel 23 Dec '05

23 Dec '05

Merry Christmas and a Happy new Year, to all! see you next year! -- Sebastian Mendel www.sebastianmendel.de

3 2

[Phpmyadmin-devel] A non-privileged user cannot change his password?
by Marc Delisle 23 Dec '05

23 Dec '05

Hi, I would like to know if this was discussed: $cfg['ShowChgPassword'] = $is_superuser = PMA_isSuperuser(); in http://cvs.sourceforge.net/viewcvs.py/phpmyadmin/phpMyAdmin/main.php?r1=2.9… I think that a non-privileged user should be able to change his password. Anyway, this code implies that there would be no reason for this parameter. Marc

2 1

[Phpmyadmin-devel] problem with $goto_whitelist
by Marc Delisle 18 Dec '05

18 Dec '05

Hi, in the bookmarks creation dialog, we have a hidden goto that contains "sql.php?db=mybase&table=mytable" and some other parameters. Current logic in common.lib.php: if (isset($_REQUEST['goto']) && in_array($_REQUEST['goto'], $goto_whitelist)) { fails in this case because the white list contains sql.php and we are comparing with a $_REQUEST['goto'] containing sql.php plus parameters. Same problem could happen for other parameters like $back, I'm not sure. Is there another function like in_array() but able to compare a substring? If not, we'll have to do something like: if (isset($_REQUEST['goto']) && in_array(substr($_REQUEST['goto'],0,strpos($_REQUEST['goto'] . '?','?')), $goto_whitelist)) { Marc

1 0

[Phpmyadmin-devel] current HEAD and charsets
by Marc Delisle 16 Dec '05

16 Dec '05

Hi, can you reproduce this? I create a table named école and after the CREATE TABLE, the name is corrupted (the name is internally encoded in UTF-8 by MySQL 4.1.x but it's not properly decoded when displayed in PMA). Then I can no longer work with the table (insert, search, etc). Same problem happens when connecting to a MySQL 4.0.x or 5.0.x server. This must be caused by a recent change in HEAD. Marc

2 2