I didn't see any changes to this file in cvs since the rc1 release so
this should apply cleanly.
This allows tables with multiple primary keys to be documented
correctly, without this only the last field is shaded.
The Schema creation is great, thanks for the good work.
-joshua eichorn
jeichorn(a)phpdoc.org
phpDocumentor (Php Auto Documentation) http://phpdoc.org
--- pdf_schema.php Wed Jun 19 13:44:29 2002
+++ pdf_schema.php Fri Jun 28 10:19:43 2002
@@ -319,6 +319,7 @@
var $fields = array();
var $height_cell = 6;
var $x, $y;
+ var $primary = array();
/**
@@ -390,7 +391,7 @@
reset($this->fields);
while (list(, $field) = each($this->fields)) {
- if($field == $this->primary){$pdf->SetFillColor(215,121,123);}
+ if(in_array($field,$this->primary)){$pdf->SetFillColor(215,121,123);}
if($field == $this->displayfield){$pdf->SetFillColor(142,159,224);}
$pdf->PMA_PDF_cellScale($this->width, $this->height_cell, ' ' . $field, 1, 1, 'L', 1);
$pdf->PMA_PDF_setXScale($this->x);
@@ -462,7 +463,7 @@
if(mysql_num_rows($result)>0){
while ($row = PMA_mysql_fetch_array($result)) {
if($row['Key_name'] == 'PRIMARY'){
- $this->primary = $row['Column_name'];
+ $this->primary[] = $row['Column_name'];
}
}
}
@@ -778,6 +779,7 @@
$pdf->SetDisplayMode('fullpage');
$pdf->Output($db . '_' . $pdf_page_number . '.pdf', TRUE);
+ //$pdf->Output('', TRUE);
} // end of the "PMA_RT_showRt()" method
> There's one thing of the new layout that I also don't like:
> If I want to run an SQL query I'd like to see the structure of the
> corresponding table... That's impossible with the new design.
> And I think others would have simular problems with that...
>
i agree there, but i propose that we only show the printview of the
structure there, to save time and bandwith.
--
Mike Beck
mike.beck(a)users.sourceforge.net
Sorry guys, I'm really too busy to work on PMA these days...
Loïc
-----Message d'origine-----
De: SailorMax <max(a)elkor.lv>
A: Lo?c <loic-div(a)ifrance.com>
Date: 28/06/02
Objet: bug report 2.3.0 rc2 (continue)
Yahoo Loic!
Previous my message:
~~~~~~~~~~~~~~~~~~~~
Sorry, don't have any time for find bug-place :)
Example:
I have table 'sys_user_data' with field 'ID' and some else.
query 'DELETE FROM sys_user_data WHERE ID >= 23' convert
to 'DELETE FROM sys_user_DATA WHERE ID >= 23' and myAdmin sad
'error' :)
~~~~~~~~~~~~~~~~~~~~
The decision:
~~~~~~~~~~~~~
file: sql.php
line1: 588
is: $res_words_arr = array("DROP", "SELECT", "DELETE", "UPDATE",
"INSERT", "LOAD", "EXPLAIN", "SHOW", "FROM", "INTO", "OUTFILE", "DATA",
"REPLACE", "CHECK", "ANALYZE", "REPAIR", "OPTIMIZE", "TABLE", "ORDER",
"HAVING", "LIMIT", "GROUP" , "DISTINCT");
must be: $res_words_arr = array("DROP", "SELECT", "DELETE", "UPDATE",
"INSERT", "LOAD", "EXPLAIN", "SHOW", "FROM", "INTO", "OUTFILE", "DATA",
"REPLACE", "CHECK", "ANALYZE", "REPAIR", "OPTIMIZE", "TABLE", "ORDER
BY", "HAVING", "LIMIT", "GROUP" , "DISTINCT", "WHERE", "VALUES",
"IGNORE");
(and so on. I can give you mysql.chm ;)
-----------------
file: sql.php
line1: 602
is: $sql_str = eregi_replace("$w ", "$w ", $sql_str);
must be: $sql_str = eregi_replace("([^A-Za-z_]+)$w ", "\\1$w ",
$sql_str);
$sql_str = eregi_replace("^$w ", "$w ", $sql_str);
-----------------
--
Go-seiko:-o inorimas! (SailorMax)
mails:
mailto:max@elkor.lv
mailto:sailormax@navigators.lv
mailto:sailormax@inbox.lv
Web-Page:
http://www.fao.lv/sm-infohttp://sm-info.h1.ru
______________________________________________________________________________
ifrance.com, l'email gratuit le plus complet de l'Internet !
vos emails depuis un navigateur, en POP3, sur Minitel, sur le WAP...
http://www.ifrance.com/_reloc/email.emailif
----- Original Message -----
From: "Rabus" <rabus(a)bugfixes.info>
> > Why, do you have last-minute changes to do for -rc2?
>
> Yes, I wanted to build a patch against bug #571409 before RC2 in order to
> have it tested by the Zend Accelerator people.
> But if you want, this can wait until RC3...
> We'll have an RC3, won't we?
You can release RC2. I've to much to do for school, sorry ... :-/
Alexander
I guess it would usefull to track the bugs related to the
newest changes... :)
Olivier
--
_________________________________________________________________
Olivier Mueller - om(a)8304.ch - PGPkeyID: 0E84D2EA - Switzerland
qmail projects: http://omail.omnis.ch - http://webmail.omnis.ch
> > what about reducing the size of the "QBE" label in german ?
> I tried to
> find
> > a better term in German, but have not found one yet... Vielleicht
> > hast Du eine Idee? :)
>
> Ich habe mir da auch schon Gedanken darüber gemacht... Ich
> dachte da an
> "Abfrage", was in etwa so ausdrucksstark wäre wie "Query" im
> Englischen.
> Beide Ausdrücke sind mir allerdings ehrlichgesagt etwas zu kurz.
>
> In other words: no idea, let's just leave it as long as it is... :o)
>
> Alexander
the Equivalent of this page in MS Access is called Query Editor
(Abfrageeditor) - at least shorter than 'Query by Example', and let's face
it: a lot of newbies who are dealing with MySQL for the first time, might
have used Access, even if not it should be a understandable name...
btw: on the Select page of the tables i suggest having some helptext at the
bottom, saying
Tip:
if you need to have this tables data connected to other tables try the <a
href="tbl_qbe.php3">Query Editor</a>
--
Mike Beck
mikebeck(a)users.sourceforge.net
Little poll : what about setting "Structure" as default tab
when displaying db_details or tbl_properties on the first time?
I guess the people using PMA are not using the SQL tab
very often... :) (and I have always having to click on
structure every time :)
Olivier
--
_________________________________________________________________
Olivier Mueller - om(a)8304.ch - PGPkeyID: 0E84D2EA - Switzerland
qmail projects: http://omail.omnis.ch - http://webmail.omnis.ch
> I just checked out an older phpMyAdmin CVS version (2002-6-21
> 20:00) that
> contained v1.15 of tbl_properties_links.php3.
> I encounter the same problems with this version.
> For all linux users, I attached two screenshots that will show you the
> difference between the ie6 and the Opera interpretation on my machine.
jup, ie is breaking the qbe translation badly, that is one reason why i opt
to call it 'query editor' i allready asked marc about that, but he said it
would be hell to try to get all translators to adopt it. well for the german
version (only the none-utf) i changed that once, and i saw some translators
use shorter names for this as well (presumably for this reason?)
maybe they will do so by themselves, when they see it ;-)
--
Mike Beck
mikebeck(a)users.sourceforge.net
Hi list,
I just got the latest CVS files...
If you use the German language file for example, the tab design looks really
bad under IE6...
If you view the same page with Opera, everything is OK.
Could someone check this?
Alexander