Hi,
I plan to release 2.3.0-rc1 tomorrow, then we only merge:
- translation updates
- light patches
- light bug fixes.
Any show stopper you can think of?
Marc
I've found a MAJOR bug in the colourizing SQL formatting. The Bug ID is
#570898.
Priority: 9
Severity: Blocker
(I've been using bugzilla a bit much)
Copy of bug report:
just from looking at the colourizing code, I wondered what would happen
with a specific query. So I tried it out with dire results:
SQL Query fragment:
CREATE TABLE bar1 (
bar text NOT NULL
) TYPE=MyISAM;
INSERT INTO bar1 VALUES ('I\'m a little teapot. Short and STOUT.
=_=.\r\n,,,,, commas ;;;;; semi-colons\r\nSELECT DATABASE TABLE DOUBLE
\r\n');
Output:
CREATE TABLE bar1 (
bar text NOT NULL
) TYPE=MyISAM;
INSERT
INTO bar1
VALUES (
'I\'malittleteapot.ShortandSTOUT.=_=.\r\n,,,,,commas;;;;;semi-colons\r\nSELECTDATABASETABLEDOUBLE\r\n'
)
This will TOTALLY strip the spaces in the displayed query, which destroys
the string that is displayed.
Part two:
Using the previous table, go to manually insert a row, and use this for
your data:
I'm a little teapot. Short and STOUT. =_=.
,,,,, commas ;;;;; semi-colons
SELECT DATABASE TABLE DOUBLE
Here is the output:
INSERT
INTO `bar1` ( `bar` )
VALUES ( ' ) ;
We have lost the ENTIRE string.
The flaw is a major design flaw in the code with regards to the way that
quotes ( ' " ` ) are handled.
At the moment the format parser breaks down the query at the start.
Instead of doing that, we need to work thru the query character by
character.
--
Robin Hugh Johnson
E-Mail : robbat2(a)orbis-terrarum.net
Home Page : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ# : 30269588 or 41961639
Hi list,
I don't want to set $cfg['DefaultCharset'] statically in config.inc.php3.
Because we can't select the charset to each MySQL server with different charset.
This feature is not good, I think.
Best regards,
luc
Hi List,
I've done some bug hunting.
Server:
Apache2.0.36, PHP-4.3.0-dev, MySQL 3.23.49a
Browsers:
Mozilla 1.1 alpha (mips-sgi-irix6.5), Mozilla 1.0
(i686-pc-linux-gnu) , IE6, IE5.5, Konqueuer 2.2.2
I've posted up 4 new bugs on the tracker that are actually code bugs, that
effect all the browsers. I haven't tested for any browser-specific
problems, but if you want me to, just tell me a test case and I'll try it
out.
I can test with large number of other browsers and platforms as well, just
tell me what you want me to try out. (My boss told me I can work on PMA
some while we wait for something, so I'm literally getting paid to work on
it now :-)
--
Robin Hugh Johnson
E-Mail : robbat2(a)orbis-terrarum.net
Home Page : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ# : 30269588 or 41961639
Hi
> >-> You have an error in your SQL syntax near '' at line 1
> >(tested with opera and netscape)
You get (or got, I did use yesterday version) when pmadb was not set in
config, which is probably not correct behavior.
Regards
Michal Cihar
nijel at users dot sourceforge dot net
http://cihar.liten.cz
I'm testing the CVS as at 8pm -0800 with Apache2.
And adding bug reports to the SF tracker.
--
Robin Hugh Johnson
E-Mail : robbat2(a)orbis-terrarum.net
Home Page : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ# : 30269588 or 41961639
Hi,
This has been suggested to me by Michal, and I want to get your opinion:
if $cfg['AllowAnywhereRecoding'] is false, do we need to display all the
-utf-8 choices in the drop-down for language selection?
In other words, will users have the need to use the -utf-8 charset in
other situations?
Another idea: would it be OK to display only the -utf-8 choices when
$cfg['AllowAnywhereRecoding'] is true?
I assume that PMA 2.3.0 will have more -utf-8 language files than the
present czech, english and german.
--
Marc Delisle
hi everybody,
i just finished and merged the transition of the tables to a centralized
pmadb, please have a look at the changelog and documentation.html / .txt to
see what has been changed and where the tables are suppossed to be now.
( i only had time to take care of installation and configuration instructions
there, possibly the faq/usage tips has to be changed as well, allthough i
doubt, maybe somebody can have a look?
also note, that in config.inc.php3 the variable is no longer called bookmarkdb
but pmadb (this is changed in the bookmarkstuff as well, you only will need
to check your config.inc.developer.php3)
column_comments are now possible, they are written in tbl_relation and as yet
only shown in tbl_printview (you won't usually have enough place for them in
the pdf anyway). maybe a usage tip for that would help.
i did not find the time to see about the one bug where syntaxcoloring doesn't
show the table comment.
also i saw a bug which only occurs with konqueror 3 it seems: when i want to
update a rows content instead it always inserted a new row for me, with
mozilla it was ok.
still all the relationstuff should work now, and if you need any of those
information have a look at libraries/relation.lib.php3, there is some nice
functions there that should make life easier (like finding out which features
actually should work)
hope it works well enough that it won't be in the way of releasing rc1
cheers
Mike Beck
mikebeck(a)users.sourceforge.net
> PDF related problems
the whole relation/bookmark/pdf stuff has been widely rewritten by me now
because of moving the tables to a central db so a lot has changed there ...
> - when $cfg['Servers'][$i]['table_coords'] is set and
> $cfg['Servers'][$i]['pdf_pages'] is not set it produces just MySQL error
> message, but IMHO it should report that it is wrong configured
shouldn't happen anymore because of the different way that i check this in
libraries/relation.inc.php3
> - when I want to have just one table in pdf and it doesn't have any
> relations
> I get just "Undefined PDF page number!" error
please see if this will still happen with the new code, even then i think this
is more a problem of giving a decent errormessage than of actually changing a
lot there - there is not much sense in creating pdfs of only one table.
if you want a column list of one table have a look at tbl_printview
> - is it possible to have one table on more pages?
yes it is, but should allready have been possible with the code you have this
is what we created the pdf_pages table for.
> - when I edit tables which will be displayed on some page and I select table
> instead of one already selected it is added, not replaced
? i was sure i had tested that. i hope i can test this again later when i
finished all the other changes
> - is there any easy possibily how to use it in just few databases without
> getting errors in the others?
this will work without problems now with the new centralized pma_db
> - it works only with iso-8859-1 charset :-(
because of the fpdf library that is used there as told in the documentation.
could you enable this library to use other charsets?
> Syntaxcoloring
> - (this is not bug just suggestion) Do you realy think that blue color as
> default for some types ("colorKeywords" and "colorAdd") is good? It looks as
> links, what about using for example: #990099
;-) rabus allready said this, please feel free to change the color and commit
> - when I create table with comment, the comment is not displayed (when
> coloring switched off it is displayed correctly).
it is? oops, mea culpa.. hmm don't have an immediate idea why this should
happen...
> Other
> $cfg['Servers'][$i]['column_comments'] - will it be used or it shouldn't be
> in config?
well i want to do this for 2.3.0 allthough time is running out - as mentioned
before i will be in malta diving for one week starting tomorrow, and i still
have to work in a bar tonight. so in a few hours i will have to stop. if i
cannot make it until then, you want to release on the 18th as planned and
nobody else finds the time to add this to tbl_relation (to enter comments)
and tbl_printview (to show them) just remove this
> How about adding links to db/table structure in left frame? I mostly use
> this page in PMA and in 2.3.0 it's one more click for me :-(.
me too, but i don't want to have more than one link per table on the left side
- i have databases with about 30 tables and i want to have them all on one
side.
but we could have a vote of wether it is more practical to get to structure or
to get to sql page
cheers
Mike Beck
mikebeck(a)users.sourceforge.net