Re: [Phpmyadmin-devel] How to join and attach patches

Only the original submitter and project members van attach files to already open tracker artifacts. Adding an artifact to the patches tracker would probably be the best course of action.

I've add new patch in patch tracker "After import also display uploaded filename" ID: 2962655 https://sourceforge.net/tracker/?func=detail&aid=2962655&group_id=23...

Here are a few quick first remarks about the patch

• you put the filename in a separate formfield, couldn't we use

$import_file for this?

$import_file variable store the file name on the server instead of on the client.

• you indented some of the lines with a tab-character, please use 4

spaces as is recommended by the PEAR coding standards

I've fixed it

-- Met vriendelijke groet / Regards,

Herman van Rink Initfour websolutions

Best regards. Pavel Konnikov