Michal Čihař wrote:
Hi
On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
i would like to commit this into CVS, if no one is against.
I just quickly looked at the patch, My comments follow. The all do not address new code, however when the code is being touched, it could be cleaned up :-). Those are just minor issues, generally I like it.
- do not hardcode color in global css - do not change error reporting - you can rely on fact that all cfg parameters are set, this includes PmaAbsoluteUri
also $GLOBALS['cfg']['Bookmark']['db'] ? if ( ! empty( $GLOBALS['cfg']['Bookmark'] ) && $GLOBALS['cfg']['Bookmark']['db'] && $GLOBALS['cfg']['Bookmark']['table'] ) { can become if ( $GLOBALS['cfg']['Bookmark']['db'] && $GLOBALS['cfg']['Bookmark']['table'] ) { ? -- Sebastian Mendel www.sebastianmendel.de www.sf.net/projects/phpdatetime | www.sf.net/projects/phptimesheet