This is an interesting comment. In particular, I like the idea that the theme generator wouldn't be tied to the specific phpMyAdmin instance the theme will be used at.
I think at this point, it's best to keep the theme generator in a separate repository from phpMyAdmin — but it's okay to require working with an existing phpMyAdmin installation (if we need to load library files or something from PMA).
On Sat, May 12, 2018 at 11:08 AM, Lakshay arora arora.lakshya123@gmail.com wrote:
Considering how themes are implemented in phpmyadmin, where each theme has its separate files in the themes folder, each having css, js, images and the theme info, I think theme generator could be deployed as a web app on the phpmyadmin website itself. Something like www.phpmyadmin.com/theme-generator. Anyone could create a theme and export it as a zip file with all these files in it, this could be directly extracted to the themes folder and they would be ready to go.
But, also considering the fact that phpmyadmin is moslty used in third party servers which users directly buy online from the host, there could be an upload theme option in the software which would upload and save the theme user creates.
Lakshya
On Tue, May 8, 2018 at 7:55 PM, Isaac Bennetch bennetch@gmail.com wrote:
Hello developers,
As we ramp up for GSoC, Saksham and I have come across our first big design question to solve: Where to put the theme generator?
I'd like some input on this. It seems to me this should be put in a different repository. Perhaps it should tightly integrate with phpMyAdmin, but perhaps it doesn't need to and can stand alone. I'm considering a standalone project that also can be included in phpMyAdmin (perhaps with composer install phpmyadmin-themegenerator or something vaguely like that) and phpMyAdmin would integrate with it if installed, but I'm also considering that such a thing might not be that needed and be overdesigning a solution.
I have a few ideas bouncing around in my head but could benefit from some community/developer input.
Isaac
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers