Le sam. 3 oct. 2015 à 12:46, Remi Collet remi@fedoraproject.org a écrit :
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Le 03/10/2015 09:14, Hugues Peccatte a écrit :
Dear developers,
The following PR is trying to use namespaces and autoloading for pMA: https://github.com/phpmyadmin/phpmyadmin/pull/11428 This PR seems to be quite stable now. As almost all PHP files had been updated, this is a huge work to test all cases, all configurations, all features. Would it be possible to have some testers please?
At a first (and quick) look
PMA\libraries namespace seems a bit uggly...
'libraries' is a directory, only a layout artefact, why should it be part of the namespace.
Per PSR-4 definition, namespace should be
"The fully qualified class name MUST have a top-level namespace name, also known as a "vendor namespace".So, is PMA the "vendor" ? it seems.
"The fully qualified class name MAY have one or more sub-namespace names."I think a second level is needed (but again, "libraries" seems strange to me... but perhaps only to me)
Notice: it will be nice to move all 3rd party lib to a separate directory (will make downstream work much easier)
Remi.
Thanks to Marc and Isaac who already did a lot of tests. And thanks to new testers.
Have a nice day,
H.
_______________________________________________ Developers mailing list Developers@phpmyadmin.net https://lists.phpmyadmin.net/mailman/listinfo/developers
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlYPhnsACgkQYUppBSnxahgeqQCgrqY4W1TuTzxvpiwSLcVfiVKq lUYAoIopoJ4hHCeYEdGD7YFGsPUg6htx =d2Wp -----END PGP SIGNATURE-----
Hi Remi,
Thanks for your feedback.
Why does PMA\libraries seem ugly? OK, "libraries" is a directory, but all classes are not in libraries, that's why I decided to set the vendor namespace (PMA) at project root. If needed, we can imagine to have a specific vendor namespace for libraries, but why and which one?
I saw your notice about moving 3rd party libraries. But I think this is not the subject here. In fact, this is a really huge work that had been done (at least, I think…) and I think that a lot of subjects could be discussed here. That's why I'ld like to focus on test and errors.
Had you some time to test the PR?
Thanks, H.